[jira] [Commented] (KAFKA-2249) KafkaConfig does not preserve original Properties

[ https://issues.apache.org/jira/browse/KAFKA-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14581505#comment-14581505 ] Gwen Shapira commented on KAFKA-2249: - Created reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-2249) KafkaConfig does not preserve original Properties

[ https://issues.apache.org/jira/browse/KAFKA-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2249: Attachment: KAFKA-2249.patch > KafkaConfig does not preserve original Properties > -

Review Request 35347: Patch for KAFKA-2249

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35347/ --- Review request for kafka. Bugs: KAFKA-2249 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2249) KafkaConfig does not preserve original Properties

[ https://issues.apache.org/jira/browse/KAFKA-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2249: Assignee: Gwen Shapira Status: Patch Available (was: Open) > KafkaConfig does not preserve or

[jira] [Updated] (KAFKA-1882) Create extendable channel interface and default implementations

[ https://issues.apache.org/jira/browse/KAFKA-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1882: Fix Version/s: (was: 0.8.3) > Create extendable channel interface and default implementations >

[jira] [Resolved] (KAFKA-1882) Create extendable channel interface and default implementations

[ https://issues.apache.org/jira/browse/KAFKA-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira resolved KAFKA-1882. - Resolution: Duplicate I believe this is already handled in the SSL patches > Create extendable ch

Re: [VOTE] KIP-25 System test improvements

+1 ~ Joestein On Jun 10, 2015 10:21 PM, "Neha Narkhede" wrote: > +1. Thanks Geoff! > > > > > > On Wed, Jun 10, 2015 at 6:20 PM -0700, "Gwen Shapira" < > gshap...@cloudera.com> wrote: > > > > > > > > > > > +1 (non-binding. Actually, since this is non-binding anyway, lets make > it +100. I'm so so

[jira] [Commented] (KAFKA-2022) simpleconsumer.fetch(req) throws a java.nio.channels.ClosedChannelException: null exception when the original leader fails instead of being trapped in the fetchResponse

[ https://issues.apache.org/jira/browse/KAFKA-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14581473#comment-14581473 ] Jinder Aujla commented on KAFKA-2022: - Hi I also noticed this, here is part of the st

[jira] [Commented] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14581419#comment-14581419 ] manpreet singh commented on KAFKA-1792: --- Integrated the patch and tested this new op

Re: [VOTE] KIP-25 System test improvements

+1. Thanks Geoff! On Wed, Jun 10, 2015 at 6:20 PM -0700, "Gwen Shapira" wrote: +1 (non-binding. Actually, since this is non-binding anyway, lets make it +100. I'm so so excited about having a usable testing framework) On Wed, Jun 10, 2015 at 6:10 PM, Geoffrey Anderson wrote: > Hi

Re: [VOTE] KIP-25 System test improvements

+1 (non-binding. Actually, since this is non-binding anyway, lets make it +100. I'm so so excited about having a usable testing framework) On Wed, Jun 10, 2015 at 6:10 PM, Geoffrey Anderson wrote: > Hi Kafka, > > After a few rounds of discussion on KIP-25, there doesn't seem to be > opposition, s

[VOTE] KIP-25 System test improvements

Hi Kafka, After a few rounds of discussion on KIP-25, there doesn't seem to be opposition, so I'd like to propose a vote. Thanks, Geoff On Mon, Jun 8, 2015 at 10:56 PM, Geoffrey Anderson wrote: > Hi KIP-25 thread, > > I consolidated some of the questions from this thread and elsewhere. > > Q:

Re: Review Request 35201: Fix KAFKA-2253

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35201/#review87495 --- core/src/main/scala/kafka/server/DelayedOperation.scala

[jira] [Resolved] (KAFKA-2261) Provide a configurable timeout for NetworkClient.send

[ https://issues.apache.org/jira/browse/KAFKA-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin resolved KAFKA-2261. - Resolution: Duplicate This is duplicate to KAFKA-2120 and KIP-19 addressed it. > Provide a config

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14581292#comment-14581292 ] Ashish K Singh commented on KAFKA-1367: --- [~junrao] and [~jjkoshy], correct me if my

[jira] [Created] (KAFKA-2262) LogSegmentSize validation should be consistent

Jun Rao created KAFKA-2262: -- Summary: LogSegmentSize validation should be consistent Key: KAFKA-2262 URL: https://issues.apache.org/jira/browse/KAFKA-2262 Project: Kafka Issue Type: Bug Co

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

+1 Thanks, Jun On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen wrote: > Hi Kafka, > > After a long discussion, please help vote again for the > KIP. Thanks. > > > > I wrote a KIP for this after some discussion on KAFKA-1646. > https://issues.apache.org/jira/browse/KAFKA-1646 > >

Re: Review Request 33204: Patch for KAFKA-1646 merge to latest trunk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/#review87450 --- Ship it! Thanks for the patch. +1. Just some minor comments below.

Re: Review Request 34789: Patch for KAFKA-2168

> On June 9, 2015, 7:58 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, > > line 1212 > > > > > > -1 makes the pollClient block forever. So, we don't get a chance

Re: KIP Call Notes

Jayesh, Most of the metadata you mentioned already exist. For example, ISR is already in the TopicMetadataResponse and the high water mark can be returned from the OffsetRequest. The details of the current wire protocol can be found at https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+T

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

+1 On Wed, Jun 10, 2015 at 11:45 AM, Jakob Homan wrote: > +1 > > > > > On Jun 10, 2015, at 10:36 AM, JG Homan wrote: > > > > +1 > > > > On Wed, Jun 10, 2015 at 10:12 AM, Gwen Shapira > wrote: > > +1 (non-binding) > > > > On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen > > wrote: > > > Hi Kafka,

Build failed in Jenkins: Kafka-trunk #506

See Changes: [wangguoz] KAFKA-2253; fix deadlock between removeWatchersLock and watcher operations list lock; reviewed by Onur Karaman and Jiangjie Qin -- [...truncated 419 lines...] org.apache.kafka

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

+1 > On Jun 10, 2015, at 10:36 AM, JG Homan wrote: > > +1 > > On Wed, Jun 10, 2015 at 10:12 AM, Gwen Shapira wrote: > +1 (non-binding) > > On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen > wrote: > > Hi Kafka, > > > > After a long discussion, please help vote again for the KIP. > > Thanks.

[jira] [Updated] (KAFKA-2253) Deadlock in delayed operation purgatory

[ https://issues.apache.org/jira/browse/KAFKA-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2253: - Resolution: Fixed Status: Resolved (was: Patch Available) > Deadlock in delayed operation

[jira] [Commented] (KAFKA-2253) Deadlock in delayed operation purgatory

[ https://issues.apache.org/jira/browse/KAFKA-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580921#comment-14580921 ] Guozhang Wang commented on KAFKA-2253: -- Thanks for all the reviews! Committed to trun

[jira] [Created] (KAFKA-2261) Provide a configurable timeout for NetworkClient.send

Glenn Sontheimer created KAFKA-2261: --- Summary: Provide a configurable timeout for NetworkClient.send Key: KAFKA-2261 URL: https://issues.apache.org/jira/browse/KAFKA-2261 Project: Kafka Iss

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

+1 On Wed, Jun 10, 2015 at 10:12 AM, Gwen Shapira wrote: +1 (non-binding) On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen wrote: > Hi Kafka, > > After a long discussion, please help vote again for the KIP. > Thanks. > > > > I wrote a KIP for this after some discussion on KAFKA-1646. > https://

[jira] [Commented] (KAFKA-2253) Deadlock in delayed operation purgatory

[ https://issues.apache.org/jira/browse/KAFKA-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580837#comment-14580837 ] Mayuresh Gharat commented on KAFKA-2253: Thanks [~guozhang] for this patch. I test

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

+1 (non-binding) On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen wrote: > Hi Kafka, > > After a long discussion, please help vote again for the KIP. > Thanks. > > > > I wrote a KIP for this after some discussion on KAFKA-1646. > https://issues.apache.org/jira/browse/KAFKA-1646 > > h

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

+1 > On Jun 10, 2015, at 9:38 AM, Jay Kreps wrote: > > +1 > > On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen > wrote: > >> Hi Kafka, >> >>After a long discussion, please help vote again for the >> KIP. Thanks. >> >> >> >> I wrote a KIP for this after some discussion on KAF

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

+1 On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen wrote: > Hi Kafka, > > After a long discussion, please help vote again for the > KIP. Thanks. > > > > I wrote a KIP for this after some discussion on KAFKA-1646. > https://issues.apache.org/jira/browse/KAFKA-1646 > > > https://cwi

Re: Review Request 34789: Patch for KAFKA-2168

> On June 9, 2015, 6:49 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, > > line 322 > > > > > > Do we need this? There is no real guarantee on the poll time, so

Re: Review Request 34789: Patch for KAFKA-2168

> On June 9, 2015, 7:58 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, > > line 1212 > > > > > > -1 makes the pollClient block forever. So, we don't get a chance

Re: Review Request 34789: Patch for KAFKA-2168

> On June 9, 2015, 7:58 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, > > line 1212 > > > > > > -1 makes the pollClient block forever. So, we don't get a chance

Re: Review Request 34789: Patch for KAFKA-2168

> On June 9, 2015, 7:58 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, > > line 1212 > > > > > > -1 makes the pollClient block forever. So, we don't get a chance

Re: Review Request 34789: Patch for KAFKA-2168

> On June 9, 2015, 6:49 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, > > line 322 > > > > > > Do we need this? There is no real guarantee on the poll time, so

Re: KIP Call Notes

Our company (Conversant Media) became a Kafka user pretty recently (about 3 months ago) and I have been following the user and dev group for the past month, so could have missed the discussions on KIP-4. In looking up the current command line capabilities in Kafka 0.8.2.1 (not the latest release

Re: Review Request 34789: Patch for KAFKA-2168

> On June 9, 2015, 7:58 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/OffsetResetStrategy.java, > > line 16 > > > > > > Do we need NONE? > > Jason Gustafson wrote: > It was there