Re: [DISCUSS] KIP-25 System test improvements

Hi KIP-25 thread, I consolidated some of the questions from this thread and elsewhere. Q: Can we see a map of what system-test currently tests, which ones we want to replace and JIRAs for replacing? A: Initial draft here: https://cwiki.apache.org/confluence/display/KAFKA/Roadmap+-+port+existing+s

[jira] [Created] (KAFKA-2260) Allow specifying expected offset on produce

Ben Kirwin created KAFKA-2260: - Summary: Allow specifying expected offset on produce Key: KAFKA-2260 URL: https://issues.apache.org/jira/browse/KAFKA-2260 Project: Kafka Issue Type: Improvement

[jira] [Comment Edited] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578235#comment-14578235 ] Honghai Chen edited comment on KAFKA-1646 at 6/9/15 3:07 AM: -

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578235#comment-14578235 ] Honghai Chen commented on KAFKA-1646: - Created reviewboard against branch origin/trun

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150609_MergeToLatestTrunk.patch > Improve consumer read performance for Win

Re: Review Request 33204: Patch for KAFKA-1646 merge to latest trunk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/ --- (Updated June 9, 2015, 3:02 a.m.) Review request for kafka. Summary (updated)

Re: Review Request 33378: Patch for KAFKA-2136

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/ --- (Updated June 9, 2015, 1:37 a.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Commented] (KAFKA-2254) The shell script should be optimized , even kafka-run-class.sh has a syntax error.

[ https://issues.apache.org/jira/browse/KAFKA-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578153#comment-14578153 ] Bo Wang commented on KAFKA-2254: The trunk have fixed kafka-run-class.sh syntax error. >

Re: Review Request 35231: Fix KAFKA-1740

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35231/#review87107 --- I'll try to do a more detailed review soon. I just want to get this

Re: Review Request 33378: Patch for KAFKA-2136

> On June 5, 2015, 2:43 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/api/FetchResponse.scala, line 143 > > > > > > follow-up Can you elaborate? > On June 5, 2015, 2:43 a.m., Joel Koshy wrote: > > core/src/m

[jira] [Updated] (KAFKA-2254) The shell script should be optimized , even kafka-run-class.sh has a syntax error.

[ https://issues.apache.org/jira/browse/KAFKA-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Wang updated KAFKA-2254: --- Priority: Major (was: Critical) > The shell script should be optimized , even kafka-run-class.sh has a syntax

Re: [DISCUSS] KIP-25 System test improvements

Hi Gwen, I don't see any problem with this as long as we're convinced there's a good use case, which seems to be true. Cheers, Geoff On Thu, Jun 4, 2015 at 5:20 PM, Gwen Shapira wrote: > Not completely random places :) > People may use Cloudera / HWX distributions which include Kafka, but want

[jira] [Updated] (KAFKA-2254) The shell script should be optimized , even kafka-run-class.sh has a syntax error.

[ https://issues.apache.org/jira/browse/KAFKA-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Wang updated KAFKA-2254: --- Status: Patch Available (was: Open) I create a patch kafka-shell-script.patch of the trunk . > The shell scr

[jira] [Updated] (KAFKA-2254) The shell script should be optimized , even kafka-run-class.sh has a syntax error.

[ https://issues.apache.org/jira/browse/KAFKA-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Wang updated KAFKA-2254: --- Attachment: kafka-shell-script.patch > The shell script should be optimized , even kafka-run-class.sh has a sy

[jira] [Updated] (KAFKA-2254) The shell script should be optimized , even kafka-run-class.sh has a syntax error.

[ https://issues.apache.org/jira/browse/KAFKA-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Wang updated KAFKA-2254: --- Status: Patch Available (was: Open) > The shell script should be optimized , even kafka-run-class.sh has a sy

[jira] [Updated] (KAFKA-2254) The shell script should be optimized , even kafka-run-class.sh has a syntax error.

[ https://issues.apache.org/jira/browse/KAFKA-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Wang updated KAFKA-2254: --- Status: Open (was: Patch Available) > The shell script should be optimized , even kafka-run-class.sh has a sy

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578053#comment-14578053 ] Jun Rao commented on KAFKA-1367: Yes, perhaps some kind of more general locality could be

[jira] [Issue Comment Deleted] (KAFKA-2208) Consumer should detect coordinator failures

[ https://issues.apache.org/jira/browse/KAFKA-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2208: - Comment: was deleted (was: Created reviewboard https://reviews.apache.org/r/35231/diff/ against b

[jira] [Commented] (KAFKA-1740) Merge Offset manager into Coordinator

[ https://issues.apache.org/jira/browse/KAFKA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578032#comment-14578032 ] Guozhang Wang commented on KAFKA-1740: -- Created reviewboard https://reviews.apache.or

[jira] [Work started] (KAFKA-1740) Merge Offset manager into Coordinator

[ https://issues.apache.org/jira/browse/KAFKA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-1740 started by Guozhang Wang. > Merge Offset manager into Coordinator > - >

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578031#comment-14578031 ] Sriharsha Chintalapani commented on KAFKA-1690: --- [~junrao] meant to say Gath

[jira] [Updated] (KAFKA-1740) Merge Offset manager into Coordinator

[ https://issues.apache.org/jira/browse/KAFKA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1740: - Status: Patch Available (was: In Progress) > Merge Offset manager into Coordinator >

[jira] [Commented] (KAFKA-2208) Consumer should detect coordinator failures

[ https://issues.apache.org/jira/browse/KAFKA-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578030#comment-14578030 ] Guozhang Wang commented on KAFKA-2208: -- Created reviewboard https://reviews.apache.or

Re: Review Request 35231: Fix KAFKA-1740

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35231/ --- (Updated June 8, 2015, 11:12 p.m.) Review request for kafka. Bugs: KAFKA-1740

[jira] [Updated] (KAFKA-2208) Consumer should detect coordinator failures

[ https://issues.apache.org/jira/browse/KAFKA-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2208: - Attachment: KAFKA-2208.patch > Consumer should detect coordinator failures > -

Review Request 35231: Fix KAFKA-1740

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35231/ --- Review request for kafka. Bugs: KAFKA-2208 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-2259) port offset_management_testsuite

Geoffrey Anderson created KAFKA-2259: Summary: port offset_management_testsuite Key: KAFKA-2259 URL: https://issues.apache.org/jira/browse/KAFKA-2259 Project: Kafka Issue Type: Sub-task

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578020#comment-14578020 ] Jun Rao commented on KAFKA-1690: 2. I am not sure what the best approach is. Currently, Se

[jira] [Created] (KAFKA-2258) Port mirrormaker_testsuite

Geoffrey Anderson created KAFKA-2258: Summary: Port mirrormaker_testsuite Key: KAFKA-2258 URL: https://issues.apache.org/jira/browse/KAFKA-2258 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-2257) port replication_testsuite

Geoffrey Anderson created KAFKA-2257: Summary: port replication_testsuite Key: KAFKA-2257 URL: https://issues.apache.org/jira/browse/KAFKA-2257 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-2256) Port system tests

Geoffrey Anderson created KAFKA-2256: Summary: Port system tests Key: KAFKA-2256 URL: https://issues.apache.org/jira/browse/KAFKA-2256 Project: Kafka Issue Type: Improvement Com

Re: Review Request 34492: Patch for KAFKA-2210

> On June 3, 2015, 11:36 p.m., Parth Brahmbhatt wrote: > > core/src/main/scala/kafka/security/auth/Acl.scala, lines 57-62 > > > > > > I tried exactly that but it tunrs out our current Json parser does not > > work when

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577912#comment-14577912 ] Sriharsha Chintalapani commented on KAFKA-1690: --- [~junrao] currently working

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577881#comment-14577881 ] Jun Rao commented on KAFKA-1690: [~sriharsha], thanks for the latest patch. Haven't looked

[jira] [Commented] (KAFKA-2232) make MockProducer generic

[ https://issues.apache.org/jira/browse/KAFKA-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577806#comment-14577806 ] Alexander Pakulov commented on KAFKA-2232: -- Pull request has been submitted: http

[GitHub] kafka pull request: Make MockProducer generic

GitHub user apakulov opened a pull request: https://github.com/apache/kafka/pull/68 Make MockProducer generic MockConsumer and MockProducer have been moved to test source set. KeySerializer and ValueSerializer have been added to mimic actual KafkaProducer behavior. You can merg

Re: Review Request 35201: Fix KAFKA-2253

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35201/#review87077 --- Ship it! Ship It! - Onur Karaman On June 8, 2015, 6:47 p.m., Guo

Re: [DISCUSS] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

Honghai, You are going to do a vote on this, right? I think the patch is ready to go so we are just waiting on the KIP adoption I think. -Jay On Thu, May 21, 2015 at 8:50 AM, Jun Rao wrote: > Honghai, > > Could you update the wiki on the preallocated size? Instead of > config.segmentSize > - 2

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577758#comment-14577758 ] Jiangjie Qin commented on KAFKA-1367: - I agree with [~gwenshap], it sounds this deserv

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577728#comment-14577728 ] Gwen Shapira commented on KAFKA-1367: - By "zones" do we mean rack-awareness? Or more g

Re: Review Request 35201: Fix KAFKA-2253

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35201/#review87065 --- Ship it! Ship It! - Jiangjie Qin On June 8, 2015, 6:47 p.m., Guo

[jira] [Commented] (KAFKA-2253) Deadlock in delayed operation purgatory

[ https://issues.apache.org/jira/browse/KAFKA-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577639#comment-14577639 ] Guozhang Wang commented on KAFKA-2253: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-2253) Deadlock in delayed operation purgatory

[ https://issues.apache.org/jira/browse/KAFKA-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2253: - Attachment: KAFKA-2253_2015-06-08_11:47:40.patch > Deadlock in delayed operation purgatory > -

Re: Review Request 35201: Fix KAFKA-2253

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35201/ --- (Updated June 8, 2015, 6:47 p.m.) Review request for kafka. Bugs: KAFKA-2253

[jira] [Commented] (KAFKA-2225) Allow fetching from ISR

[ https://issues.apache.org/jira/browse/KAFKA-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577571#comment-14577571 ] Jun Rao commented on KAFKA-2225: A few notes on this. 1. We probably should only do this

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577563#comment-14577563 ] Jun Rao commented on KAFKA-1367: Yes, we need some kind of notion of zones for both the br

[jira] [Comment Edited] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577509#comment-14577509 ] Aditya Auradkar edited comment on KAFKA-1367 at 6/8/15 5:40 PM:

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577509#comment-14577509 ] Aditya Auradkar commented on KAFKA-1367: [~jjkoshy] [~junrao] KAFKA-2225, even if

[jira] [Commented] (KAFKA-2231) Deleting a topic fails

[ https://issues.apache.org/jira/browse/KAFKA-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577095#comment-14577095 ] Bogdan Popa commented on KAFKA-2231: I'm having the same situation. It's a staging ma