[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577881#comment-14577881 ]
Jun Rao commented on KAFKA-1690: -------------------------------- [~sriharsha], thanks for the latest patch. Haven't looked at it in details. A couple of comments. 1. Could you rebase now that KAFKA-1928 is done? 2. We need to think a bit more about supporting the zero-copy transfer on the consumer. Currently, the broker sends data to the consumer client using the socket.writeTo() api (in PartitionDataSend, TopicDataSend, and FetchResponseSend). We want to preserve this optimization for plain socket channels. Only for SSL channel, we will copy the bytes from the file channel into the application and then send it to the remote socket. One way is probably to have Channel implement GatheringByteChannel and ScatteringByteChannel. > new java producer needs ssl support as a client > ----------------------------------------------- > > Key: KAFKA-1690 > URL: https://issues.apache.org/jira/browse/KAFKA-1690 > Project: Kafka > Issue Type: Sub-task > Reporter: Joe Stein > Assignee: Sriharsha Chintalapani > Fix For: 0.8.3 > > Attachments: KAFKA-1690.patch, KAFKA-1690.patch, > KAFKA-1690_2015-05-10_23:20:30.patch, KAFKA-1690_2015-05-10_23:31:42.patch, > KAFKA-1690_2015-05-11_16:09:36.patch, KAFKA-1690_2015-05-12_16:20:08.patch, > KAFKA-1690_2015-05-15_07:18:21.patch, KAFKA-1690_2015-05-20_14:54:35.patch, > KAFKA-1690_2015-05-21_10:37:08.patch, KAFKA-1690_2015-06-03_18:52:29.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)