Re: KAFKA-1977

2015-05-09 Thread Joe Stein
Hey Will, I took a quick look at your patch & JIRA. For patches could you please use https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review . I think changing the behavior of the scala high level consumer will be confusing for folks. If this is something we want todo then it

KAFKA-1977

2015-05-09 Thread Will Funnell
Hey, Still waiting for some feedback on the patch for a while now, please can you take a look. Many thanks, Will.

[jira] [Commented] (KAFKA-2182) zkClient dies if there is any exception while reconnecting

2015-05-09 Thread JIRA
[ https://issues.apache.org/jira/browse/KAFKA-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536286#comment-14536286 ] Igor Maravić commented on KAFKA-2182: - This is continuation of discussion from KAFKA-2

[jira] [Created] (KAFKA-2182) zkClient dies if there is any exception while reconnecting

2015-05-09 Thread JIRA
Igor Maravić created KAFKA-2182: --- Summary: zkClient dies if there is any exception while reconnecting Key: KAFKA-2182 URL: https://issues.apache.org/jira/browse/KAFKA-2182 Project: Kafka Issue

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-09 Thread JIRA
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536281#comment-14536281 ] Igor Maravić commented on KAFKA-2169: - [~parth.brahmbhatt] If you look at the stack tr

Re: Review Request 30801: Patch for KAFKA-1758

2015-05-09 Thread Manikumar Reddy O
> On April 26, 2015, 6:53 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/log/LogManager.scala, line 133 > > > > > > Is there a reason we are limiting this to only NumberFormatException? > > Seems like a fix

[jira] [Updated] (KAFKA-1758) corrupt recovery file prevents startup

2015-05-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1758: --- Attachment: KAFKA-1758_2015-05-09_12:29:20.patch > corrupt recovery file prevents startup > --

[jira] [Commented] (KAFKA-1758) corrupt recovery file prevents startup

2015-05-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536267#comment-14536267 ] Manikumar Reddy commented on KAFKA-1758: Updated reviewboard https://reviews.apach

Re: Review Request 30801: Patch for KAFKA-1758

2015-05-09 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30801/ --- (Updated May 9, 2015, 7:02 a.m.) Review request for kafka. Bugs: KAFKA-1758