[jira] [Commented] (KAFKA-2132) Move Log4J appender to clients module

2015-05-08 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536107#comment-14536107 ] Ashish K Singh commented on KAFKA-2132: --- [~jkreps] and [~charmalloc], pinging you gu

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-05-08 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535956#comment-14535956 ] Ashish K Singh commented on KAFKA-1367: --- [~nehanarkhede]/ [~jjkoshy] I have put toge

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

2015-05-08 Thread Tom Dyas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535675#comment-14535675 ] Tom Dyas commented on KAFKA-873: If there is some doubt as to whether Kafka should be switc

[jira] [Comment Edited] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

2015-05-08 Thread Tom Dyas (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535675#comment-14535675 ] Tom Dyas edited comment on KAFKA-873 at 5/8/15 10:02 PM: - If there

[jira] [Commented] (KAFKA-2179) no graceful nor fast way to shutdown every broker without killing them

2015-05-08 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535652#comment-14535652 ] Ashish K Singh commented on KAFKA-2179: --- Hi Joe, do you think in the scenario you me

Re: Review Request 33088: add heartbeat to coordinator

2015-05-08 Thread Onur Karaman
> On April 28, 2015, 12:13 a.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala, line 261 > > > > > > Function name "scheduleHeartbeatExpiration" is a bit misleading, it is >

Re: Review Request 33065: Patch for KAFKA-1928

2015-05-08 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33065/#review82347 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

Re: Review Request 33088: add heartbeat to coordinator

2015-05-08 Thread Onur Karaman
> On May 7, 2015, 10:07 p.m., Guozhang Wang wrote: > > I think we can check this in if you agree with the following minor comments > > (I can do them while committing), and then move on to the rebalance logic / > > leftover works. > > Guozhang Wang wrote: > Also could you rebase since curr

[jira] [Commented] (KAFKA-1334) Add failure detection capability to the coordinator / consumer

2015-05-08 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535105#comment-14535105 ] Onur Karaman commented on KAFKA-1334: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1334) Add failure detection capability to the coordinator / consumer

2015-05-08 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Onur Karaman updated KAFKA-1334: Attachment: KAFKA-1334_2015-05-08_10:55:02.patch > Add failure detection capability to the coordinat

Re: Review Request 33088: add heartbeat to coordinator

2015-05-08 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33088/ --- (Updated May 8, 2015, 5:55 p.m.) Review request for kafka. Bugs: KAFKA-1334

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-08 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534802#comment-14534802 ] Parth Brahmbhatt commented on KAFKA-2169: - Here is the commit that added that meth

[jira] [Commented] (KAFKA-2169) Upgrade to zkclient-0.5

2015-05-08 Thread JIRA
[ https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534743#comment-14534743 ] Igor Maravić commented on KAFKA-2169: - We, Spotify, have just been hit by a BUG that's