[jira] [Commented] (KAFKA-1293) Mirror maker housecleaning

[ https://issues.apache.org/jira/browse/KAFKA-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486630#comment-14486630 ] Matt Warhaftig commented on KAFKA-1293: --- [~jkreps] I broke out command line argument

[jira] [Created] (KAFKA-2111) Command Line Standardization - Add Help Arguments & List Required Fields

Matt Warhaftig created KAFKA-2111: - Summary: Command Line Standardization - Add Help Arguments & List Required Fields Key: KAFKA-2111 URL: https://issues.apache.org/jira/browse/KAFKA-2111 Project: Kaf

Re: [VOTE] KIP-13 Quotas

+1 Nice work. One minor nit pick: all the protocol field names are snake_case but the proposed addition is camelCase. Let's stick with the current convention. -Jay On Tue, Apr 7, 2015 at 10:47 PM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > Please vote. > https://cwiki.apache.or

Build failed in Jenkins: Kafka-trunk #457

See Changes: [junrao] kafka-2090; Remove duplicate check to metadataFetchInProgress; patched by Tim Brook; reviewed by Ewen Cheslack-PostavaJun Rao -- [...truncated 2141 lines...] kafka.log.FileMessa

[jira] [Updated] (KAFKA-2087) TopicConfigManager javadoc references incorrect paths

[ https://issues.apache.org/jira/browse/KAFKA-2087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2087: --- Priority: Trivial (was: Minor) > TopicConfigManager javadoc references incorrect paths >

[jira] [Updated] (KAFKA-2087) TopicConfigManager javadoc references incorrect paths

[ https://issues.apache.org/jira/browse/KAFKA-2087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2087: --- Status: Patch Available (was: Open) > TopicConfigManager javadoc references incorrect paths > ---

[jira] [Commented] (KAFKA-2077) Add ability to specify a TopicPicker class for KafkaLog4jApender

[ https://issues.apache.org/jira/browse/KAFKA-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486575#comment-14486575 ] Jun Rao commented on KAFKA-2077: Also, does this patch cover KAFKA-2041 as well? > Add ab

[jira] [Resolved] (KAFKA-2090) Remove duplicate check to metadataFetchInProgress

[ https://issues.apache.org/jira/browse/KAFKA-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-2090. Resolution: Fixed Fix Version/s: 0.8.3 Assignee: Tim Brooks Thanks for the patch. +1 and com

[jira] [Commented] (KAFKA-2077) Add ability to specify a TopicPicker class for KafkaLog4jApender

[ https://issues.apache.org/jira/browse/KAFKA-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486562#comment-14486562 ] Jun Rao commented on KAFKA-2077: Thanks for the patch. The customizable key class seems us

[jira] [Commented] (KAFKA-2082) Kafka Replication ends up in a bad state

[ https://issues.apache.org/jira/browse/KAFKA-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486536#comment-14486536 ] Jun Rao commented on KAFKA-2082: My understanding is that if a broker is isolated from ZK,

Re: [VOTE] KIP-13 Quotas

Non-binding +1 :) This is a super important feature, so thanks for driving this, Aditya. One small thing, maybe the KIP should clarify that the quota exception will not be exposed to clients. I was a bit confused at first. Gwen On Wed, Apr 8, 2015 at 6:17 PM, Aditya Auradkar < aaurad...@linkedin

Build failed in Jenkins: Kafka-trunk #456

See Changes: [junrao] kafka-2096; Enable keepalive socket option for broker to prevent socket leak; patched by Allen Wang; reviewed by Jun Rao -- [...truncated 1249 lines...] kafka.consumer.TopicFilt

RE: [VOTE] KIP-13 Quotas

Thanks! I've clarified the request protocol change on the KIP. Aditya From: Joel Koshy [jjkosh...@gmail.com] Sent: Wednesday, April 08, 2015 5:49 PM To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-13 Quotas Agreed on that - it is understood from the text

[jira] [Commented] (KAFKA-2091) Expose a Partitioner interface in the new producer

[ https://issues.apache.org/jira/browse/KAFKA-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486492#comment-14486492 ] Jun Rao commented on KAFKA-2091: This introduces a new interface in the producer client. S

[jira] [Updated] (KAFKA-2029) Improving controlled shutdown for rolling updates

[ https://issues.apache.org/jira/browse/KAFKA-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2029: --- Status: Patch Available (was: Open) > Improving controlled shutdown for rolling updates > ---

[jira] [Commented] (KAFKA-1554) Corrupt index found on clean startup

[ https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486465#comment-14486465 ] Jun Rao commented on KAFKA-1554: Yes, I am not sure if auto fixing the index is better. Pe

Jenkins build is back to normal : KafkaPreCommit #68

See

Re: [VOTE] KIP-13 Quotas

Agreed on that - it is understood from the text of the KIP "Clients that send current version (0) of those requests will not receive the quota status flag in the response" => you have to send version (1) to get the new repsonse, but it should probably be clarified on the page. I'm +1 as well on th

[jira] [Commented] (KAFKA-2078) Getting Selector [WARN] Error in I/O with host java.io.EOFException

[ https://issues.apache.org/jira/browse/KAFKA-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486433#comment-14486433 ] Jun Rao commented on KAFKA-2078: That's a good point. Do you see any OOME in either the br

Re: [VOTE] KIP-13 Quotas

Aditya, To evolve the response protocol for produce/fetch response, we need to have new versions of the requests as well. Version 1 of the requests will have the same protocol as that of version 0, and will get the new response. The rest of the stuff looks good to me. Thanks, Jun On Tue, Apr 7,

[jira] [Updated] (KAFKA-2096) Enable keepalive socket option for broker to prevent socket leak

[ https://issues.apache.org/jira/browse/KAFKA-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2096: --- Resolution: Fixed Fix Version/s: 0.8.3 Assignee: Allen Wang (was: Jun Rao) Status:

[jira] [Commented] (KAFKA-2078) Getting Selector [WARN] Error in I/O with host java.io.EOFException

[ https://issues.apache.org/jira/browse/KAFKA-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486375#comment-14486375 ] Annie Fassa Golden (afassa) commented on KAFKA-2078: FYI, I was havin

[jira] [Commented] (KAFKA-2076) Add an API to new consumer to allow user get high watermark of partitions.

[ https://issues.apache.org/jira/browse/KAFKA-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486359#comment-14486359 ] Jiangjie Qin commented on KAFKA-2076: - Hi [~jkreps], Actually thought about this again

[jira] [Commented] (KAFKA-2096) Enable keepalive socket option for broker to prevent socket leak

[ https://issues.apache.org/jira/browse/KAFKA-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486355#comment-14486355 ] Allen Wang commented on KAFKA-2096: --- To verify the fix, the socket connections on broker

[jira] [Updated] (KAFKA-2096) Enable keepalive socket option for broker to prevent socket leak

[ https://issues.apache.org/jira/browse/KAFKA-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wang updated KAFKA-2096: -- Reviewer: Jun Rao Status: Patch Available (was: Open) > Enable keepalive socket option for broker

[jira] [Updated] (KAFKA-2096) Enable keepalive socket option for broker to prevent socket leak

[ https://issues.apache.org/jira/browse/KAFKA-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wang updated KAFKA-2096: -- Attachment: patch.diff Patch for the fix > Enable keepalive socket option for broker to prevent socket

[jira] [Commented] (KAFKA-2108) Node deleted all data and re-sync from replicas after attempted upgrade from 0.8.1.1 to 0.8.2.0

[ https://issues.apache.org/jira/browse/KAFKA-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486345#comment-14486345 ] Jiangjie Qin commented on KAFKA-2108: - [~slimunholyone] sent me some logs offline. Tha

[jira] [Commented] (KAFKA-2096) Enable keepalive socket option for broker to prevent socket leak

[ https://issues.apache.org/jira/browse/KAFKA-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486297#comment-14486297 ] Jun Rao commented on KAFKA-2096: We probably don't need to make this configurable. The def

[jira] [Commented] (KAFKA-1669) Default rebalance retries and backoff should be higher

[ https://issues.apache.org/jira/browse/KAFKA-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486265#comment-14486265 ] Jun Rao commented on KAFKA-1669: It's possible. However, since we are developing the new c

Build failed in Jenkins: KafkaPreCommit #67

See Changes: [junrao] kafka-1989; New purgatory design; patched by Yasuhiro Matsuda; reviewed by Guozhang Wang and Jun Rao -- [...truncated 1249 lines...] kafka.log.OffsetIndexTest > lookupExtremeC

[jira] [Commented] (KAFKA-1669) Default rebalance retries and backoff should be higher

[ https://issues.apache.org/jira/browse/KAFKA-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486246#comment-14486246 ] Clark Haskins commented on KAFKA-1669: -- What about having some type of exponential ba

[jira] [Commented] (KAFKA-1669) Default rebalance retries and backoff should be higher

[ https://issues.apache.org/jira/browse/KAFKA-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486238#comment-14486238 ] Jun Rao commented on KAFKA-1669: If you start more than 1 consumer concurrently, there cou

[jira] [Commented] (KAFKA-1989) New purgatory design

[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486235#comment-14486235 ] Guozhang Wang commented on KAFKA-1989: -- This is great, thanks [~yasuhiro.matsuda]! >

[jira] [Commented] (KAFKA-1669) Default rebalance retries and backoff should be higher

[ https://issues.apache.org/jira/browse/KAFKA-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486223#comment-14486223 ] Clark Haskins commented on KAFKA-1669: -- [~junrao] We are seeing that we have to chang

[jira] [Commented] (KAFKA-1669) Default rebalance retries and backoff should be higher

[ https://issues.apache.org/jira/browse/KAFKA-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486210#comment-14486210 ] Jun Rao commented on KAFKA-1669: [~clarkhaskins], wouldn't it be better to change the conf

Jenkins build is back to normal : Kafka-trunk #454

See

[jira] [Reopened] (KAFKA-1669) Default rebalance retries and backoff should be higher

[ https://issues.apache.org/jira/browse/KAFKA-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clark Haskins reopened KAFKA-1669: -- > Default rebalance retries and backoff should be higher > -

[jira] [Updated] (KAFKA-1989) New purgatory design

[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1989: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for t

[jira] [Commented] (KAFKA-1669) Default rebalance retries and backoff should be higher

[ https://issues.apache.org/jira/browse/KAFKA-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486197#comment-14486197 ] Clark Haskins commented on KAFKA-1669: -- I think this should still be fixed. > Defau

Re: Review Request 31606: Patch for KAFKA-1416

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31606/#review79438 --- core/src/test/scala/unit/kafka/integration/FetcherTest.scala

Re: Review Request 31606: Patch for KAFKA-1416

> On March 25, 2015, 9:51 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/utils/TestUtils.scala, lines 761-773 > > > > > > Compression code is no longer used anymore, which seems not correct? > > Flutra

[jira] [Updated] (KAFKA-2109) Support retries in KafkaLog4jAppender

[ https://issues.apache.org/jira/browse/KAFKA-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2109: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for t

[jira] [Commented] (KAFKA-1989) New purgatory design

[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486099#comment-14486099 ] Yasuhiro Matsuda commented on KAFKA-1989: - Updated reviewboard https://reviews.apa

[jira] [Updated] (KAFKA-1989) New purgatory design

[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-1989: Attachment: KAFKA-1989_2015-04-08_14:29:51.patch > New purgatory design > --

Re: Review Request 31568: Patch for KAFKA-1989

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31568/ --- (Updated April 8, 2015, 9:30 p.m.) Review request for kafka. Bugs: KAFKA-1989

[jira] [Commented] (KAFKA-1123) Broker IPv6 addresses parsed incorrectly

[ https://issues.apache.org/jira/browse/KAFKA-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486093#comment-14486093 ] Jun Rao commented on KAFKA-1123: The new producer needs to use bootstrap.servers, instead

[jira] [Commented] (KAFKA-1993) Enable topic deletion as default

[ https://issues.apache.org/jira/browse/KAFKA-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486073#comment-14486073 ] Jun Rao commented on KAFKA-1993: [~onurkaraman], yes, we can remove the config for contro

[jira] [Resolved] (KAFKA-2110) Doc: Clarify that max number of consumer instances is per consumer group

[ https://issues.apache.org/jira/browse/KAFKA-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-2110. Resolution: Fixed Fix Version/s: 0.8.3 Assignee: Peter Vandenabeele Thanks for reporting thi

Build failed in Jenkins: Kafka-trunk #453

See Changes: [junrao] kafka-2104; testDuplicateListeners() has a typo; patched by Gwen Shapira; reviewed by Sriharsha Chintalapani, Onur Karaman and Jun Rao -- [...truncated 614 lines...] kafka.log.L

[jira] [Resolved] (KAFKA-766) Isr shrink/expand check is fragile

[ https://issues.apache.org/jira/browse/KAFKA-766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Auradkar resolved KAFKA-766. --- Resolution: Fixed Fixed in KAFKA-1546 > Isr shrink/expand check is fragile > -

Jenkins build is back to normal : KafkaPreCommit #65

See

[jira] [Commented] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486022#comment-14486022 ] Jiangjie Qin commented on KAFKA-1660: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1660: Attachment: KAFKA-1660_2015-04-08_14:01:12.patch > Ability to call close() with a timeout on the Jav

[jira] [Commented] (KAFKA-1993) Enable topic deletion as default

[ https://issues.apache.org/jira/browse/KAFKA-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486028#comment-14486028 ] Onur Karaman commented on KAFKA-1993: - One thing to be careful about is rolling out th

Re: Review Request 31850: Patch for KAFKA-1660

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31850/ --- (Updated April 8, 2015, 9:01 p.m.) Review request for kafka. Bugs: KAFKA-1660

[jira] [Updated] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1809: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Resolving th

[jira] [Updated] (KAFKA-2110) Doc: Clarify that max number of consumer instances is per consumer group

[ https://issues.apache.org/jira/browse/KAFKA-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Vandenabeele updated KAFKA-2110: -- Issue Type: Improvement (was: Bug) > Doc: Clarify that max number of consumer instances

[jira] [Updated] (KAFKA-1989) New purgatory design

[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-1989: Attachment: KAFKA-1989_2015-04-08_13:27:59.patch > New purgatory design > --

[jira] [Commented] (KAFKA-1989) New purgatory design

[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485950#comment-14485950 ] Yasuhiro Matsuda commented on KAFKA-1989: - Updated reviewboard https://reviews.apa

[jira] [Updated] (KAFKA-2104) testDuplicateListeners() has a typo

[ https://issues.apache.org/jira/browse/KAFKA-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2104: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for t

Re: Review Request 31568: Patch for KAFKA-1989

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31568/ --- (Updated April 8, 2015, 8:28 p.m.) Review request for kafka. Bugs: KAFKA-1989

[jira] [Created] (KAFKA-2110) Doc: Clarify that max number of consumer instances is per consumer group

Peter Vandenabeele created KAFKA-2110: - Summary: Doc: Clarify that max number of consumer instances is per consumer group Key: KAFKA-2110 URL: https://issues.apache.org/jira/browse/KAFKA-2110 Proj

Re: Review Request 31568: Patch for KAFKA-1989

> On April 8, 2015, 6:44 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/utils/timer/TimingWheel.scala, line 96 > > > > > > Does this need to be volatile since all accesses to it are synchronized? > > Yasuhiro Matsu

Re: Is there a complete Kafka 0.8.* replication design document

#2. /brokers/topics/[topic] stores the replica assignment for all partitions in the topic. /brokers/topics/[topic]/partitions/[partition_id]/state stores the leader/isr per partition. We did it this way since the leader/isr need to be updated on a per partition basis. #4. Yes, what you observed is

Re: Review Request 31568: Patch for KAFKA-1989

> On April 8, 2015, 7:15 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/DelayedOperation.scala, lines 123-126 > > > > > > We do not need to address it in this patch but may think about it > > moving f

[jira] [Updated] (KAFKA-2109) Support retries in KafkaLog4jAppender

[ https://issues.apache.org/jira/browse/KAFKA-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Beech updated KAFKA-2109: -- Status: Patch Available (was: Open) > Support retries in KafkaLog4jAppender > -

Re: Review Request 31850: Patch for KAFKA-1660

> On April 8, 2015, 6:36 p.m., Joel Koshy wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java, > > line 153 > > > > > > Thanks for catching this issue, but can you expla

[jira] [Updated] (KAFKA-2109) Support retries in KafkaLog4jAppender

[ https://issues.apache.org/jira/browse/KAFKA-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Beech updated KAFKA-2109: -- Attachment: KAFKA-2109.patch > Support retries in KafkaLog4jAppender > -

Re: Review Request 31568: Patch for KAFKA-1989

> On April 8, 2015, 6:44 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/utils/timer/TimingWheel.scala, line 59 > > > > > > Each bucket here needs to cover a window of size 3, right? Sorry, I messed up the example

Re: Review Request 31568: Patch for KAFKA-1989

> On April 6, 2015, 10:35 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/DelayedOperation.scala, lines 104-105 > > > > > > We probably should call forceComplete() first and only if it returns > > true, run

[jira] [Created] (KAFKA-2109) Support retries in KafkaLog4jAppender

Dave Beech created KAFKA-2109: - Summary: Support retries in KafkaLog4jAppender Key: KAFKA-2109 URL: https://issues.apache.org/jira/browse/KAFKA-2109 Project: Kafka Issue Type: Improvement

Re: Review Request 31568: Patch for KAFKA-1989

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31568/#review79408 --- Ship it! Looks great to me. Just a minor comment below. core/src/

Re: Review Request 32953: Patch for KAFKA-2104

> On April 8, 2015, 4:51 a.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala, line 137 > > > > > > Do you know why the test passes before? ConfigDef currently seems to > > ignore undef

[jira] [Commented] (KAFKA-2104) testDuplicateListeners() has a typo

[ https://issues.apache.org/jira/browse/KAFKA-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485830#comment-14485830 ] Gwen Shapira commented on KAFKA-2104: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-2104) testDuplicateListeners() has a typo

[ https://issues.apache.org/jira/browse/KAFKA-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2104: Attachment: KAFKA-2104_2015-04-08_12:08:40.patch > testDuplicateListeners() has a typo > -

Re: Review Request 32953: Patch for KAFKA-2104

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32953/ --- (Updated April 8, 2015, 7:08 p.m.) Review request for kafka. Bugs: KAFKA-2104

Re: Review Request 32953: Patch for KAFKA-2104

> On April 8, 2015, 4:51 a.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala, line 137 > > > > > > Do you know why the test passes before? ConfigDef currently seems to > > ignore undef

Re: Review Request 32953: Patch for KAFKA-2104

> On April 8, 2015, 4:51 a.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala, line 137 > > > > > > Do you know why the test passes before? ConfigDef currently seems to > > ignore undef

Re: Review Request 31568: Patch for KAFKA-1989

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31568/#review79269 --- Thanks for the latest patch. Looks good. Just a few more minor comme

[jira] [Commented] (KAFKA-1123) Broker IPv6 addresses parsed incorrectly

[ https://issues.apache.org/jira/browse/KAFKA-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485767#comment-14485767 ] Mingtao Zhang commented on KAFKA-1123: -- Curious anyone tested in Java, i.e. new Produ

Re: Review Request 31850: Patch for KAFKA-1660

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31850/#review79379 --- clients/src/main/java/org/apache/kafka/clients/producer/KafkaProduc

[jira] [Created] (KAFKA-2108) Node deleted all data and re-sync from replicas after attempted upgrade from 0.8.1.1 to 0.8.2.0

Thunder Stumpges created KAFKA-2108: --- Summary: Node deleted all data and re-sync from replicas after attempted upgrade from 0.8.1.1 to 0.8.2.0 Key: KAFKA-2108 URL: https://issues.apache.org/jira/browse/KAFKA-210

RE: [KIP-DISCUSSION] KIP-13 Quotas

Thanks for the detailed review. I've addressed your comments. For rejected alternatives, we've rejected per-partition distribution because we choose client based quotas where there is no notion of partitions. I've explained in a bit more detail in that section. Aditya _

Re: jira backlogs

> > We can do both of course, but I think apache infra already has > what is needed for this. Yes, if Apache INFRA has this, great. I would pick something that is a *push* mechanism and leave the *pull* as an option for proactive folks to refer to. Honestly, today you can go and save the JIRA que

[jira] [Commented] (KAFKA-1545) java.net.InetAddress.getLocalHost in KafkaHealthcheck.register may fail on some irregular hostnames

[ https://issues.apache.org/jira/browse/KAFKA-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485615#comment-14485615 ] Guozhang Wang commented on KAFKA-1545: -- Reassigned to [~rekhajoshm] > java.net.InetA

[jira] [Updated] (KAFKA-1545) java.net.InetAddress.getLocalHost in KafkaHealthcheck.register may fail on some irregular hostnames

[ https://issues.apache.org/jira/browse/KAFKA-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1545: - Assignee: Rekha Joshi (was: Guozhang Wang) > java.net.InetAddress.getLocalHost in KafkaHealthchec

Re: jira backlogs

The weekly email sounds good, but I would much rather if that were integrated into the wiki/jira system than run a custom script on non-apache infra. We did something similar during 0.8 replication development where we embedded JQL links in the wiki and had a nice dashboard view of jiras on a wiki

[jira] [Commented] (KAFKA-1737) Document required ZkSerializer for ZkClient used with AdminUtils

[ https://issues.apache.org/jira/browse/KAFKA-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485574#comment-14485574 ] Vivek Madani commented on KAFKA-1737: - My turn to be sorry for being late on this. I

Re: jira backlogs

One more thing: I currently can't assign myself as a reviewer. Do you need to add me to a new JIRA group for that? Or maybe give this capability to all contributors? On Wed, Apr 8, 2015 at 9:38 AM, Gwen Shapira wrote: > Thanks Neha :) > I'm glad to hear those reviews are useful. > > I created KA

Re: jira backlogs

Thanks Neha :) I'm glad to hear those reviews are useful. I created KAFKA-2107 to track the new email script. I agree it will be helpful and I'm sure someone will pick it up soon :) Gwen On Wed, Apr 8, 2015 at 9:07 AM, Neha Narkhede wrote: > To clarify, reviewers don't have to be committers.

[jira] [Created] (KAFKA-2107) Script to generate waiting-for-review report

Gwen Shapira created KAFKA-2107: --- Summary: Script to generate waiting-for-review report Key: KAFKA-2107 URL: https://issues.apache.org/jira/browse/KAFKA-2107 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485494#comment-14485494 ] Tim Brooks commented on KAFKA-2102: --- Thanks for the feedback. Unless I misunderstand yo

Re: jira backlogs

To clarify, reviewers don't have to be committers. If as a non-committer reviewer, you feel that the patch is ready for commit, feel free to ping/tag one of the committers. This

Re: Review Request 32953: Patch for KAFKA-2104

> On April 8, 2015, 4:51 a.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala, line 137 > > > > > > Do you know why the test passes before? ConfigDef currently seems to > > ignore undef

Re: jira backlogs

Hi Jun, Do reviewers have to be committers? I'll be happy to review patches in areas that I'm familiar with, if this makes life easier for committers and helps us get improvements in faster. Gwen On Tue, Apr 7, 2015 at 11:10 PM, Jun Rao wrote: > Hi, everyone, > > Currently, we have accumulated

Re: [KIP-DISCUSSION] KIP-13 Quotas

Thanks for updating the wiki. Looks great overall. Just a couple more comments: Client status code: - v0 requests -> current version (0) of those requests. - Fetch response has a throttled flag instead of throttle time - I think you intended the latter. - Can you make it clear that the quota st

RE: Is there a complete Kafka 0.8.* replication design document

Thanks for your response and I have some other questions as below in green -Original Message- From: Jun Rao [mailto:j...@confluent.io] Sent: April 08, 2015 5:04 To: us...@kafka.apache.org Cc: dev@kafka.apache.org Subject: Re: Is there a complete Kafka 0.8.* replication design document Ye

[jira] [Commented] (KAFKA-2106) Partition balance tool between borkers

[ https://issues.apache.org/jira/browse/KAFKA-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484948#comment-14484948 ] chenshangan commented on KAFKA-2106: Topics in the cluster can be divided into two cat

[jira] [Commented] (KAFKA-2091) Expose a Partitioner interface in the new producer

[ https://issues.apache.org/jira/browse/KAFKA-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484926#comment-14484926 ] Gianmarco De Francisci Morales commented on KAFKA-2091: --- Looks good

Re: Review Request 32953: Patch for KAFKA-2104

> On April 8, 2015, 4:51 a.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala, line 137 > > > > > > Do you know why the test passes before? ConfigDef currently seems to > > ignore undef

  1   2   >