Thanks Neha :) I'm glad to hear those reviews are useful. I created KAFKA-2107 to track the new email script. I agree it will be helpful and I'm sure someone will pick it up soon :)
Gwen On Wed, Apr 8, 2015 at 9:07 AM, Neha Narkhede <n...@confluent.io> wrote: > To clarify, reviewers don't have to be committers. If as a non-committer > reviewer, you feel that the patch is ready for commit, feel free to > ping/tag one of the committers. This > < > https://issues.apache.org/jira/browse/KAFKA-1961?focusedCommentId=14389409&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14389409 > > > works :-) > > The other suggestion I'd like to make involves writing a simple JIRA script > (whaat?). Currently the weekly email we get from JIRA just tells you what > JIRAs have patches. But it doesn't tell you which committers/reviewers have > signed up to review those patches. The 2nd piece of information can be > really helpful. Here's why- > > I'm sure everyone wants to know which patches are open and since our > community is so active, that is often a long list even if each JIRA is > actively being reviewed. As a busy committer, I think if I knew the list of > JIRAs I've signed up to review and commit, I would really appreciate the > weekly reminder. It allows me to either get to it or give it up to someone > else. > > If someone had some time, they can look at my patch-review script that uses > some of JIRA's python APIs and write a little script that does this. At > Confluent, we are happy to host that script on some EC2 machine. > > Thanks, > Neha > > On Wed, Apr 8, 2015 at 8:41 AM, Gwen Shapira <gshap...@cloudera.com> > wrote: > > > Hi Jun, > > > > Do reviewers have to be committers? > > I'll be happy to review patches in areas that I'm familiar with, if this > > makes life easier for committers and helps us get improvements in faster. > > > > Gwen > > > > On Tue, Apr 7, 2015 at 11:10 PM, Jun Rao <j...@confluent.io> wrote: > > > > > Hi, everyone, > > > > > > Currently, we have accumulated quite a few jira backlogs. We can > probably > > > brainstorm a bit what we can do to improve this. A few thoughts. > > > > > > 1. There are quite a few jiras marked with "patch available", but with > > > unaddressed review comments. I made a pass and moved them back to "in > > > progress" (just click the "Resume Progress") button. Now, there are > about > > > 100 jiras with valid patches. As people review the patches, it may be > > > useful to keep the status updated as well (thanks Neha for the > > suggestion). > > > > > > 2. Some of the jiras have trivial patches. Perhaps we can just assign > > them > > > with "trivial" priority. This way, a committer with only limited amount > > of > > > time may be able to help out. > > > > > > 3. Some of the jiras have been tagged with reviewers. It would be good > if > > > those reviewers can spend time finishing the reviews. If they can't do > > the > > > review soon, they can unset the reviewer field so that someone else can > > > pick up the review. > > > > > > 4. Perhaps we can also spend a bit of time to triage at least the > active > > > jiras during our weekly hangout. > > > > > > Anything else that we can do? > > > > > > Thanks, > > > > > > Jun > > > > > > > > > -- > Thanks, > Neha >
