Re: [Discussion] Using Client Requests and Responses in Server

2015-03-22 Thread Jay Kreps
Ack, yeah, forgot about that. It's not just a difference of wrappers. The server side actually sends the bytes lazily using FileChannel.transferTo. We need to make it possible to carry over that optimization. In some sense what we want to be able to do is set a value to a Send instead of a ByteBuf

[jira] [Assigned] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

2015-03-22 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke reassigned KAFKA-873: - Assignee: Grant Henke > Consider replacing zkclient with curator (with zkclient-bridge) >

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

2015-03-22 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375366#comment-14375366 ] Grant Henke commented on KAFKA-873: --- Is changing over to Curator something that still sho

Re: [Discussion] Using Client Requests and Responses in Server

2015-03-22 Thread Gwen Shapira
In case anyone is still following this thread, I need a bit of help :) The old FetchResponse.PartitionData included a MessageSet object. The new FetchResponse.PartitionData includes a ByteBuffer. However, when we read from logs, we return a MessageSet, and as far as I can see, these can't be conv

[jira] [Updated] (KAFKA-2039) Update Scala to 2.10.5 and 2.11.6

2015-03-22 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2039: --- Status: Patch Available (was: Open) I've attached a patch that updates Scala to 2.10.5 and 2.11.6. >

[jira] [Issue Comment Deleted] (KAFKA-2039) Update Scala to 2.10.5 and 2.11.6

2015-03-22 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2039: --- Comment: was deleted (was: Update Scala to 2.10.5 and 2.11.6.) > Update Scala to 2.10.5 and 2.11.6 >

[jira] [Updated] (KAFKA-2039) Update Scala to 2.10.5 and 2.11.6

2015-03-22 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2039: --- Attachment: kafka-2039.patch Update Scala to 2.10.5 and 2.11.6. > Update Scala to 2.10.5 and 2.11.6 >

[jira] [Created] (KAFKA-2039) Update Scala to 2.10.5 and 2.11.6

2015-03-22 Thread Ismael Juma (JIRA)
Ismael Juma created KAFKA-2039: -- Summary: Update Scala to 2.10.5 and 2.11.6 Key: KAFKA-2039 URL: https://issues.apache.org/jira/browse/KAFKA-2039 Project: Kafka Issue Type: Improvement Affec

Re: Review Request 32378: Patch for KAFKA-1293

2015-03-22 Thread Matt Warhaftig
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32378/ --- (Updated March 22, 2015, 8:33 p.m.) Review request for kafka. Bugs: KAFKA-129

[jira] [Commented] (KAFKA-1293) Mirror maker housecleaning

2015-03-22 Thread Matt Warhaftig (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375154#comment-14375154 ] Matt Warhaftig commented on KAFKA-1293: --- In addition to Mirror Maker other tools don

[jira] [Commented] (KAFKA-1293) Mirror maker housecleaning

2015-03-22 Thread Matt Warhaftig (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375146#comment-14375146 ] Matt Warhaftig commented on KAFKA-1293: --- Created reviewboard https://reviews.apache.

[jira] [Updated] (KAFKA-1293) Mirror maker housecleaning

2015-03-22 Thread Matt Warhaftig (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Warhaftig updated KAFKA-1293: -- Attachment: KAFKA-1293.patch > Mirror maker housecleaning > -- > >

Review Request 32378: Patch for KAFKA-1293

2015-03-22 Thread Matt Warhaftig
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32378/ --- Review request for kafka. Bugs: KAFKA-1293 https://issues.apache.org/jira/b

Re: Review Request 32376: Patch for KAFKA-2021

2015-03-22 Thread Andrii Biletskyi
> On March 22, 2015, 6:57 p.m., Gwen Shapira wrote: > > It looks like some tests are missing? like the uncleanLeaderElection ones? Those had been covered in the main test - testFromPropsToProps, already in the first version of the patch. - Andrii

Re: Review Request 32376: Patch for KAFKA-2021

2015-03-22 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32376/#review77356 --- It looks like some tests are missing? like the uncleanLeaderElection

[jira] [Updated] (KAFKA-2021) Consolidate test classes for KafkaConfig

2015-03-22 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2021: Status: Patch Available (was: Open) > Consolidate test classes for KafkaConfig > --

[jira] [Commented] (KAFKA-2021) Consolidate test classes for KafkaConfig

2015-03-22 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375085#comment-14375085 ] Andrii Biletskyi commented on KAFKA-2021: - Created reviewboard https://reviews.apa

[jira] [Updated] (KAFKA-2021) Consolidate test classes for KafkaConfig

2015-03-22 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-2021: Attachment: KAFKA-2021.patch > Consolidate test classes for KafkaConfig > --

Review Request 32376: Patch for KAFKA-2021

2015-03-22 Thread Andrii Biletskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32376/ --- Review request for kafka. Bugs: KAFKA-2021 https://issues.apache.org/jira/b

Re: C++ Client Library -- libkafka-asio

2015-03-22 Thread svante karlsson
Cool, Looks nice. I was looking for something similar a year ago. We also ended up rolling our own. https://github.com/bitbouncer/csi-kafka Have you got any performance figures? /svante 2015-03-22 14:29 GMT+01:00 Daniel Joos : > Hello there, > > I'm currently working on a C++ client library, i

C++ Client Library -- libkafka-asio

2015-03-22 Thread Daniel Joos
Hello there, I'm currently working on a C++ client library, implementing the Kafka protocol using Boost ASIO. You can find the source code and some examples on github: https://github.com/danieljoos/libkafka-asio I tried to add it to the "Clients" section of the Kafka wiki, but either I'm to blind