> On March 22, 2015, 6:57 p.m., Gwen Shapira wrote: > > It looks like some tests are missing? like the uncleanLeaderElection ones?
Those had been covered in the main test - testFromPropsToProps, already in the first version of the patch. - Andrii ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32376/#review77356 ----------------------------------------------------------- On March 22, 2015, 5:46 p.m., Andrii Biletskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32376/ > ----------------------------------------------------------- > > (Updated March 22, 2015, 5:46 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2021 > https://issues.apache.org/jira/browse/KAFKA-2021 > > > Repository: kafka > > > Description > ------- > > KAFKA-2021- consolidate test classes for KafkaConfig. Renamed related to > Kafka.scala, merged KafkaConfigTest and KafkaConfigConfigDefTest > > > Diffs > ----- > > core/src/test/scala/unit/kafka/KafkaConfigTest.scala > core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala > 191251d1340b5e5b2d649b37af3c6c1896d07e6e > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala > 7f47e6f9a74314ed9e9f19d0c97931f3f2e49259 > > Diff: https://reviews.apache.org/r/32376/diff/ > > > Testing > ------- > > > Thanks, > > Andrii Biletskyi > >
