Re: Review Request 31706: Patch for KAFKA-1997

> On March 6, 2015, 12:14 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/consumer/PartitionAssignor.scala, line 74 > > > > > > Why does this need to be a pool? i.e., rebalance is done while holding > > a lock.

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349930#comment-14349930 ] Jiangjie Qin commented on KAFKA-1997: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1997) Refactor Mirror Maker

[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1997: Attachment: KAFKA-1997_2015-03-05_20:14:58.patch > Refactor Mirror Maker > - > >

Re: Review Request 31706: Patch for KAFKA-1997

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31706/ --- (Updated March 6, 2015, 4:15 a.m.) Review request for kafka. Bugs: KAFKA-1997

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations

Thanks for the updated wiki. A few comments below: 1. Error description in response: I think if some errorCode could indicate several different error cases then we should really change it to multiple codes. In general the errorCode itself would be precise and sufficient for describing the server s

Re: Review Request 31706: Patch for KAFKA-1997

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31706/#review75409 --- Sorry this is not a thorough review but a first pass. I can dig deep

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31650/#review75406 --- clients/src/test/java/org/apache/kafka/clients/consumer/internals/C

[jira] [Comment Edited] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349621#comment-14349621 ] Honghai Chen edited comment on KAFKA-1646 at 3/5/15 11:35 PM: --

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31650/#review75419 --- Ship it! Ship It! - Jay Kreps On March 5, 2015, 10:57 p.m., Guoz

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31650/#review75411 --- clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349621#comment-14349621 ] Honghai Chen commented on KAFKA-1646: - Or do you prefer the second option: Add one mor

[jira] [Commented] (KAFKA-1910) Refactor KafkaConsumer

[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349574#comment-14349574 ] Guozhang Wang commented on KAFKA-1910: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31650/ --- (Updated March 5, 2015, 10:57 p.m.) Review request for kafka. Bugs: KAFKA-191

[jira] [Updated] (KAFKA-1910) Refactor KafkaConsumer

[ https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1910: - Attachment: KAFKA-1910_2015-03-05_14:55:33.patch > Refactor KafkaConsumer > --

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31650/ --- (Updated March 5, 2015, 10:55 p.m.) Review request for kafka. Bugs: KAFKA-191

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31650/#review75355 --- clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.

[jira] [Commented] (KAFKA-1995) JMS to Kafka: Inbuilt JMSAdaptor/JMSProxy/JMSBridge (Client can speak JMS but hit Kafka)

[ https://issues.apache.org/jira/browse/KAFKA-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349493#comment-14349493 ] Rekha Joshi commented on KAFKA-1995: Great.Thanks for your reply, [~ewencp] [~joestein

[jira] [Issue Comment Deleted] (KAFKA-1754) KOYA - Kafka on YARN

[ https://issues.apache.org/jira/browse/KAFKA-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Weise updated KAFKA-1754: Comment: was deleted (was: @raviprak Slider is the way forward. More info on this: http://hortonwor

[jira] [Commented] (KAFKA-1754) KOYA - Kafka on YARN

[ https://issues.apache.org/jira/browse/KAFKA-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349292#comment-14349292 ] Thomas Weise commented on KAFKA-1754: - @raviprak Slider is the way forward. More info

[jira] [Commented] (KAFKA-1754) KOYA - Kafka on YARN

[ https://issues.apache.org/jira/browse/KAFKA-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349296#comment-14349296 ] Thomas Weise commented on KAFKA-1754: - Slider is the way forward. More info on this:

Re: [DISCUSS] KIP-11- Authorization design for kafka security

Forgot to add links to wiki and jira. Link to wiki: https://cwiki.apache.org/confluence/display/KAFKA/KIP-11+-+Authorization+Interface Link to Jira: https://issues.apache.org/jira/browse/KAFKA-1688 Thanks Parth From: Parth Brahmbhatt mailto:pbrahmbh...@hortonworks.com>> Date: Thursday, March 5

[DISCUSS] KIP-11- Authorization design for kafka security

Hi, KIP-11 is open for discussion , I have updated the wiki with the design and open questions. Thanks Parth

Re: [DISCUSS] KIP-6 - New reassignment partition logic for re-balancing

I would not think that partitions moving would cause any orphaned messages like that. I would be more concerned about what happens when you change the default on a running cluster from one scheme to another. Would we want to support some kind of automated reassignment of existing partitions (person

RE: [DISCUSS] KIP-6 - New reassignment partition logic for re-balancing

Thanks for the writeup and RB Joe/Dmitry. Is it possible to describe the proposed partition reassignment algorithm in more detail on the KIP? In fact, it would be really easy to understand if we had some concrete examples comparing partition assignment with the old algorithm and the new. Adity

[jira] [Commented] (KAFKA-1998) Partitions Missing From MetadataResponse

[ https://issues.apache.org/jira/browse/KAFKA-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349128#comment-14349128 ] Guozhang Wang commented on KAFKA-1998: -- This is actually a non-issue, and I was mista

[jira] [Resolved] (KAFKA-1998) Partitions Missing From MetadataResponse

[ https://issues.apache.org/jira/browse/KAFKA-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-1998. -- Resolution: Not a Problem > Partitions Missing From MetadataResponse > -

[jira] [Commented] (KAFKA-1754) KOYA - Kafka on YARN

[ https://issues.apache.org/jira/browse/KAFKA-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349070#comment-14349070 ] Ravi Prakash commented on KAFKA-1754: - Thanks for the talk yesterday Thomas discussing

[jira] [Updated] (KAFKA-1884) Print metadata response errors

[ https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1884: --- Description: Print metadata response errors. producer logs: DEBUG [2015-01-20 12:46:13,406]

Re: [kafka-clients] Re: [VOTE] 0.8.2.1 Candidate 2

+1 unit tests and ran tests on 3-node cluster. On Wed, Mar 4, 2015, at 09:01 PM, Neha Narkhede wrote: > +1. Verified quick start, unit tests. > > On Tue, Mar 3, 2015 at 12:09 PM, Joe Stein wrote: > > > Ok, lets fix the transient test failure on trunk agreed not a blocker. > > > > +1 quick start

Re: Review Request 31627: Patch for KAFKA-1884

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31627/#review75343 --- Ship it! Ship It! - Sriharsha Chintalapani On March 2, 2015, 3:5

Build failed in Jenkins: Kafka-trunk #418

See Changes: [joe.stein] KAFKA-1845 KafkaConfig should use ConfigDef patch by Andrii Biletskyi reviewed by Gwen Shapira -- [...truncated 1158 lines...] kafka.consumer.TopicFilterTest > testBlacklists

[jira] [Commented] (KAFKA-1995) JMS to Kafka: Inbuilt JMSAdaptor/JMSProxy/JMSBridge (Client can speak JMS but hit Kafka)

[ https://issues.apache.org/jira/browse/KAFKA-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348951#comment-14348951 ] Joe Stein commented on KAFKA-1995: -- << This sounds like a good idea, but I think it doesn

[jira] [Updated] (KAFKA-1845) KafkaConfig should use ConfigDef

[ https://issues.apache.org/jira/browse/KAFKA-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1845: - Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch Andrii and the rev

[jira] [Comment Edited] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348401#comment-14348401 ] Honghai Chen edited comment on KAFKA-1646 at 3/5/15 10:44 AM: --

[jira] [Updated] (KAFKA-2005) Generate html report for system tests

[ https://issues.apache.org/jira/browse/KAFKA-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2005: -- Status: Patch Available (was: Open) > Generate html report for system tests > -

[jira] [Commented] (KAFKA-2005) Generate html report for system tests

[ https://issues.apache.org/jira/browse/KAFKA-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348474#comment-14348474 ] Ashish K Singh commented on KAFKA-2005: --- Created reviewboard https://reviews.apache.

[jira] [Updated] (KAFKA-2005) Generate html report for system tests

[ https://issues.apache.org/jira/browse/KAFKA-2005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2005: -- Attachment: KAFKA-2005.patch > Generate html report for system tests > -

Review Request 31765: Patch for KAFKA-2005

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31765/ --- Review request for kafka. Bugs: KAFKA-2005 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-2005) Generate html report for system tests

Ashish K Singh created KAFKA-2005: - Summary: Generate html report for system tests Key: KAFKA-2005 URL: https://issues.apache.org/jira/browse/KAFKA-2005 Project: Kafka Issue Type: Improvement

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348401#comment-14348401 ] Honghai Chen commented on KAFKA-1646: - Actually we want to add one more column to file

[jira] [Commented] (KAFKA-1995) JMS to Kafka: Inbuilt JMSAdaptor/JMSProxy/JMSBridge (Client can speak JMS but hit Kafka)

[ https://issues.apache.org/jira/browse/KAFKA-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348342#comment-14348342 ] Ewen Cheslack-Postava commented on KAFKA-1995: -- This sounds like a good idea,