+1 unit tests and ran tests on 3-node cluster.
On Wed, Mar 4, 2015, at 09:01 PM, Neha Narkhede wrote: > +1. Verified quick start, unit tests. > > On Tue, Mar 3, 2015 at 12:09 PM, Joe Stein <joe.st...@stealth.ly> wrote: > > > Ok, lets fix the transient test failure on trunk agreed not a blocker. > > > > +1 quick start passed, verified artifacts, updates in scala > > https://github.com/stealthly/scala-kafka/tree/0.8.2.1 and go > > https://github.com/stealthly/go_kafka_client/tree/0.8.2.1 look good > > > > ~ Joe Stein > > - - - - - - - - - - - - - - - - - > > > > http://www.stealth.ly > > - - - - - - - - - - - - - - - - - > > > > On Tue, Mar 3, 2015 at 12:30 PM, Jun Rao <j...@confluent.io> wrote: > > > > > Hi, Joe, > > > > > > Yes, that unit test does have transient failures from time to time. The > > > issue seems to be with the unit test itself and not the actual code. So, > > > this is not a blocker for 0.8.2.1 release. I think we can just fix it in > > > trunk. > > > > > > Thanks, > > > > > > Jun > > > > > > On Tue, Mar 3, 2015 at 9:08 AM, Joe Stein <joe.st...@stealth.ly> wrote: > > > > > >> Jun, I have most everything looks good except I keep getting test > > >> failures from wget > > >> > > https://people.apache.org/~junrao/kafka-0.8.2.1-candidate2/kafka-0.8.2.1-src.tgz > > >> && tar -xvf kafka-0.8.2.1-src.tgz && cd kafka-0.8.2.1-src && gradle && > > >> ./gradlew test > > >> > > >> kafka.api.ProducerFailureHandlingTest > > > >> testNotEnoughReplicasAfterBrokerShutdown FAILED > > >> org.scalatest.junit.JUnitTestFailedError: Expected > > >> NotEnoughReplicasException when producing to topic with fewer brokers > > than > > >> min.insync.replicas > > >> at > > >> > > org.scalatest.junit.AssertionsForJUnit$class.newAssertionFailedException(AssertionsForJUnit.scala:101) > > >> at > > >> > > org.scalatest.junit.JUnit3Suite.newAssertionFailedException(JUnit3Suite.scala:149) > > >> at org.scalatest.Assertions$class.fail(Assertions.scala:711) > > >> at org.scalatest.junit.JUnit3Suite.fail(JUnit3Suite.scala:149) > > >> at > > >> > > kafka.api.ProducerFailureHandlingTest.testNotEnoughReplicasAfterBrokerShutdown(ProducerFailureHandlingTest.scala:355) > > >> > > >> This happens to me all the time on a few different machines. > > >> > > >> ~ Joe Stein > > >> - - - - - - - - - - - - - - - - - > > >> > > >> http://www.stealth.ly > > >> - - - - - - - - - - - - - - - - - > > >> > > >> On Mon, Mar 2, 2015 at 7:36 PM, Jun Rao <j...@confluent.io> wrote: > > >> > > >>> +1 from me. Verified quickstart and unit tests. > > >>> > > >>> Thanks, > > >>> > > >>> Jun > > >>> > > >>> On Thu, Feb 26, 2015 at 2:59 PM, Jun Rao <j...@confluent.io> wrote: > > >>> > > >>>> This is the second candidate for release of Apache Kafka 0.8.2.1. This > > >>>> fixes 4 critical issue in 0.8.2.0. > > >>>> > > >>>> Release Notes for the 0.8.2.1 release > > >>>> > > >>>> > > https://people.apache.org/~junrao/kafka-0.8.2.1-candidate2/RELEASE_NOTES.html > > >>>> > > >>>> *** Please download, test and vote by Monday, Mar 2, 3pm PT > > >>>> > > >>>> Kafka's KEYS file containing PGP keys we use to sign the release: > > >>>> http://kafka.apache.org/KEYS in addition to the md5, sha1 > > >>>> and sha2 (SHA256) checksum. > > >>>> > > >>>> * Release artifacts to be voted upon (source and binary): > > >>>> https://people.apache.org/~junrao/kafka-0.8.2.1-candidate2/ > > >>>> > > >>>> * Maven artifacts to be voted upon prior to release: > > >>>> https://repository.apache.org/content/groups/staging/ > > >>>> > > >>>> * scala-doc > > >>>> https://people.apache.org/~junrao/kafka-0.8.2.1-candidate2/scaladoc/ > > >>>> > > >>>> * java-doc > > >>>> https://people.apache.org/~junrao/kafka-0.8.2.1-candidate2/javadoc/ > > >>>> > > >>>> * The tag to be voted upon (off the 0.8.2 branch) is the 0.8.2.1 tag > > >>>> > > >>>> > > https://git-wip-us.apache.org/repos/asf?p=kafka.git;a=tag;h=bd1bfb63ec73c10d08432ac893a23f28281ea021 > > >>>> (git commit ee1267b127f3081db491fa1bf9a287084c324e36) > > >>>> > > >>>> /******************************************* > > >>>> > > >>>> Thanks, > > >>>> > > >>>> Jun > > >>>> > > >>>> > > >>> -- > > >>> You received this message because you are subscribed to the Google > > >>> Groups "kafka-clients" group. > > >>> To unsubscribe from this group and stop receiving emails from it, send > > >>> an email to kafka-clients+unsubscr...@googlegroups.com. > > >>> To post to this group, send email to kafka-clie...@googlegroups.com. > > >>> Visit this group at http://groups.google.com/group/kafka-clients. > > >>> To view this discussion on the web visit > > >>> > > https://groups.google.com/d/msgid/kafka-clients/CAFc58G_5FuLKx3_kM4PCgqQL8d%2B4sqE0o-%2BXfu3FJicAgn5KPw%40mail.gmail.com > > >>> < > > https://groups.google.com/d/msgid/kafka-clients/CAFc58G_5FuLKx3_kM4PCgqQL8d%2B4sqE0o-%2BXfu3FJicAgn5KPw%40mail.gmail.com?utm_medium=email&utm_source=footer > > > > > >>> . > > >>> > > >>> For more options, visit https://groups.google.com/d/optout. > > >>> > > >> > > >> > > > > > > > > > -- > Thanks, > Neha
