[jira] [Updated] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

2015-02-26 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1824: Attachment: KAFKA-1824_2015-02-26_23:05:10.patch > in ConsoleProducer - properties key.separator and

[jira] [Commented] (KAFKA-1824) in ConsoleProducer - properties key.separator and parse.key no longer work

2015-02-26 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339818#comment-14339818 ] Gwen Shapira commented on KAFKA-1824: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 29231: Patch for KAFKA-1824

2015-02-26 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29231/ --- (Updated Feb. 27, 2015, 7:05 a.m.) Review request for kafka. Bugs: KAFKA-1824

[jira] [Commented] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-02-26 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339751#comment-14339751 ] Jun Rao commented on KAFKA-1988: Actually, we can probably keep the same logic in determin

Re: [VOTE] KIP-3 Mirror Maker Enhancement

2015-02-26 Thread Neha Narkhede
+1 (binding) On Thu, Feb 26, 2015 at 2:14 PM, Joel Koshy wrote: > +1 (binding) > > On Tue, Feb 24, 2015 at 06:37:53PM -0800, Guozhang Wang wrote: > > +1 binding > > > > On Tue, Feb 24, 2015 at 5:24 PM, Gwen Shapira > wrote: > > > > > +1 (non-binding) > > > > > > On Tue, Feb 24, 2015 at 5:14 PM,

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

2015-02-26 Thread Jay Kreps
Can we change the command line arguments for mm to match the command line arguments elsewhere. This proposal seems to have two formats: *--consumer.rebalance.listener* and *--abortOnSendFail* The '.' separators for command line options predate this JIRA but I think the new camelCase option is a new

[jira] [Updated] (KAFKA-1809) Refactor brokers to allow listening on multiple ports and IPs

2015-02-26 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1809: Attachment: KAFKA-1809.v2.patch Updated per review from Jun Rao. > Refactor brokers to allow listen

Re: Review Request 28769: Patch for KAFKA-1809

2015-02-26 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28769/ --- (Updated Feb. 27, 2015, 4:31 a.m.) Review request for kafka. Changes ---

Build failed in Jenkins: KafkaPreCommit #22

2015-02-26 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1400; transient unit test failure in SocketServerTest; patched by Jun Rao; reviewed by Ewen Cheslack-Postava and Jiangjie Qin -- [...truncated 306 lines...] kafka.log.Lo

Build failed in Jenkins: Kafka-trunk #409

2015-02-26 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1400; transient unit test failure in SocketServerTest; patched by Jun Rao; reviewed by Ewen Cheslack-Postava and Jiangjie Qin -- [...truncated 894 lines...] kafka.log.LogM

Re: Review Request 28769: Patch for KAFKA-1809

2015-02-26 Thread Gwen Shapira
> On Feb. 12, 2015, 7:46 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/protocol/ApiVersion.java, > > lines 20-27 > > > > > > It seems that we rely on the lexicographical ordering of the enum n

Re: Review Request 28769: Patch for KAFKA-1809

2015-02-26 Thread Gwen Shapira
> On Feb. 11, 2015, 9:45 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, lines 70-72 > > > > > > Same comment as above, does a null string translate into a null in > > endPoint.host? > >

Re: Review Request 28769: Patch for KAFKA-1809

2015-02-26 Thread Gwen Shapira
> On Feb. 11, 2015, 9:45 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, lines 70-72 > > > > > > Same comment as above, does a null string translate into a null in > > endPoint.host? yes.

Re: Review Request 28769: Patch for KAFKA-1809

2015-02-26 Thread Gwen Shapira
> On Feb. 11, 2015, 9:45 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/consumer/ConsumerConfig.scala, lines 184-186 > > > > > > I thought we won't support security in the old client? We don't, but I need to test

[jira] [Commented] (KAFKA-1400) transient unit test failure in SocketServerTest

2015-02-26 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339588#comment-14339588 ] Gwen Shapira commented on KAFKA-1400: - I was under the impression that this was there

[jira] [Commented] (KAFKA-1400) transient unit test failure in SocketServerTest

2015-02-26 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339552#comment-14339552 ] Jun Rao commented on KAFKA-1400: Well, this test is supposed to test the client behavior.

[jira] [Commented] (KAFKA-1400) transient unit test failure in SocketServerTest

2015-02-26 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339541#comment-14339541 ] Gwen Shapira commented on KAFKA-1400: - Any reason you prefer to try and detect a close

[jira] [Updated] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-02-26 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1988: --- Priority: Blocker (was: Major) Affects Version/s: 0.8.2.0 Fix Version/s: 0.8.2.1 Since t

[jira] [Commented] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-02-26 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339500#comment-14339500 ] Jun Rao commented on KAFKA-1988: Thanks for the patch. +1. We actually made the same mist

Re: Review Request 31510: Patch for kafka-1400

2015-02-26 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31510/#review74415 --- Ship it! Ship It! - Jiangjie Qin On Feb. 27, 2015, 12:15 a.m., J

[jira] [Updated] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-02-26 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1988: --- Status: Patch Available (was: Open) > org.apache.kafka.common.utils.Utils.abs method returns wrong value for

[jira] [Commented] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-02-26 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339478#comment-14339478 ] Tong Li commented on KAFKA-1988: Created reviewboard https://reviews.apache.org/r/31517/di

[jira] [Updated] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-02-26 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1988: --- Attachment: KAFKA-1988.patch > org.apache.kafka.common.utils.Utils.abs method returns wrong value for > negat

Review Request 31517: Patch for KAFKA-1988

2015-02-26 Thread Tong Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31517/ --- Review request for kafka. Bugs: KAFKA-1988 https://issues.apache.org/jira/b

Re: Review Request 31510: Patch for kafka-1400

2015-02-26 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31510/#review74411 --- Ship it! LGTM. Tested 50 times with no failures. - Ewen Cheslack-P

[jira] [Created] (KAFKA-1988) org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers.

2015-02-26 Thread Tong Li (JIRA)
Tong Li created KAFKA-1988: -- Summary: org.apache.kafka.common.utils.Utils.abs method returns wrong value for negative numbers. Key: KAFKA-1988 URL: https://issues.apache.org/jira/browse/KAFKA-1988 Project: K

[jira] [Commented] (KAFKA-1400) transient unit test failure in SocketServerTest

2015-02-26 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339452#comment-14339452 ] Jun Rao commented on KAFKA-1400: Provide a simple fix to send enough bytes to trigger a so

[jira] [Commented] (KAFKA-1400) transient unit test failure in SocketServerTest

2015-02-26 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339451#comment-14339451 ] Jun Rao commented on KAFKA-1400: Created reviewboard https://reviews.apache.org/r/31510/di

[jira] [Updated] (KAFKA-1400) transient unit test failure in SocketServerTest

2015-02-26 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1400: --- Attachment: kafka-1400.patch > transient unit test failure in SocketServerTest > -

[jira] [Updated] (KAFKA-1400) transient unit test failure in SocketServerTest

2015-02-26 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1400: --- Assignee: Jun Rao (was: Neha Narkhede) Status: Patch Available (was: Reopened) > transient unit test f

Review Request 31510: Patch for kafka-1400

2015-02-26 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31510/ --- Review request for kafka. Bugs: kafka-1400 https://issues.apache.org/jira/b

Build failed in Jenkins: Kafka-trunk #408

2015-02-26 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1881; transient unit test failure in testDeleteTopicWithCleaner due to OOME; patched by Ewen Cheslack-Postava; reviewed by Jun Rao -- [...truncated 1022 lines...] kafka.pr

Build failed in Jenkins: KafkaPreCommit #21

2015-02-26 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1881; transient unit test failure in testDeleteTopicWithCleaner due to OOME; patched by Ewen Cheslack-Postava; reviewed by Jun Rao -- [...truncated 2088 lines...]

[jira] [Updated] (KAFKA-1881) transient unit test failure in testDeleteTopicWithCleaner due to OOME

2015-02-26 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1881: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for t

[VOTE] 0.8.2.1 Candidate 2

2015-02-26 Thread Jun Rao
This is the second candidate for release of Apache Kafka 0.8.2.1. This fixes 4 critical issue in 0.8.2.0. Release Notes for the 0.8.2.1 release https://people.apache.org/~junrao/kafka-0.8.2.1-candidate2/RELEASE_NOTES.html *** Please download, test and vote by Monday, Mar 2, 3pm PT Kafka's KEYS f

Re: Review Request 31449: Patch for KAFKA-1986

2015-02-26 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31449/#review74380 --- Ship it! Ship It! - Joel Koshy On Feb. 25, 2015, 11:54 p.m., Adi

Re: Review Request 31369: Patch for KAFKA-1982

2015-02-26 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review74379 --- Thanks for the patch. Some comments below. examples/src/main/java/

Re: [VOTE] KIP-3 Mirror Maker Enhancement

2015-02-26 Thread Joel Koshy
+1 (binding) On Tue, Feb 24, 2015 at 06:37:53PM -0800, Guozhang Wang wrote: > +1 binding > > On Tue, Feb 24, 2015 at 5:24 PM, Gwen Shapira wrote: > > > +1 (non-binding) > > > > On Tue, Feb 24, 2015 at 5:14 PM, Jiangjie Qin > > wrote: > > > > > > > > > > https://cwiki.apache.org/confluence/disp

[jira] [Commented] (KAFKA-1987) Potential race condition in partition creation

2015-02-26 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339225#comment-14339225 ] Joel Koshy commented on KAFKA-1987: --- Looking at the code I think this is possible when t

[jira] [Created] (KAFKA-1987) Potential race condition in partition creation

2015-02-26 Thread Todd Palino (JIRA)
Todd Palino created KAFKA-1987: -- Summary: Potential race condition in partition creation Key: KAFKA-1987 URL: https://issues.apache.org/jira/browse/KAFKA-1987 Project: Kafka Issue Type: Bug

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

2015-02-26 Thread Jiangjie Qin
KAFKA-1650 added this option, but we don’t have ―no.data.loss in any official release. On 2/26/15, 12:01 PM, "Gwen Shapira" wrote: >Did --no.data.loss exist in previous releases of irrorMaker? >If it does, maybe we want to keep it around for backward compatibility? >(i.e. so existing dployments

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

2015-02-26 Thread Gwen Shapira
Did --no.data.loss exist in previous releases of MirrorMaker? If it does, maybe we want to keep it around for backward compatibility? (i.e. so existing deployments won't break)? Gwen On Thu, Feb 26, 2015 at 11:57 AM, Jiangjie Qin wrote: > Hi Neha, > > Thanks for the comment. That’s a really goo

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

2015-02-26 Thread Jiangjie Qin
Hi Neha, Thanks for the comment. That’s a really good point. Originally I’m thinking about allowing user to tweak some parameter as needed. For example, some user might want to have pipeline enabled and can tolerate reordering, some user might want to use acks=1 or acks=0, some might want to move

Re: Review Request 30763: KAFKA-1865: add flush to producer

2015-02-26 Thread Jun Rao
> On Feb. 26, 2015, 7:15 p.m., Jun Rao wrote: > > clients/src/test/java/org/apache/kafka/clients/producer/MetadataTest.java, > > line 87 > > > > > > Do we really want to print the stack trace? > > Jay Kreps wrote: >

[jira] [Commented] (KAFKA-1684) Implement TLS/SSL authentication

2015-02-26 Thread Suresh Vallabhaneni (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338996#comment-14338996 ] Suresh Vallabhaneni commented on KAFKA-1684: There appears to be a patch KAFKA

Re: Review Request 30763: KAFKA-1865: add flush to producer

2015-02-26 Thread Jay Kreps
> On Feb. 26, 2015, 7:15 p.m., Jun Rao wrote: > > clients/src/test/java/org/apache/kafka/clients/producer/MetadataTest.java, > > line 87 > > > > > > Do we really want to print the stack trace? I think so, we are not e

[jira] [Commented] (KAFKA-1865) Add a flush() call to the new producer API

2015-02-26 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338944#comment-14338944 ] Jun Rao commented on KAFKA-1865: The KIP (https://cwiki.apache.org/confluence/display/KAF

Re: Review Request 30763: KAFKA-1865: add flush to producer

2015-02-26 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/#review74332 --- Ship it! Looks good to me. Just a couple of minor comments. clien

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-26 Thread Gwen Shapira
> On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: > > Ah, now I get what "dedupe buffer" refers to :) > > > > I never managed to reproduce the oom, but this looks like the right fix. > > Ewen Cheslack-Postava wrote: > This happened consistently for me, which provided good motivation to >

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-26 Thread Ewen Cheslack-Postava
> On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: > > Ah, now I get what "dedupe buffer" refers to :) > > > > I never managed to reproduce the oom, but this looks like the right fix. > > Ewen Cheslack-Postava wrote: > This happened consistently for me, which provided good motivation to >

[jira] [Commented] (KAFKA-1755) Improve error handling in log cleaner

2015-02-26 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338907#comment-14338907 ] Joel Koshy commented on KAFKA-1755: --- Updated reviewboard https://reviews.apache.org/r/31

Re: Review Request 31306: Patch for KAFKA-1755

2015-02-26 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/#review74329 --- core/src/main/scala/kafka/message/ByteBufferMessageSet.scala

[jira] [Updated] (KAFKA-1755) Improve error handling in log cleaner

2015-02-26 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1755: -- Attachment: KAFKA-1755_2015-02-26_10:54:50.patch > Improve error handling in log cleaner > -

Re: Review Request 31306: Patch for KAFKA-1755

2015-02-26 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31306/ --- (Updated Feb. 26, 2015, 6:54 p.m.) Review request for kafka. Bugs: KAFKA-1755

Re: Review Request 31306: Patch for KAFKA-1755

2015-02-26 Thread Joel Koshy
> On Feb. 26, 2015, 3:23 a.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala, line 205 > > > > > > Can we add the key-validation logic into analyzeAndValidateMessageSet()? No -

Re: Review Request 30763: KAFKA-1865: add flush to producer

2015-02-26 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/ --- (Updated Feb. 26, 2015, 6:40 p.m.) Review request for kafka. Bugs: KAFKA-1865

[jira] [Updated] (KAFKA-1865) Add a flush() call to the new producer API

2015-02-26 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1865: - Attachment: KAFKA-1865_2015-02-26_10:37:16.patch > Add a flush() call to the new producer API > --

[jira] [Commented] (KAFKA-1865) Add a flush() call to the new producer API

2015-02-26 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338880#comment-14338880 ] Jay Kreps commented on KAFKA-1865: -- Updated reviewboard https://reviews.apache.org/r/3076

Re: Review Request 30763: KAFKA-1865: add flush to producer

2015-02-26 Thread Jay Kreps
> On Feb. 24, 2015, 5:20 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java, > > line 91 > > > > > > I still think it is kind of waste to create duplicate

Re: Review Request 30763: KAFKA-1865: add flush to producer

2015-02-26 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/ --- (Updated Feb. 26, 2015, 6:37 p.m.) Review request for kafka. Summary (updated

Re: Review Request 30763: KAFKA-1865: Producer Flush: Remove synchronization.

2015-02-26 Thread Jay Kreps
> On Feb. 26, 2015, 7:14 a.m., Ewen Cheslack-Postava wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java, > > line 132 > > > > > > synchronized no longer matches the regular non-Mock v

Re: Review Request 30763: KAFKA-1865: add flush to producer

2015-02-26 Thread Jay Kreps
> On Feb. 17, 2015, 9:28 p.m., Jiangjie Qin wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java, > > line 80 > > > > > > I think we have to execute the callback before we wake

Re: Review Request 30763: KAFKA-1865: Producer Flush: Remove synchronization.

2015-02-26 Thread Jay Kreps
> On Feb. 26, 2015, 5:47 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 503 > > > > > > Not sure how we make sure only a single flush at a time. Could you

Re: Review Request 31447: Patch for KAFKA-1881

2015-02-26 Thread Gwen Shapira
> On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote: > > Ah, now I get what "dedupe buffer" refers to :) > > > > I never managed to reproduce the oom, but this looks like the right fix. > > Ewen Cheslack-Postava wrote: > This happened consistently for me, which provided good motivation to >

Re: [KIP-DISCUSSION] Mirror Maker Enhancement

2015-02-26 Thread Neha Narkhede
Hey Becket, The KIP proposes addition of a --no.data.loss command line option to the MirrorMaker. Though when would the user not want that option? I'm wondering what the benefit of providing that option is if every user would want that for correct mirroring behavior. Other than that, the KIP look

[jira] [Updated] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

2015-02-26 Thread Dmitry Pekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Pekar updated KAFKA-1792: Attachment: rebalance_use_cases.txt > change behavior of --generate to produce assignment config wit

[jira] [Comment Edited] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

2015-02-26 Thread Dmitry Pekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338489#comment-14338489 ] Dmitry Pekar edited comment on KAFKA-1792 at 2/26/15 3:00 PM: --

[jira] [Updated] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

2015-02-26 Thread Dmitry Pekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Pekar updated KAFKA-1792: Attachment: (was: rebalance_use_cases.txt) > change behavior of --generate to produce assignment

Re: Review Request 28481: Patch for KAFKA-1792

2015-02-26 Thread Dmitry Pekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28481/ --- (Updated Feb. 26, 2015, 2:58 p.m.) Review request for kafka. Bugs: KAFKA-1792

[jira] [Commented] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

2015-02-26 Thread Dmitry Pekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338489#comment-14338489 ] Dmitry Pekar commented on KAFKA-1792: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

2015-02-26 Thread Dmitry Pekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Pekar updated KAFKA-1792: Attachment: KAFKA-1792_2015-02-26_16:58:23.patch > change behavior of --generate to produce assignme

[jira] [Commented] (KAFKA-1460) NoReplicaOnlineException: No replica for partition

2015-02-26 Thread Po Zhou (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338303#comment-14338303 ] Po Zhou commented on KAFKA-1460: I occasionally encountered the issue with the following e