[jira] [Resolved] (KAFKA-1959) Class CommitThread overwrite group of Thread class causing compile errors

2015-02-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-1959. --- Resolution: Fixed Assignee: Tong Li Thanks for the patch - committed to trunk. > Class CommitTh

[jira] [Resolved] (KAFKA-1960) .gitignore does not exclude test generated files and folders.

2015-02-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-1960. --- Resolution: Fixed Assignee: Tong Li Thanks for the patch - committed to trunk. > .gitignore doe

Re: Review Request 27391: Fix KAFKA-1634

2015-02-17 Thread Joel Koshy
> On Feb. 4, 2015, 2:15 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/api/OffsetCommitRequest.scala, line 48 > > > > > > I our convention is to include the if in the previous line. > > Guozhang Wang wrote: >

Re: Review Request 31097: Patch for KAFKA-1960

2015-02-17 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31097/#review72911 --- Ship it! Ship It! - Joel Koshy On Feb. 16, 2015, 9:48 p.m., Tong

Re: Review Request 31088: Patch for KAFKA-1959

2015-02-17 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31088/#review72910 --- Ship it! Ship It! - Joel Koshy On Feb. 16, 2015, 4:37 p.m., Tong

Re: Review Request 29912: Patch for KAFKA-1852

2015-02-17 Thread Joel Koshy
> On Feb. 13, 2015, 7:01 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/OffsetManager.scala, line 215 > > > > > > Minor comment. I think this may be better to pass in to the > > OffsetManager. > > >

Re: Review Request 31150: Patch for kafka-1952

2015-02-17 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31150/#review72907 --- Ship it! core/src/main/scala/kafka/server/DelayedOperation.scala <

Scala IDE debugging Unit Test Issues

2015-02-17 Thread Jonathan Rafalski
Hello all, Completely new to kafka and scala but thought I would get my feet wet with a few of the newbie tasks. I was able to get the source up and running in the Scala IDE and I am able to debug the examples, however when I try to debug any of the unit tests in core (for example the unit.ka

[jira] [Commented] (KAFKA-1952) High CPU Usage in 0.8.2 release

2015-02-17 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325439#comment-14325439 ] Jun Rao commented on KAFKA-1952: Attach a patch for trunk. The CPU load and the end to end

[jira] [Commented] (KAFKA-1952) High CPU Usage in 0.8.2 release

2015-02-17 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325435#comment-14325435 ] Jun Rao commented on KAFKA-1952: Created reviewboard https://reviews.apache.org/r/31150/di

[jira] [Updated] (KAFKA-1952) High CPU Usage in 0.8.2 release

2015-02-17 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1952: --- Attachment: kafka-1952.patch > High CPU Usage in 0.8.2 release > --- > >

Review Request 31150: Patch for kafka-1952

2015-02-17 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31150/ --- Review request for kafka. Bugs: kafka-1952 https://issues.apache.org/jira/b

Build failed in Jenkins: KafkaPreCommit #7

2015-02-17 Thread Apache Jenkins Server
See Changes: [jjkoshy] KAFKA-1943; MessageSizeTooLarge and MessageSetSizeTooLarge should not be counted toward broker-side producer failure rate [jjkoshy] KAFKA-1914; Include total produce/fetch stats in broker topic metrics. ---

[jira] [Commented] (KAFKA-1953) Disambiguate metrics from different purgatories

2015-02-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325327#comment-14325327 ] Joel Koshy commented on KAFKA-1953: --- Updated reviewboard https://reviews.apache.org/r/31

[jira] [Updated] (KAFKA-1953) Disambiguate metrics from different purgatories

2015-02-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1953: -- Attachment: KAFKA-1953_2015-02-17_18:23:55.patch > Disambiguate metrics from different purgatories > ---

Re: Review Request 31140: Patch for KAFKA-1953

2015-02-17 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31140/ --- (Updated Feb. 18, 2015, 2:23 a.m.) Review request for kafka. Bugs: KAFKA-1953

Build failed in Jenkins: Kafka-trunk #394

2015-02-17 Thread Apache Jenkins Server
See Changes: [jjkoshy] KAFKA-1943; MessageSizeTooLarge and MessageSetSizeTooLarge should not be counted toward broker-side producer failure rate [jjkoshy] KAFKA-1914; Include total produce/fetch stats in broker topic metrics.

Re: Review Request 31140: Patch for KAFKA-1953

2015-02-17 Thread Joel Koshy
> On Feb. 18, 2015, 2:06 a.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/DelayedOperation.scala, line 286 > > > > > > We can move the debug statement out of the synchronized block. Good point. > On F

Build failed in Jenkins: Kafka-trunk #393

2015-02-17 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-1805; ProducerRecord should implement equals and hashCode; reviewed by Guozhang Wang -- [...truncated 1695 lines...] kafka.log.LogManagerTest > testLeastLoadedAssignment

Re: Review Request 31140: Patch for KAFKA-1953

2015-02-17 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31140/#review72875 --- core/src/main/scala/kafka/server/DelayedOperation.scala

Re: Review Request 30809: Patch for KAFKA-1888

2015-02-17 Thread Abhishek Nigam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/ --- (Updated Feb. 18, 2015, 1:59 a.m.) Review request for kafka. Bugs: KAFKA-1888

Build failed in Jenkins: KafkaPreCommit #6

2015-02-17 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-1805; ProducerRecord should implement equals and hashCode; reviewed by Guozhang Wang -- [...truncated 562 lines...] org.apache.kafka.common.config.ConfigDefTest > test

[jira] [Resolved] (KAFKA-1914) Count TotalProduceRequestRate and TotalFetchRequestRate in BrokerTopicMetrics

2015-02-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-1914. --- Resolution: Fixed Committed to trunk > Count TotalProduceRequestRate and TotalFetchRequestRate in Bro

[jira] [Resolved] (KAFKA-1943) Producer request failure rate should not include MessageSetSizeTooLarge and MessageSizeTooLargeException

2015-02-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-1943. --- Resolution: Fixed Committed to trunk > Producer request failure rate should not include MessageSetSiz

Re: Review Request 31140: Patch for KAFKA-1953

2015-02-17 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31140/#review72849 --- Couple of comments to call out. core/src/main/scala/kafka/server/D

[jira] [Updated] (KAFKA-1953) Disambiguate metrics from different purgatories

2015-02-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1953: -- Status: Patch Available (was: Open) > Disambiguate metrics from different purgatories > ---

[jira] [Updated] (KAFKA-1953) Disambiguate metrics from different purgatories

2015-02-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1953: -- Attachment: KAFKA-1953.patch > Disambiguate metrics from different purgatories > ---

[jira] [Commented] (KAFKA-1953) Disambiguate metrics from different purgatories

2015-02-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325219#comment-14325219 ] Joel Koshy commented on KAFKA-1953: --- Created reviewboard https://reviews.apache.org/r/31

Review Request 31140: Patch for KAFKA-1953

2015-02-17 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31140/ --- Review request for kafka. Bugs: KAFKA-1953 https://issues.apache.org/jira/b

Re: Review Request 30570: Patch for KAFKA-1914

2015-02-17 Thread Aditya Auradkar
> On Feb. 18, 2015, 12:41 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/KafkaRequestHandler.scala, line 108 > > > > > > I think the aggregate rates here are redundant to what's already there > > in Requ

[jira] [Commented] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

2015-02-17 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325210#comment-14325210 ] Parth Brahmbhatt commented on KAFKA-1660: - [~jkreps] I have updated the review wit

[jira] [Assigned] (KAFKA-1962) Restore delayed request metrics

2015-02-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reassigned KAFKA-1962: - Assignee: Joel Koshy I'll combine this with KAFKA-1953 > Restore delayed request metrics > -

[jira] [Updated] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

2015-02-17 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-1660: Assignee: Parth Brahmbhatt (was: Jun Rao) Status: Patch Available (was: Open) > Abil

[jira] [Updated] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

2015-02-17 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-1660: Attachment: KAFKA-1660_2015-02-17_16:41:19.patch > Ability to call close() with a timeout on

[jira] [Commented] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

2015-02-17 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325207#comment-14325207 ] Parth Brahmbhatt commented on KAFKA-1660: - Updated reviewboard https://reviews.apa

Re: Review Request 29467: Patch for KAFKA-1660

2015-02-17 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29467/ --- (Updated Feb. 18, 2015, 12:41 a.m.) Review request for kafka. Bugs: KAFKA-166

Re: Review Request 30570: Patch for KAFKA-1914

2015-02-17 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30570/#review72845 --- Ship it! core/src/main/scala/kafka/server/KafkaRequestHandler.scal

Re: Review Request 29467: Patch for KAFKA-1660

2015-02-17 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29467/ --- (Updated Feb. 18, 2015, 12:36 a.m.) Review request for kafka. Bugs: KAFKA-166

Re: Review Request 30848: Patch for KAFKA-1943

2015-02-17 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30848/#review72837 --- Ship it! Ship It! - Joel Koshy On Feb. 10, 2015, 10:17 p.m., Adi

[jira] [Updated] (KAFKA-1805) Kafka ProducerRecord should implement equals

2015-02-17 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1805: - Assignee: Parth Brahmbhatt (was: Thomas Omans) > Kafka ProducerRecord should implement equals > -

Re: Review Request 30570: Patch for KAFKA-1914

2015-02-17 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30570/#review72836 --- Ship it! Ship It! - Guozhang Wang On Feb. 17, 2015, 11:46 p.m.,

[jira] [Resolved] (KAFKA-1805) Kafka ProducerRecord should implement equals

2015-02-17 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-1805. -- Resolution: Fixed > Kafka ProducerRecord should implement equals > -

[jira] [Commented] (KAFKA-1805) Kafka ProducerRecord should implement equals

2015-02-17 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325187#comment-14325187 ] Guozhang Wang commented on KAFKA-1805: -- Thanks for the patch, committed to trunk. >

Re: Review Request 30809: Patch for KAFKA-1888

2015-02-17 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review72786 --- core/src/main/scala/kafka/tools/ContinuousValidationTest.java

[jira] [Updated] (KAFKA-1914) Count TotalProduceRequestRate and TotalFetchRequestRate in BrokerTopicMetrics

2015-02-17 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-1914: - Attachment: KAFKA-1914_2015-02-17_15:46:27.patch > Count TotalProduceRequestRate and Total

Re: Review Request 30570: Patch for KAFKA-1914

2015-02-17 Thread Aditya Auradkar
> On Feb. 17, 2015, 11:02 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala, line 137 > > > > > > Should this be BrokerTopicStats.getBrokerAllTopicsStats()? Good catch. Fixed

Re: Review Request 30763: Patch for KAFKA-1865

2015-02-17 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/#review72821 --- clients/src/main/java/org/apache/kafka/clients/producer/KafkaProduc

[jira] [Commented] (KAFKA-1914) Count TotalProduceRequestRate and TotalFetchRequestRate in BrokerTopicMetrics

2015-02-17 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325135#comment-14325135 ] Aditya A Auradkar commented on KAFKA-1914: -- Updated reviewboard https://reviews.a

Re: Review Request 30570: Patch for KAFKA-1914

2015-02-17 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30570/ --- (Updated Feb. 17, 2015, 11:46 p.m.) Review request for kafka and Joel Koshy.

[jira] [Updated] (KAFKA-1952) High CPU Usage in 0.8.2 release

2015-02-17 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1952: --- Fix Version/s: (was: 0.8.2.0) 0.8.2.1 > High CPU Usage in 0.8.2 release > -

Re: Review Request 30570: Patch for KAFKA-1914

2015-02-17 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30570/#review72817 --- core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala

Re: [DISCUSS] KIP-8 Add a flush method to the new Java producer

2015-02-17 Thread Jay Kreps
Yeah there was a separate thread on adding a client-side timeout to requests. We should have this in the new java clients, it just isn't there yet. When we do this the flush() call will implicitly have the same timeout as the requests (since they will complete or fail by then). I think this makes f

Re: [DISCUSS] KIP-8 Add a flush method to the new Java producer

2015-02-17 Thread Guozhang Wang
In the scala clients we have the socket.timeout config as we are using blocking IOs, when such timeout is reached the TimeoutException will be thrown from the socket and the client can handle it accordingly; in the java clients we are switching to non-blocking IOs and hence we will not have the soc

Re: [DISCUSS] KIP-8 Add a flush method to the new Java producer

2015-02-17 Thread Jiangjie Qin
I'm thinking the flush call timeout will naturally be the timeout for a produce request, No? Currently it seems we don¹t have a timeout for client requests, should we have one? ‹Jiangjie (Becket) Qin On 2/16/15, 8:19 PM, "Jay Kreps" wrote: >Yes, I think we all agree it would be good to add a c

[jira] [Commented] (KAFKA-1961) Looks like its possible to delete _consumer_offsets topic

2015-02-17 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324924#comment-14324924 ] Jay Kreps commented on KAFKA-1961: -- Yeah I think since the cache would be totally out of

Re: Review Request 30763: Patch for KAFKA-1865

2015-02-17 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/#review72794 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/R

[jira] [Commented] (KAFKA-1961) Looks like its possible to delete _consumer_offsets topic

2015-02-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324917#comment-14324917 ] Joel Koshy commented on KAFKA-1961: --- Yes it would be inconsistent in that you would lose

Re: two very simple patch sets to be reviewed.

2015-02-17 Thread Tong Li
Gwen, Really appreciate it. Thanks so much. Anyone else please review them? Here are the links again. > https://reviews.apache.org/r/31088/ > > https://reviews.apache.org/r/31097/ Tong Li OpenStack Community Development Building 501/B205 liton...@us.ibm.com From: Gwen Shapira To:

Re: two very simple patch sets to be reviewed.

2015-02-17 Thread Gwen Shapira
I've reviewed both (but can't commit obviously) They are both safe (a rename and an addition to .gitignore). The addition to .gitignore will be very useful for anyone who uses system tests (which should be all of us). The rename is useful only to those using IBM JDK (i.e. not all of us), but since

[jira] [Commented] (KAFKA-1961) Looks like its possible to delete _consumer_offsets topic

2015-02-17 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324770#comment-14324770 ] Jay Kreps commented on KAFKA-1961: -- Makes sense. [~jjkoshy] Deleting the topic would lea

Re: Review Request 29301: Patch for KAFKA-1694

2015-02-17 Thread Guozhang Wang
> On Feb. 3, 2015, 7:14 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java, lines > > 39-42 > > > > > > How about merge them into one request? The format could be: > >

[jira] [Commented] (KAFKA-1694) kafka command line and centralized operations

2015-02-17 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324755#comment-14324755 ] Guozhang Wang commented on KAFKA-1694: -- [~abiletskyi], I am wondering if we can split

[jira] [Commented] (KAFKA-1961) Looks like its possible to delete _consumer_offsets topic

2015-02-17 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324724#comment-14324724 ] Gwen Shapira commented on KAFKA-1961: - [~jkreps] - by "accidentally" I mean, "I don't

[jira] [Commented] (KAFKA-1867) liveBroker list not updated on a cluster with no topics

2015-02-17 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324659#comment-14324659 ] Sriharsha Chintalapani commented on KAFKA-1867: --- [~nehanarkhede] pinging for

Re: Review Request 29912: Patch for KAFKA-1852

2015-02-17 Thread Sriharsha Chintalapani
> On Feb. 13, 2015, 7:01 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/OffsetManager.scala, line 215 > > > > > > Minor comment. I think this may be better to pass in to the > > OffsetManager. > > >

[jira] [Commented] (KAFKA-1866) LogStartOffset gauge throws exceptions after log.delete()

2015-02-17 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324656#comment-14324656 ] Sriharsha Chintalapani commented on KAFKA-1866: --- [~nehanarkhede] pinging for

[jira] [Assigned] (KAFKA-1778) Create new re-elect controller admin function

2015-02-17 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Nigam reassigned KAFKA-1778: - Assignee: Abhishek Nigam > Create new re-elect controller admin function > --

Re: Review Request 30848: Patch for KAFKA-1943

2015-02-17 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30848/#review72749 --- Ship it! Ship It! - Guozhang Wang On Feb. 10, 2015, 10:17 p.m.,

two very simple patch sets to be reviewed.

2015-02-17 Thread Tong Li
Dear kafka developers, New to this community and put up two really small patch sets with open issues, can any one please review and comment and get them merged if all possible? Thanks https://reviews.apache.org/r/31088/ https://reviews.apache.org/r/31097/ Tong Li OpenStack Community D

two very simple patch sets to be reviewed.

2015-02-17 Thread Tong Li
Dear kafka developers, New to this community and put up two really small patch sets with open issues, can any one please review and comment and get them merged if all possible? Thanks https://reviews.apache.org/r/31097/ https://reviews.apache.org/r/31097/ Tong Li OpenStack & Kafka Commu

[jira] [Commented] (KAFKA-1961) Looks like its possible to delete _consumer_offsets topic

2015-02-17 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324545#comment-14324545 ] Jay Kreps commented on KAFKA-1961: -- This would be hard to do accidentally, right, you hav

[jira] [Commented] (KAFKA-1961) Looks like its possible to delete _consumer_offsets topic

2015-02-17 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324505#comment-14324505 ] Neha Narkhede commented on KAFKA-1961: -- That's a good catch [~gwenshap]. Seems like a

[jira] [Updated] (KAFKA-1961) Looks like its possible to delete _consumer_offsets topic

2015-02-17 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1961: - Labels: newbie (was: ) > Looks like its possible to delete _consumer_offsets topic >

[jira] [Updated] (KAFKA-1961) Looks like its possible to delete _consumer_offsets topic

2015-02-17 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1961: - Affects Version/s: 0.8.2.0 > Looks like its possible to delete _consumer_offsets topic > -

[jira] [Created] (KAFKA-1963) Add unit tests to check presence of all metrics

2015-02-17 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1963: - Summary: Add unit tests to check presence of all metrics Key: KAFKA-1963 URL: https://issues.apache.org/jira/browse/KAFKA-1963 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-1962) Restore delayed request metrics

2015-02-17 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1962: - Summary: Restore delayed request metrics Key: KAFKA-1962 URL: https://issues.apache.org/jira/browse/KAFKA-1962 Project: Kafka Issue Type: Sub-task Repo

[jira] [Updated] (KAFKA-1946) Fix various broker metrics

2015-02-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1946: -- Summary: Fix various broker metrics (was: Improve BrokerTopicMetrics reporting) > Fix various broker m

[GitHub] kafka pull request: Update DelayedFetch.scala

2015-02-17 Thread arcz
GitHub user arcz opened a pull request: https://github.com/apache/kafka/pull/44 Update DelayedFetch.scala Fix typo You can merge this pull request into a Git repository by running: $ git pull https://github.com/arcz/kafka patch-1 Alternatively you can review and apply these ch

Re: confirm subscribe to dev@kafka.apache.org

2015-02-17 Thread Ivan Dyachkov
On Tue, 17 Feb 2015, at 08:57, dev-h...@kafka.apache.org wrote: > Hi! This is the ezmlm program. I'm managing the > dev@kafka.apache.org mailing list. > > I'm working for my owner, who can be reached > at dev-ow...@kafka.apache.org. > > To confirm that you would like > >d...@dyachkov.org >