Re: What to do when file.rename fails?

2015-01-24 Thread Jaikiran Pai
Hi Jay, I spent some more time over this today and went back to the original thread which brought up the issue with file leaks [1]. I think that output of lsof in that logs has a very important hint: /home/work/data/soft/kafka-0.8/data/_oakbay_v2_search_topic_ypgsearch_yellowpageV2-0/

Re: [kafka-clients] Re: [VOTE] 0.8.2.0 Candidate 2 (with the correct links)

2015-01-24 Thread Joe Stein
That makes sense, thanks! On Sat, Jan 24, 2015 at 7:00 PM, Jay Kreps wrote: > But I think the flaw in trying to guess what kind of serializer they will > use is when we get it wrong. Basically let's say we guess "String". Say 30% > of the time we will be right and we will save the two configurat

Re: [kafka-clients] Re: [VOTE] 0.8.2.0 Candidate 2 (with the correct links)

2015-01-24 Thread Jay Kreps
But I think the flaw in trying to guess what kind of serializer they will use is when we get it wrong. Basically let's say we guess "String". Say 30% of the time we will be right and we will save the two configuration lines. 70% of the time we will be wrong and the user gets a super cryptic ClassCa

Re: [kafka-clients] Re: [VOTE] 0.8.2.0 Candidate 2 (with the correct links)

2015-01-24 Thread Joe Stein
Maybe. I think the StringSerialzer could look more like a typical type of message. Instead of encoding being a property it would be more typically just written in the bytes. On Sat, Jan 24, 2015 at 12:12 AM, Jay Kreps wrote: > I don't think so--see if you buy my explanation. We previously defau

Re: What to do when file.rename fails?

2015-01-24 Thread Sriram Subramanian
The failure really means that the filesystem is configured incorrectly (from the link). In such circumstances it is best to fail and let the operations/admins know instead of working around it. On 1/24/15 9:42 AM, "Jay Kreps" wrote: >Hey guys, > >Jaikiran posted a patch on KAFKA-1853 to improve

Re: Review Request 30078: Patch for KAFKA-1885

2015-01-24 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30078/#review69547 --- Ship it! Ship It! - Sriharsha Chintalapani On Jan. 24, 2015, 11:

What to do when file.rename fails?

2015-01-24 Thread Jay Kreps
Hey guys, Jaikiran posted a patch on KAFKA-1853 to improve the handling of failures during delete. https://issues.apache.org/jira/browse/KAFKA-1853 The core problem here is that we are doing File.rename() as part of the delete sequence which returns false if the rename failed. Or file delete sequ

Re: Review Request 30078: Patch for KAFKA-1885

2015-01-24 Thread Jaikiran Pai
> On Jan. 24, 2015, 7:05 a.m., Manikumar Reddy O wrote: > > Can you update the README.md document Sure. I just did and have updated this patch. - Jaikiran --- This is an automatically generated e-mail. To reply, visit: https://reviews.a

[jira] [Commented] (KAFKA-1885) Allow test methods in "core" to be individually run from outside of the IDE

2015-01-24 Thread jaikiran pai (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290565#comment-14290565 ] jaikiran pai commented on KAFKA-1885: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1885) Allow test methods in "core" to be individually run from outside of the IDE

2015-01-24 Thread jaikiran pai (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jaikiran pai updated KAFKA-1885: Attachment: KAFKA-1885_2015-01-24_17:21:59.patch > Allow test methods in "core" to be individually r

Re: Review Request 30078: Patch for KAFKA-1885

2015-01-24 Thread Jaikiran Pai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30078/ --- (Updated Jan. 24, 2015, 11:52 a.m.) Review request for kafka. Bugs: KAFKA-188