----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30078/#review69547 -----------------------------------------------------------
Ship it! Ship It! - Sriharsha Chintalapani On Jan. 24, 2015, 11:52 a.m., Jaikiran Pai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30078/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2015, 11:52 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1885 > https://issues.apache.org/jira/browse/KAFKA-1885 > > > Repository: kafka > > > Description > ------- > > KAFKA-1885 Upgrade junit dependency in core to 4.6 version to allow running > individual test methods via gradle command line > > > Diffs > ----- > > README.md 35e06b1cc6373f24ea6d405cccd4aacf0f458e0d > build.gradle 1cbab29ce83e20dae0561b51eed6fdb86d522f28 > > Diff: https://reviews.apache.org/r/30078/diff/ > > > Testing > ------- > > Tested that existing support to run an entire individual test case from the > command line works as advertised: > > > ```./gradlew -Dtest.single=ProducerFailureHandlingTest core:test > > kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckZero > PASSED > > kafka.api.test.ProducerFailureHandlingTest > testTooLargeRecordWithAckOne > PASSED > > kafka.api.test.ProducerFailureHandlingTest > testNonExistentTopic PASSED > > kafka.api.test.ProducerFailureHandlingTest > testWrongBrokerList PASSED > > kafka.api.test.ProducerFailureHandlingTest > testNoResponse PASSED > > kafka.api.test.ProducerFailureHandlingTest > testInvalidPartition PASSED > > kafka.api.test.ProducerFailureHandlingTest > testSendAfterClosed PASSED > > kafka.api.test.ProducerFailureHandlingTest > testBrokerFailure PASSED > > kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic > PASSED > > kafka.api.test.ProducerFailureHandlingTest > testNotEnoughReplicas PASSED > > kafka.api.test.ProducerFailureHandlingTest > > testNotEnoughReplicasAfterBrokerShutdown PASSED > > BUILD SUCCESSFUL > > ``` > > Also tested that with this change it is now possible to run individual test > methods as follows: > > > ``` > ./gradlew clients:test --tests > org.apache.kafka.clients.producer.MetadataTest.testMetadataUpdateWaitTime > > org.apache.kafka.clients.producer.MetadataTest > testMetadataUpdateWaitTime > PASSED > ``` > > > ``` > ./gradlew core:test --tests > kafka.api.test.ProducerFailureHandlingTest.testCannotSendToInternalTopic > > kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic > PASSED > ``` > > > Thanks, > > Jaikiran Pai > >
