Need some pointers to writing (real) tests

2015-01-14 Thread Jaikiran Pai
I have been looking at some unassigned JIRAs to work on during some spare time and found this one https://issues.apache.org/jira/browse/KAFKA-1837. As I note in that JIRA, I can see why this happens and have a potential fix for it. But to first reproduce the issue and then verify the fix, I hav

Need some pointers to writing (real) tests

2015-01-14 Thread Jaikiran Pai
I have been looking at some unassigned JIRAs to work on during some spare time and found this one https://issues.apache.org/jira/browse/KAFKA-1837. As I note in that JIRA, I can see why this happens and have a potential fix for it. But to first reproduce the issue and then verify the fix, I hav

[jira] [Comment Edited] (KAFKA-1837) Metadata record future never returns on get call after producer is stopped and messages can't be sent

2015-01-14 Thread jaikiran pai (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278351#comment-14278351 ] jaikiran pai edited comment on KAFKA-1837 at 1/15/15 6:54 AM: --

[jira] [Commented] (KAFKA-1837) Metadata record future never returns on get call after producer is stopped and messages can't be sent

2015-01-14 Thread jaikiran pai (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278351#comment-14278351 ] jaikiran pai commented on KAFKA-1837: - Paul, looking at the code, I can see why this i

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2015-01-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278303#comment-14278303 ] Manikumar Reddy commented on KAFKA-1499: Thanks for the review. > Broker-side com

[jira] [Commented] (KAFKA-1854) Allow the JIRA username and password to be prompted during patch submission

2015-01-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278298#comment-14278298 ] Manikumar Reddy commented on KAFKA-1854: Yeah, I must be looking at the old page.

Re: 0.8.2.0 behavior change: ReplicaNotAvailableError

2015-01-14 Thread Jun Rao
Yes, the topicMetadataResponse format is a bit weird. The main reason that it's done that way is that we don't want to return null replica objects to the client. An alternative is to have the broker return all the replica ids and a list of live brokers, and let the client decide what to do with rep

Re: 0.8.2.0 behavior change: ReplicaNotAvailableError

2015-01-14 Thread Jun Rao
Dana, Perhaps you can make the change in the wiki first and then let us know for review? Thanks, Jun On Wed, Jan 14, 2015 at 6:35 PM, Dana Powers wrote: > Thanks -- i see that this was more of a bug in 0.8.1 than a regression in > 0.8.2. But I do think the 0.8.2 bug fix to the metadata cache

[jira] [Updated] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

2015-01-14 Thread German Borbolla (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] German Borbolla updated KAFKA-1577: --- Attachment: kafka-logs.tar.gz [~sriharsha] Sorry for the delay, I lost the previous logs but I

[jira] [Comment Edited] (KAFKA-1854) Allow the JIRA username and password to be prompted during patch submission

2015-01-14 Thread jaikiran pai (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278224#comment-14278224 ] jaikiran pai edited comment on KAFKA-1854 at 1/15/15 4:14 AM: --

[jira] [Issue Comment Deleted] (KAFKA-1854) Allow the JIRA username and password to be prompted during patch submission

2015-01-14 Thread jaikiran pai (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jaikiran pai updated KAFKA-1854: Comment: was deleted (was: Hi [~omkreddy] that page looks like a duplicate of this one https://cwik

[jira] [Comment Edited] (KAFKA-1854) Allow the JIRA username and password to be prompted during patch submission

2015-01-14 Thread jaikiran pai (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278224#comment-14278224 ] jaikiran pai edited comment on KAFKA-1854 at 1/15/15 4:14 AM: --

[jira] [Commented] (KAFKA-1854) Allow the JIRA username and password to be prompted during patch submission

2015-01-14 Thread jaikiran pai (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278224#comment-14278224 ] jaikiran pai commented on KAFKA-1854: - Hi [~omkreddy] that page looks like a duplicate

[jira] [Commented] (KAFKA-1854) Allow the JIRA username and password to be prompted during patch submission

2015-01-14 Thread jaikiran pai (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278225#comment-14278225 ] jaikiran pai commented on KAFKA-1854: - Hi [~omkreddy] that page looks like a duplicate

Build failed in Jenkins: Kafka-trunk #369

2015-01-14 Thread Apache Jenkins Server
See Changes: [jjkoshy] KAFKA-1499; Broker-side compression configuration; reviewed by Joel Koshy -- [...truncated 2766 lines...] at kafka.zk.EmbeddedZookeeper.(EmbeddedZookeeper.scala:33)

Re: 0.8.2.0 behavior change: ReplicaNotAvailableError

2015-01-14 Thread Jay Kreps
I agree. Also, is this behavior a good one? It seems kind of hacky to give an error code and a result both, no? -Jay On Wed, Jan 14, 2015 at 6:35 PM, Dana Powers wrote: > Thanks -- i see that this was more of a bug in 0.8.1 than a regression in > 0.8.2. But I do think the 0.8.2 bug fix to the

[jira] [Updated] (KAFKA-1499) Broker-side compression configuration

2015-01-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1499: -- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch. Committed to tr

Re: 0.8.2.0 behavior change: ReplicaNotAvailableError

2015-01-14 Thread Dana Powers
Thanks -- i see that this was more of a bug in 0.8.1 than a regression in 0.8.2. But I do think the 0.8.2 bug fix to the metadata cache means that the very common scenario of a single broker failure (and subsequent partition leadership change) will now return error codes in the MetadataResponse --

[jira] [Commented] (KAFKA-1853) Unsuccessful suffix rename of expired LogSegment can leak open files and also leave the LogSegment in an invalid state

2015-01-14 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278139#comment-14278139 ] Jay Kreps commented on KAFKA-1853: -- Yeah totally makes sense. There are two cases where

[jira] [Commented] (KAFKA-1853) Unsuccessful suffix rename of expired LogSegment can leak open files and also leave the LogSegment in an invalid state

2015-01-14 Thread jaikiran pai (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278129#comment-14278129 ] jaikiran pai commented on KAFKA-1853: - Hi Jay, Thank you explaining the reasoning beh

Re: [DISCUSS] Compatability and KIPs

2015-01-14 Thread Jay Kreps
Yeah this is a good point. I don't think we have really called that out in any way. I think ideally the hashing should be documented and should be an official part of the contract. -Jay On Wed, Jan 14, 2015 at 6:15 PM, Joel Koshy wrote: > (deviating a bit from the points in the last set of ema

Re: [DISCUSS] Compatability and KIPs

2015-01-14 Thread Joel Koshy
(deviating a bit from the points in the last set of emails) - just wanted to ask if there was any heads-up regarding the change in default partitioning behavior in the new producer. Chris (cc'd) encountered this while upgrading to the new producer - the new producer uses a murmur hash by default (w

[jira] [Commented] (KAFKA-1863) Exception categories / hierarchy in clients

2015-01-14 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278116#comment-14278116 ] Jay Kreps commented on KAFKA-1863: -- Cool, filed KAFKA-1865 > Exception categories / hier

[jira] [Commented] (KAFKA-1863) Exception categories / hierarchy in clients

2015-01-14 Thread Chris Riccomini (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278113#comment-14278113 ] Chris Riccomini commented on KAFKA-1863: [~jkreps], so it sounds like we can fail

[jira] [Created] (KAFKA-1865) Investigate adding a flush() call to new producer API

2015-01-14 Thread Jay Kreps (JIRA)
Jay Kreps created KAFKA-1865: Summary: Investigate adding a flush() call to new producer API Key: KAFKA-1865 URL: https://issues.apache.org/jira/browse/KAFKA-1865 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1863) Exception categories / hierarchy in clients

2015-01-14 Thread Chris Riccomini (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278107#comment-14278107 ] Chris Riccomini commented on KAFKA-1863: bq. It might be nice to add a flush() cal

[jira] [Commented] (KAFKA-1863) Exception categories / hierarchy in clients

2015-01-14 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278104#comment-14278104 ] Jay Kreps commented on KAFKA-1863: -- [~guozhang] Makes sense. You're correct that the docs

[jira] [Updated] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic

2015-01-14 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1852: -- Attachment: KAFKA-1852.patch > OffsetCommitRequest can commit offset on unknown

[jira] [Updated] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic

2015-01-14 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1852: -- Status: Patch Available (was: Open) > OffsetCommitRequest can commit offset on

[jira] [Commented] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic

2015-01-14 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278081#comment-14278081 ] Sriharsha Chintalapani commented on KAFKA-1852: --- Created reviewboard https:/

Review Request 29912: Patch for KAFKA-1852

2015-01-14 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29912/ --- Review request for kafka. Bugs: KAFKA-1852 https://issues.apache.org/jira/b

Re: 0.8.2.0 behavior change: ReplicaNotAvailableError

2015-01-14 Thread Jun Rao
Hi, Dana, Thanks for reporting this. I investigated this a bit more. What you observed is the following: a client getting a partition level error code of ReplicaNotAvailableError in a TopicMetadataResponse when one of replicas is offline. The short story is that that behavior can already happen in

[jira] [Commented] (KAFKA-1863) Exception categories / hierarchy in clients

2015-01-14 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278024#comment-14278024 ] Guozhang Wang commented on KAFKA-1863: -- My original motivation of this ticket is to m

[jira] [Comment Edited] (KAFKA-1863) Exception categories / hierarchy in clients

2015-01-14 Thread Chris Riccomini (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277973#comment-14277973 ] Chris Riccomini edited comment on KAFKA-1863 at 1/15/15 12:39 AM: --

[jira] [Comment Edited] (KAFKA-1863) Exception categories / hierarchy in clients

2015-01-14 Thread Chris Riccomini (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277973#comment-14277973 ] Chris Riccomini edited comment on KAFKA-1863 at 1/15/15 12:38 AM: --

[jira] [Comment Edited] (KAFKA-1863) Exception categories / hierarchy in clients

2015-01-14 Thread Chris Riccomini (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277973#comment-14277973 ] Chris Riccomini edited comment on KAFKA-1863 at 1/15/15 12:30 AM: --

[jira] [Commented] (KAFKA-1863) Exception categories / hierarchy in clients

2015-01-14 Thread Chris Riccomini (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277973#comment-14277973 ] Chris Riccomini commented on KAFKA-1863: Here's how Samza's KafkaSystemProducer cu

Heads up: KAFKA-1697 - remove code related to ack>1 on the broker

2015-01-14 Thread Gwen Shapira
Hi Kafka Devs, We are working on KAFKA-1697 - remove code related to ack>1 on the broker. Per Neha's suggestion, I'd like to give everyone a heads up on what these changes mean. Once this patch is included, any produce requests that include request.required.acks > 1 will result in an exception. T

[jira] [Comment Edited] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

2015-01-14 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277923#comment-14277923 ] Guozhang Wang edited comment on KAFKA-1634 at 1/14/15 11:51 PM:

[jira] [Commented] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

2015-01-14 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277923#comment-14277923 ] Guozhang Wang commented on KAFKA-1634: -- [~jjkoshy][~junrao] My plan is to check in th

[jira] [Updated] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

2015-01-14 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1634: - Attachment: KAFKA-1634_2015-01-14_15:50:15.patch > Improve semantics of timestamp in OffsetCommitR

Re: Review Request 27391: Fix KAFKA-1634

2015-01-14 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27391/ --- (Updated Jan. 14, 2015, 11:50 p.m.) Review request for kafka. Bugs: KAFKA-163

[jira] [Commented] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

2015-01-14 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277918#comment-14277918 ] Guozhang Wang commented on KAFKA-1634: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1697) remove code related to ack>1 on the broker

2015-01-14 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277902#comment-14277902 ] Gwen Shapira commented on KAFKA-1697: - Per [~ewencp]'s suggestion, I added early valid

[jira] [Updated] (KAFKA-1697) remove code related to ack>1 on the broker

2015-01-14 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1697: Attachment: KAFKA-1697_2015-01-14_15:41:37.patch > remove code related to ack>1 on the broker >

[jira] [Commented] (KAFKA-1697) remove code related to ack>1 on the broker

2015-01-14 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277899#comment-14277899 ] Gwen Shapira commented on KAFKA-1697: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 29647: Patch for KAFKA-1697

2015-01-14 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29647/ --- (Updated Jan. 14, 2015, 11:41 p.m.) Review request for kafka. Bugs: KAFKA-169

[jira] [Comment Edited] (KAFKA-1863) Exception categories / hierarchy in clients

2015-01-14 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277885#comment-14277885 ] Jay Kreps edited comment on KAFKA-1863 at 1/14/15 11:33 PM: He

[jira] [Commented] (KAFKA-1863) Exception categories / hierarchy in clients

2015-01-14 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277885#comment-14277885 ] Jay Kreps commented on KAFKA-1863: -- Hey guys, I put some thought into this but I agree it

[jira] [Comment Edited] (KAFKA-1863) Exception categories / hierarchy in clients

2015-01-14 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277885#comment-14277885 ] Jay Kreps edited comment on KAFKA-1863 at 1/14/15 11:31 PM: He

[jira] [Created] (KAFKA-1864) Revisit defaults for the internal offsets topic

2015-01-14 Thread Neha Narkhede (JIRA)
Neha Narkhede created KAFKA-1864: Summary: Revisit defaults for the internal offsets topic Key: KAFKA-1864 URL: https://issues.apache.org/jira/browse/KAFKA-1864 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1863) Exception categories / hierarchy in clients

2015-01-14 Thread Navina Ramesh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277814#comment-14277814 ] Navina Ramesh commented on KAFKA-1863: -- Summarizing the issue we face in Samza: In S

[jira] [Commented] (KAFKA-1649) Protocol documentation does not indicate that ReplicaNotAvailable can be ignored

2015-01-14 Thread Dana Powers (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277807#comment-14277807 ] Dana Powers commented on KAFKA-1649: I am only testing from the wire-protocol level.

[jira] [Commented] (KAFKA-1649) Protocol documentation does not indicate that ReplicaNotAvailable can be ignored

2015-01-14 Thread Hernan Rivas Inaka (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1426#comment-1426 ] Hernan Rivas Inaka commented on KAFKA-1649: --- Edited the wiki. What server side c

0.8.2.0 behavior change: ReplicaNotAvailableError

2015-01-14 Thread Dana Powers
Overall the 0.8.2.0 release candidate looks really good. All of the kafka-python integration tests pass as they do w/ prior servers, except one... When testing recovery from a broker failure / leader switch, we now see a ReplicaNotAvailableError in broker metadata / PartitionMetadata, which we do

[jira] [Commented] (KAFKA-1649) Protocol documentation does not indicate that ReplicaNotAvailable can be ignored

2015-01-14 Thread Dana Powers (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277690#comment-14277690 ] Dana Powers commented on KAFKA-1649: I think this could be a problem -- it is not upda

[jira] [Commented] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-14 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277582#comment-14277582 ] Jun Rao commented on KAFKA-1723: [~omkreddy], thanks for the delta patch. Since this is no

[jira] [Commented] (KAFKA-1861) Publishing kafka-client:test in order to utilize the helper utils in TestUtils

2015-01-14 Thread Navina Ramesh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277580#comment-14277580 ] Navina Ramesh commented on KAFKA-1861: -- [~jkreps] : That should be ok, I guess. Samza

Re: Review Request 29523: Patch for KAFKA-1723

2015-01-14 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29523/#review68110 --- Ship it! - Jun Rao On Jan. 14, 2015, 8:02 a.m., Manikumar Reddy O

[jira] [Resolved] (KAFKA-1859) Can`t run kafka vagrant images on Windows 7

2015-01-14 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava resolved KAFKA-1859. -- Resolution: Won't Fix Assignee: Ewen Cheslack-Postava > Can`t run kafka va

Re: Review Request 29210: Patch for KAFKA-1819

2015-01-14 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/#review68107 --- A couple of minor comments. Neither of these is a blocker for 0.8.2.

Re: Review Request 27391: Fix KAFKA-1634

2015-01-14 Thread Guozhang Wang
> On Jan. 8, 2015, 2:24 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java, > > lines 79-85 > > > > > > Perhaps these code can just be changed to > > > >

[jira] [Updated] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-14 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Singh updated KAFKA-1856: -- Status: Patch Available (was: Open) > Add PreCommit Patch Testing > ---

[jira] [Updated] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-14 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Singh updated KAFKA-1856: -- Attachment: KAFKA-1856.patch > Add PreCommit Patch Testing > ---

[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-14 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277518#comment-14277518 ] Ashish Kumar Singh commented on KAFKA-1856: --- RB: https://reviews.apache.org/r/29

[jira] [Updated] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-14 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Singh updated KAFKA-1856: -- Description: h1. Kafka PreCommit Patch Testing - *Don't wait for it to break* h2. Motiv

Review Request 29893: KAFKA-1856: Add PreCommit Patch Testing

2015-01-14 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29893/ --- Review request for kafka. Bugs: KAFKA-1856 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-1863) Exception categories / hierarchy in clients

2015-01-14 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1863: Summary: Exception categories / hierarchy in clients Key: KAFKA-1863 URL: https://issues.apache.org/jira/browse/KAFKA-1863 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1664) Kafka does not properly parse multiple ZK nodes with non-root chroot

2015-01-14 Thread Ashish Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277439#comment-14277439 ] Ashish Kumar Singh commented on KAFKA-1664: --- Testing file [KAFKA-1664.2.patch|h

[jira] [Commented] (KAFKA-768) broker should exit if hitting exceptions durin startup

2015-01-14 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277430#comment-14277430 ] Guozhang Wang commented on KAFKA-768: - We encountered a general deaklock issue with Sys

[jira] [Assigned] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic

2015-01-14 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani reassigned KAFKA-1852: - Assignee: Sriharsha Chintalapani > OffsetCommitRequest can commit offset

[jira] [Commented] (KAFKA-1861) Publishing kafka-client:test in order to utilize the helper utils in TestUtils

2015-01-14 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277271#comment-14277271 ] Jay Kreps commented on KAFKA-1861: -- Hey [~navina] we can definitely publish the jar but i

Re: [VOTE] 0.8.2.0 Candidate 1

2015-01-14 Thread Jun Rao
+ users mailing list. It would be great if people can test this out and report any blocker issues. Thanks, Jun On Tue, Jan 13, 2015 at 7:16 PM, Jun Rao wrote: > This is the first candidate for release of Apache Kafka 0.8.2.0. There > has been some changes since the 0.8.2 beta release, especial

[jira] [Updated] (KAFKA-1694) kafka command line and centralized operations

2015-01-14 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-1694: Attachment: KAFKA-1694_2015-01-14_18:07:39.patch > kafka command line and centralized operat

[jira] [Commented] (KAFKA-1694) kafka command line and centralized operations

2015-01-14 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277126#comment-14277126 ] Andrii Biletskyi commented on KAFKA-1694: - Updated reviewboard https://reviews.apa

Re: Review Request 29301: Patch for KAFKA-1694

2015-01-14 Thread Andrii Biletskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29301/ --- (Updated Jan. 14, 2015, 4:07 p.m.) Review request for kafka. Bugs: KAFKA-1694

[jira] [Commented] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-14 Thread Vladimir Tretyakov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276944#comment-14276944 ] Vladimir Tretyakov commented on KAFKA-1723: --- Hi, sorry for delay, but maybe poss

[jira] [Commented] (KAFKA-1694) kafka command line and centralized operations

2015-01-14 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276910#comment-14276910 ] Andrii Biletskyi commented on KAFKA-1694: - Updated reviewboard https://reviews.apa

[jira] [Updated] (KAFKA-1694) kafka command line and centralized operations

2015-01-14 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-1694: Attachment: KAFKA-1694_2015-01-14_15:42:12.patch > kafka command line and centralized operat

Re: Review Request 29301: Patch for KAFKA-1694

2015-01-14 Thread Andrii Biletskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29301/ --- (Updated Jan. 14, 2015, 1:42 p.m.) Review request for kafka. Bugs: KAFKA-1694

[jira] [Updated] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

2015-01-14 Thread Dmitry Pekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Pekar updated KAFKA-1792: Attachment: rebalance_use_cases.txt [~nehanarkhede], [~charmalloc] Attached use cases for ReassignP

[jira] [Comment Edited] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

2015-01-14 Thread Dmitry Pekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276782#comment-14276782 ] Dmitry Pekar edited comment on KAFKA-1792 at 1/14/15 10:57 AM: -

[jira] [Updated] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

2015-01-14 Thread Dmitry Pekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Pekar updated KAFKA-1792: Attachment: KAFKA-1792_2015-01-14_12:54:52.patch > change behavior of --generate to produce assignme

[jira] [Commented] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

2015-01-14 Thread Dmitry Pekar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276782#comment-14276782 ] Dmitry Pekar commented on KAFKA-1792: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 28481: Patch for KAFKA-1792

2015-01-14 Thread Dmitry Pekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28481/ --- (Updated Jan. 14, 2015, 10:55 a.m.) Review request for kafka. Bugs: KAFKA-179

[jira] [Resolved] (KAFKA-1022) Double quotes in Domain name & Topic name

2015-01-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy resolved KAFKA-1022. Resolution: Not a Problem Fix Version/s: 0.8.2 Assignee: Manikumar Reddy O.8

[jira] [Commented] (KAFKA-1859) Can`t run kafka vagrant images on Windows 7

2015-01-14 Thread Aleksey Ponkin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276654#comment-14276654 ] Aleksey Ponkin commented on KAFKA-1859: --- I think you are right. This is vagrant`s is

[jira] [Commented] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276629#comment-14276629 ] Manikumar Reddy commented on KAFKA-1723: Updated reviewboard https://reviews.apach

[jira] [Updated] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1723: --- Attachment: KAFKA-1723_2015-01-14_13:30:39.patch > make the metrics name in new producer more

Re: Review Request 29523: Patch for KAFKA-1723

2015-01-14 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29523/ --- (Updated Jan. 14, 2015, 8:02 a.m.) Review request for kafka. Bugs: KAFKA-1723