[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-28 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187960#comment-14187960 ] Jun Rao commented on KAFKA-1583: [~jjkoshy], you can commit the patch once you are done wi

[jira] [Commented] (KAFKA-1736) Improve parition-broker assignment strategy for better availaility in majority durability modes

2014-10-28 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187701#comment-14187701 ] Jay Kreps commented on KAFKA-1736: -- Yes, this is correct. This is a common tradeoff in th

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-28 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187571#comment-14187571 ] Guozhang Wang commented on KAFKA-1583: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1583) Kafka API Refactoring

2014-10-28 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1583: - Attachment: KAFKA-1583_2014-10-28_15:09:30.patch > Kafka API Refactoring > - >

Re: Review Request 24676: Fix KAFKA-1583

2014-10-28 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- (Updated Oct. 28, 2014, 10:09 p.m.) Review request for kafka. Bugs: KAFKA-158

Re: Review Request 24676: Fix KAFKA-1583

2014-10-28 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/#review58865 --- Ship it! Looks good - just minor comments which we can fix on check

Re: Review Request 24676: Fix KAFKA-1583

2014-10-28 Thread Joel Koshy
> On Oct. 22, 2014, 1:46 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 120 > > > > > > (for regular consumer fetch) > > Guozhang Wang wrote: > Actually this is for both c

[jira] [Updated] (KAFKA-1736) Improve parition-broker assignment strategy for better availaility in majority durability modes

2014-10-28 Thread Kyle Banker (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyle Banker updated KAFKA-1736: --- Description: The current random strategy of partition-to-broker distribution combined with a fairly t

[jira] [Created] (KAFKA-1736) Improve parition-broker assignment strategy for better availaility in majority durability modes

2014-10-28 Thread Kyle Banker (JIRA)
Kyle Banker created KAFKA-1736: -- Summary: Improve parition-broker assignment strategy for better availaility in majority durability modes Key: KAFKA-1736 URL: https://issues.apache.org/jira/browse/KAFKA-1736

Re: High Level Consumer and Close with Auto Commit On

2014-10-28 Thread Gwen Shapira
High level consumer commits before shutting down. If you'll look at ZookeeperConsumerConnector.scala (currently the only implementation of ConsumerConnector) you'll see shutdown() includes the following: if (config.autoCommitEnable) commitOffsets() Gwen On Tue, Oct 28, 201

High Level Consumer and Close with Auto Commit On

2014-10-28 Thread Bhavesh Mistry
Hi Kafka Team, What is expected behavior when you close *ConsumerConnector* and auto commit is on ? Basically, when auto commit interval is set to 5 seconds and shutdown is called (before 5 seconds elapses) does ConsumerConnector commit the offset of message consumed by (next()) method or consume

[jira] [Commented] (KAFKA-1710) [New Java Producer Potential Deadlock] Producer Deadlock when all messages is being sent to single partition

2014-10-28 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187255#comment-14187255 ] Jay Kreps commented on KAFKA-1710: -- I think the old producer did the compression in the b

Re: Review Request 26373: Patch for KAFKA-1647

2014-10-28 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26373/#review58846 --- Ship it! core/src/main/scala/kafka/server/ReplicaManager.scala

Re: Review Request 26755: Patch for KAFKA-1706

2014-10-28 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26755/#review58831 --- Can we add a unit test as well? - Joel Koshy On Oct. 28, 2014, 1:

Re: Review Request 26885: Patch for KAFKA-1642

2014-10-28 Thread Guozhang Wang
> On Oct. 27, 2014, 12:13 a.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/NetworkClient.java, line 122 > > > > > > The comments "When connecting or connected, this handles slow/stalled >

[jira] [Commented] (KAFKA-1638) transient unit test failure UncleanLeaderElectionTest

2014-10-28 Thread JIRA
[ https://issues.apache.org/jira/browse/KAFKA-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187138#comment-14187138 ] Renato Javier Marroquín Mogrovejo commented on KAFKA-1638: -- Hi,

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

2014-10-28 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187118#comment-14187118 ] Joel Koshy commented on KAFKA-1583: --- Thanks for the updated patch. I will do this today.

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

2014-10-28 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187104#comment-14187104 ] Guozhang Wang commented on KAFKA-1501: -- Ouch... Could you share the stack trace on so

Re: Review Request 27256: Fix KAFKA-1735

2014-10-28 Thread Guozhang Wang
> On Oct. 28, 2014, 1:17 a.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java, > > line 207 > > > > > > Would it be possible to add a unit test for this? Sure. This s

Setting up Kafka and Intellij

2014-10-28 Thread Renato Marroquín Mogrovejo
Hi guys, I have struggling through the day to set Kafka trunk into Intellij. I mean I can get the code by running ./gradlew idea, and then opening the project. But I am trying to actually run the tests from inside Intellij but I have many dependency problems, and I guess adding the whole .m2 repo

[jira] [Commented] (KAFKA-1721) Snappy compressor is not thread safe

2014-10-28 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187033#comment-14187033 ] Ewen Cheslack-Postava commented on KAFKA-1721: -- Updated reviewboard https://r

[jira] [Updated] (KAFKA-1721) Snappy compressor is not thread safe

2014-10-28 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1721: - Attachment: KAFKA-1721_2014-10-28_09:25:50.patch > Snappy compressor is not thread

Re: Review Request 27124: Patch for KAFKA-1721

2014-10-28 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27124/ --- (Updated Oct. 28, 2014, 4:25 p.m.) Review request for kafka. Bugs: KAFKA-1721

Re: [ANNOUNCEMENT] Apache Kafka 0.8.2-beta Released

2014-10-28 Thread Joe Stein
I heard back from INFRA already. Here is what they said. "This issue is already addressed in a different JIRA ticket. We expect to resolve this ongoing issue within a few weeks. In the meantime, please expect delays on deploying changes to your web site." /

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

2014-10-28 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186879#comment-14186879 ] Jay Kreps commented on KAFKA-1501: -- It might be worth checking out that stack overflow ar

Re: [ANNOUNCEMENT] Apache Kafka 0.8.2-beta Released

2014-10-28 Thread Joe Stein
I am going to open a ticket with INFRA because I don't think it is a local cache issue. I get different results when I go to the page in different browsers on different computers, it is weird. /*** Joe Stein Founder, Principal Consultant Big Data Open Sou

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

2014-10-28 Thread Chris Cope (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186564#comment-14186564 ] Chris Cope commented on KAFKA-1501: --- 14/200 test runs failed with the "java.net.BindExce