> On Oct. 28, 2014, 1:17 a.m., Neha Narkhede wrote: > > clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java, > > line 207 > > <https://reviews.apache.org/r/27256/diff/1/?file=734746#file734746line207> > > > > Would it be possible to add a unit test for this?
Sure. This scenario is covered for the old consumer in ZookeeperConsumerCompressionTest, and I originally plan to migrate to the new consumer unit test in the future; thinking it twice I now feel better to add it to the MemoryRecordsTest. - Guozhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27256/#review58744 ----------------------------------------------------------- On Oct. 27, 2014, 11:59 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27256/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 11:59 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1735 > https://issues.apache.org/jira/browse/KAFKA-1735 > > > Repository: kafka > > > Description > ------- > > Handle partial reads from compressed stream > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java > 040e5b91005edb8f015afdfa76fd94e0bf3cb4ca > > Diff: https://reviews.apache.org/r/27256/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
