[jira] [Commented] (KAFKA-1489) Global threshold on data retention size

2014-08-22 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107867#comment-14107867 ] Jay Kreps commented on KAFKA-1489: -- Max utilization percent would be ideal but Java doesn

[jira] [Commented] (KAFKA-1489) Global threshold on data retention size

2014-08-22 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107858#comment-14107858 ] Steven Zhen Wu commented on KAFKA-1489: --- Jay, agree that a simple cross-the-board dr

[jira] [Commented] (KAFKA-1489) Global threshold on data retention size

2014-08-22 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107844#comment-14107844 ] Jay Kreps commented on KAFKA-1489: -- I agree I think generally it makes most sense to cons

Build failed in Jenkins: Kafka-trunk #254

2014-08-22 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1609; New producer metadata response handling should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE; patched by Dong Lin; reviewed by Jun Rao -- [...

[jira] [Updated] (KAFKA-1609) New producer metadata response handling should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1609: --- Resolution: Fixed Fix Version/s: 0.8.2 Status: Resolved (was: Patch Available) Thanks for

[jira] [Created] (KAFKA-1610) map v.s. mapValues in Scala

2014-08-22 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1610: Summary: map v.s. mapValues in Scala Key: KAFKA-1610 URL: https://issues.apache.org/jira/browse/KAFKA-1610 Project: Kafka Issue Type: Bug Reporte

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
> On Aug. 22, 2014, 10:39 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java, > > line 121 > > > > > > Would it be simpler to just don't do the test on partError? The

[jira] [Commented] (KAFKA-1609) New producer metadata response handling should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107690#comment-14107690 ] Dong Lin commented on KAFKA-1609: - Updated reviewboard https://reviews.apache.org/r/24992/

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24992/ --- (Updated Aug. 22, 2014, 11:22 p.m.) Review request for kafka. Bugs: KAFKA-160

[jira] [Updated] (KAFKA-1609) New producer metadata response handling should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1609: Attachment: KAFKA-1609_2014-08-22_16:22:00.patch > New producer metadata response handling should only excl

[jira] [Assigned] (KAFKA-1070) Auto-assign node id

2014-08-22 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede reassigned KAFKA-1070: Assignee: Jay Kreps (was: Sriharsha Chintalapani) > Auto-assign node id >

[jira] [Commented] (KAFKA-1070) Auto-assign node id

2014-08-22 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107682#comment-14107682 ] Neha Narkhede commented on KAFKA-1070: -- In an attempt to keep up with reviews, assign

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24992/#review51327 --- clients/src/main/java/org/apache/kafka/common/requests/MetadataResp

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24992/#review51325 --- Ship it! Ship It! - Guozhang Wang On Aug. 22, 2014, 8:04 p.m., D

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
> On Aug. 22, 2014, 8:50 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java, > > line 121 > > > > > > Is this possilbe that the reponse can also contain other e

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
> On Aug. 22, 2014, 8:56 p.m., Joel Koshy wrote: > > clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java, > > line 121 > > > > > > Guozhang, an unknown topic would be captured at the topic-err

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24992/#review51317 --- clients/src/main/java/org/apache/kafka/common/requests/MetadataResp

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24992/#review51316 --- clients/src/main/java/org/apache/kafka/common/requests/MetadataResp

[jira] [Updated] (KAFKA-1609) New producer metadata response handling should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1609: Attachment: KAFKA-1609_2014-08-22_13:04:10.patch > New producer metadata response handling should only excl

[jira] [Commented] (KAFKA-1609) New producer metadata response handling should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107402#comment-14107402 ] Dong Lin commented on KAFKA-1609: - Updated reviewboard https://reviews.apache.org/r/24992/

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24992/ --- (Updated Aug. 22, 2014, 8:04 p.m.) Review request for kafka. Bugs: KAFKA-1609

Re: Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24992/ --- (Updated Aug. 22, 2014, 8:02 p.m.) Review request for kafka. Bugs: KAFKA-1609

[jira] [Updated] (KAFKA-1609) Metadata response should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1609: Status: Patch Available (was: Open) > Metadata response should only exclude a PartitionInfo when its error

[jira] [Commented] (KAFKA-1609) Metadata response should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107390#comment-14107390 ] Dong Lin commented on KAFKA-1609: - Created reviewboard https://reviews.apache.org/r/24992/

[jira] [Updated] (KAFKA-1609) New producer metadata response handling should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1609: -- Summary: New producer metadata response handling should only exclude a PartitionInfo when its error is

[jira] [Updated] (KAFKA-1609) Metadata response should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1609: Attachment: KAFKA-1609.patch > Metadata response should only exclude a PartitionInfo when its error is > L

Review Request 24992: Patch for KAFKA-1609

2014-08-22 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24992/ --- Review request for kafka. Bugs: KAFKA-1609 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-1609) Metadata response should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE

2014-08-22 Thread Dong Lin (JIRA)
Dong Lin created KAFKA-1609: --- Summary: Metadata response should only exclude a PartitionInfo when its error is LEADER_NOT_AVAILABLE Key: KAFKA-1609 URL: https://issues.apache.org/jira/browse/KAFKA-1609 Proj

[jira] [Commented] (KAFKA-1600) Controller failover not working correctly.

2014-08-22 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107267#comment-14107267 ] Guozhang Wang commented on KAFKA-1600: -- Haifeng, I looked into the controller and br

Re: Review Request 24621: Patch for KAFKA-1507

2014-08-22 Thread Sriharsha Chintalapani
> On Aug. 13, 2014, 11:13 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 454 > > > > > > we cannot have metadata request handling access zookeeper. In the past, > > we've gotten

[jira] [Commented] (KAFKA-1507) Using GetOffsetShell against non-existent topic creates the topic unintentionally

2014-08-22 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107213#comment-14107213 ] Sriharsha Chintalapani commented on KAFKA-1507: --- Updated reviewboard https:/

[jira] [Updated] (KAFKA-1507) Using GetOffsetShell against non-existent topic creates the topic unintentionally

2014-08-22 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1507: -- Attachment: KAFKA-1507_2014-08-22_11:08:51.patch > Using GetOffsetShell against

Re: Review Request 24621: Patch for KAFKA-1507

2014-08-22 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24621/ --- (Updated Aug. 22, 2014, 6:08 p.m.) Review request for kafka. Bugs: KAFKA-1507

[jira] [Commented] (KAFKA-1507) Using GetOffsetShell against non-existent topic creates the topic unintentionally

2014-08-22 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107211#comment-14107211 ] Sriharsha Chintalapani commented on KAFKA-1507: --- Updated reviewboard https:/

[jira] [Updated] (KAFKA-1507) Using GetOffsetShell against non-existent topic creates the topic unintentionally

2014-08-22 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1507: -- Attachment: KAFKA-1507_2014-08-22_11:06:38.patch > Using GetOffsetShell against

[jira] [Updated] (KAFKA-1507) Using GetOffsetShell against non-existent topic creates the topic unintentionally

2014-08-22 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1507: -- Assignee: Sriharsha Chintalapani (was: Jay Kreps) Status: Patch Available

Re: Review Request 24621: Patch for KAFKA-1507

2014-08-22 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24621/ --- (Updated Aug. 22, 2014, 6:06 p.m.) Review request for kafka. Bugs: KAFKA-1507

[jira] [Commented] (KAFKA-1486) Move all request/responses to use schema-utils

2014-08-22 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107177#comment-14107177 ] Guozhang Wang commented on KAFKA-1486: -- That is right. > Move all request/responses

[jira] [Commented] (KAFKA-1486) Move all request/responses to use schema-utils

2014-08-22 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107167#comment-14107167 ] Gwen Shapira commented on KAFKA-1486: - Thanks [~guozhang]. If I understand you (and t

[jira] [Commented] (KAFKA-1485) Upgrade to Zookeeper 3.4.6 and create "shim" for ZKCLI so system tests can run

2014-08-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107090#comment-14107090 ] Joe Stein commented on KAFKA-1485: -- >From the community perspective I don't want us to ha

[jira] [Commented] (KAFKA-1489) Global threshold on data retention size

2014-08-22 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107065#comment-14107065 ] Steven Zhen Wu commented on KAFKA-1489: --- [~jimhoagland] thanks for the clarification

Re: Review Request 23655: Patch for KAFKA-687

2014-08-22 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23655/#review51182 --- core/src/main/scala/kafka/consumer/PartitionAssignor.scala

[jira] [Commented] (KAFKA-1489) Global threshold on data retention size

2014-08-22 Thread Jim Hoagland (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106996#comment-14106996 ] Jim Hoagland commented on KAFKA-1489: - Steven, you can list more than one directory un

[jira] [Commented] (KAFKA-1486) Move all request/responses to use schema-utils

2014-08-22 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106963#comment-14106963 ] Guozhang Wang commented on KAFKA-1486: -- Hi Gwen, In KAFKA-1462 what we have decided

[jira] [Commented] (KAFKA-1548) Refactor the "replica_id" in requests

2014-08-22 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106955#comment-14106955 ] Guozhang Wang commented on KAFKA-1548: -- Hi Gwen, I kind of agree that for now maybe

[jira] [Updated] (KAFKA-1282) Disconnect idle socket connection in Selector

2014-08-22 Thread Nicolae Marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolae Marasoiu updated KAFKA-1282: Attachment: KAFKA-1282_Disconnect_idle_socket_connection_in_Selector.patch > Disconnect idl

[jira] [Updated] (KAFKA-1438) Migrate kafka client tools

2014-08-22 Thread Stevo Slavic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stevo Slavic updated KAFKA-1438: Attachment: KAFKA-1438-windows_bat.patch Attached [^KAFKA-1438-windows_bat.patch] which fixes windo

[jira] [Commented] (KAFKA-1438) Migrate kafka client tools

2014-08-22 Thread Stevo Slavic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106864#comment-14106864 ] Stevo Slavic commented on KAFKA-1438: - Windows batch scripts, {{kafka-console-consumer

Re: Which is better?

2014-08-22 Thread pankaj ojha
Thank You Philip for helping me out in this. Thanks, Pankaj On Wed, Aug 20, 2014 at 9:54 PM, Philip O'Toole < philip.oto...@yahoo.com.invalid> wrote: > If you have studied the docs yet, you should, as this is a broad question > which needs background to understand the answer. > > But in summary

[jira] [Commented] (KAFKA-1607) Use of String format method in debug statements

2014-08-22 Thread Marko Milenkovic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106648#comment-14106648 ] Marko Milenkovic commented on KAFKA-1607: - [~guozhang] I can confirm that the issu

[jira] [Commented] (KAFKA-1489) Global threshold on data retention size

2014-08-22 Thread Andras Sereny (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106584#comment-14106584 ] Andras Sereny commented on KAFKA-1489: -- That's exactly right Jay, I've amended the de

[jira] [Updated] (KAFKA-1489) Global threshold on data retention size

2014-08-22 Thread Andras Sereny (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Sereny updated KAFKA-1489: - Description: Currently, Kafka has per topic settings to control the size of one single log (log.