[jira] [Commented] (KAFKA-1472) Add the compression ratio metrics in the new producer

2014-06-05 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019600#comment-14019600 ] Dong Lin commented on KAFKA-1472: - Updated reviewboard https://reviews.apache.org/r/22063/

Re: Review Request 22063: Patch for KAFKA-1472

2014-06-05 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22063/ --- (Updated June 6, 2014, 5:42 a.m.) Review request for kafka. Bugs: KAFKA-1472

[jira] [Updated] (KAFKA-1472) Add the compression ratio metrics in the new producer

2014-06-05 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1472: Attachment: KAFKA-1472_2014-06-05_22:42:23.patch > Add the compression ratio metrics in the new producer >

[jira] [Issue Comment Deleted] (KAFKA-1443) Add delete topic to topic commands and update DeleteTopicCommand

2014-06-05 Thread Qian Xu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qian Xu updated KAFKA-1443: --- Comment: was deleted (was: Is it safe to delete a topic, while a producer is actively producing logs to that

[jira] [Comment Edited] (KAFKA-1443) Add delete topic to topic commands and update DeleteTopicCommand

2014-06-05 Thread Qian Xu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019532#comment-14019532 ] Qian Xu edited comment on KAFKA-1443 at 6/6/14 3:23 AM: Is it safe

Re: Review Request 21937: Patch for KAFKA-1316

2014-06-05 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21937/#review44850 --- Good to see this patch. Looks great, I have few minor review comment

[jira] [Commented] (KAFKA-1443) Add delete topic to topic commands and update DeleteTopicCommand

2014-06-05 Thread Qian Xu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019532#comment-14019532 ] Qian Xu commented on KAFKA-1443: Is it safe to delete a topic while some producer is activ

[jira] [Comment Edited] (KAFKA-1443) Add delete topic to topic commands and update DeleteTopicCommand

2014-06-05 Thread Qian Xu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019532#comment-14019532 ] Qian Xu edited comment on KAFKA-1443 at 6/6/14 3:15 AM: Is it safe

Re: Review Request 21588: Fix KAFKA-1430, round two

2014-06-05 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21588/ --- (Updated June 6, 2014, 12:41 a.m.) Review request for kafka. Bugs: KAFKA-1430

[jira] [Commented] (KAFKA-1430) Purgatory redesign

2014-06-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019461#comment-14019461 ] Guozhang Wang commented on KAFKA-1430: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 21588: Fix KAFKA-1430, round two

2014-06-05 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21588/ --- (Updated June 6, 2014, 12:40 a.m.) Review request for kafka. Bugs: KAFKA-1430

[jira] [Updated] (KAFKA-1430) Purgatory redesign

2014-06-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1430: - Attachment: KAFKA-1430_2014-06-05_17:40:53.patch > Purgatory redesign > -- > >

Re: Review Request 21588: Fix KAFKA-1430, round two

2014-06-05 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21588/ --- (Updated June 6, 2014, 12:37 a.m.) Review request for kafka. Bugs: KAFKA-1430

[jira] [Updated] (KAFKA-1430) Purgatory redesign

2014-06-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1430: - Attachment: KAFKA-1430_2014-06-05_17:13:13.patch > Purgatory redesign > -- > >

[jira] [Commented] (KAFKA-1430) Purgatory redesign

2014-06-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019438#comment-14019438 ] Guozhang Wang commented on KAFKA-1430: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 21588: Fix KAFKA-1430, round two

2014-06-05 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21588/ --- (Updated June 6, 2014, 12:13 a.m.) Review request for kafka. Bugs: KAFKA-1430

[jira] [Commented] (KAFKA-1430) Purgatory redesign

2014-06-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019436#comment-14019436 ] Guozhang Wang commented on KAFKA-1430: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 21588: Fix KAFKA-1430, round two

2014-06-05 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21588/ --- (Updated June 6, 2014, 12:07 a.m.) Review request for kafka. Summary (updated

[jira] [Updated] (KAFKA-1430) Purgatory redesign

2014-06-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1430: - Attachment: KAFKA-1430_2014-06-05_17:07:37.patch > Purgatory redesign > -- > >

Re: [DISCUSS] Kafka Security Specific Features

2014-06-05 Thread Todd Palino
My concern is specifically around the rules for SOX compliance, or rules around PII, PCI, or HIPAA compliance. The audits get very complication, but my understanding is that the general rule is that sensitive data should be encrypted at rest and only decrypted when needed. And we don¹t just need to

Re: Review Request 22131: Patch for KAFKA-1477

2014-06-05 Thread Rajasekar Elango
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22131/#review44855 --- Looks like change to UpdateOffsetsInZK.scala (https://github.com/re

Re: [DISCUSS] Kafka Security Specific Features

2014-06-05 Thread Jay Kreps
Hey Todd, Can you elaborate on this? Certainly restricting access to and modification of data is important. But this doesn't imply storing the data encrypted. Are we assuming the attacker can (1) get on the network, (2) get on the kafka server as a non-root and non-kafka user or (3) get root on th

[jira] [Commented] (KAFKA-824) java.lang.NullPointerException in commitOffsets

2014-06-05 Thread Andrew Olson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019291#comment-14019291 ] Andrew Olson commented on KAFKA-824: Here's another example stack trace that we have se

Re: Review Request 21272: Patch for KAFKA-1443

2014-06-05 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21272/#review44851 --- I removed the DeleteTopicCommand from my latest patch now. - Timoth

[jira] [Commented] (KAFKA-824) java.lang.NullPointerException in commitOffsets

2014-06-05 Thread Andrew Olson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019284#comment-14019284 ] Andrew Olson commented on KAFKA-824: We are seeing a similar NPE in our application's d

Re: [DISCUSS] Kafka Security Specific Features

2014-06-05 Thread Todd Palino
No, at-rest encryption is definitely important. When you start talking about data that is used for financial reporting, restricting access to it (both modification and visibility) is a critical component. -Todd On 6/5/14, 2:01 PM, "Jay Kreps" wrote: >Hey Joe, > >I don't really understand the s

Re: [DISCUSS] Kafka Security Specific Features

2014-06-05 Thread Jay Kreps
Hey Joe, I don't really understand the sections you added to the wiki. Can you clarify them? Is non-repudiation what SASL would call integrity checks? If so don't SSL and and many of the SASL schemes already support this as well as on-the-wire encryption? Or are you proposing an on-disk encrypti

[jira] Subscription: outstanding kafka patches

2014-06-05 Thread jira
Issue Subscription Filter: outstanding kafka patches (95 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1477 add authentication layer and initial JKS x509 implementation for brokers, producers and consumer for network communication

Re: Review Request 22063: Patch for KAFKA-1472

2014-06-05 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22063/ --- (Updated June 5, 2014, 5:14 p.m.) Review request for kafka. Bugs: KAFKA-1472

Re: Review Request 22063: Patch for KAFKA-1472

2014-06-05 Thread Dong Lin
> On June 5, 2014, 4:19 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, > > lines 858-862 > > > > > > Could we add a global compression-rate metric too? > > Sur

Re: [DISCUSS] Kafka Security Specific Features

2014-06-05 Thread Rajasekar Elango
Hi Jay, Thanks for putting together a spec for security. Joe, Looks "Securing zookeeper.." part has been deleted from assumptions section. communication with zookeeper need to be secured as well to make entire kafka cluster secure. It may or may not require changes to kafka. But it's good to hav

Re: Review Request 22063: Patch for KAFKA-1472

2014-06-05 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22063/#review44818 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

Re: [DISCUSS] Kafka Security Specific Features

2014-06-05 Thread Joe Stein
Raja, you need to sign an ICLA http://www.apache.org/licenses/icla.txt once that is on file your user can get permed to contribute. I think securing communication to "offset & broker management source" which can be a zookeeper implementation is important. I will elaborate more on that with the ot

Re: Review Request 21899: Patch for KAFKA-1382

2014-06-05 Thread Sriharsha Chintalapani
> On June 5, 2014, 5:30 a.m., Neha Narkhede wrote: > > This looks great overall. However, something that I missed on my last > > review that I think is important - could we add unit tests using the > > checker for conditionalUpdatePersistentPath? I understand that reproducing > > the actual pr

Re: camel-kafka component review

2014-06-05 Thread Ioannis Polyzos
Hi Neha, You are more than welcome. It is a pleasure to know my contributions are of value :D There are a few points missing in the current work but I plan to continue towards improving the component. Any comment, suggestion, proposal tec would be more than welcome. kind regards, *Ioannis Po