[jira] [Commented] (KAFKA-1423) Updating partition count clears topic configuration and any further alters done to a topics config do not stick

[ https://issues.apache.org/jira/browse/KAFKA-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980669#comment-13980669 ] Nathan Brown commented on KAFKA-1423: - If I wait about a minute or so the config repor

[jira] [Updated] (KAFKA-1423) Updating partition count clears topic configuration and any further alters done to a topics config do not stick

[ https://issues.apache.org/jira/browse/KAFKA-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Brown updated KAFKA-1423: Description: After creating a topic with custom retention configs, I tried to change the number of

[jira] [Created] (KAFKA-1423) Updating partition count clears topic configuration and any further alters done to a topics config do not stick

Nathan Brown created KAFKA-1423: --- Summary: Updating partition count clears topic configuration and any further alters done to a topics config do not stick Key: KAFKA-1423 URL: https://issues.apache.org/jira/browse/K

[jira] [Commented] (KAFKA-1417) Very slow initial high-level consumer startup in low traffic/blocking fetch scenario

[ https://issues.apache.org/jira/browse/KAFKA-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980651#comment-13980651 ] Sam Meder commented on KAFKA-1417: -- It should, let me take a look at the 0.8.1 code. > V

Re: Review Request 20240: Follow-up KAFKA-1352: Standardize stack trace printing in logs

> On April 24, 2014, 6:53 p.m., Joel Koshy wrote: > > Here are my initial thoughts on the conventions (and for this kind of RB - > > i.e., which affects our coding conventions it would be great to have as many > > opinions as possible). > > > > - Single line log seems reasonable. The exception f

Re: Review Request 20616: Fix KAFKA-1409: Address Jun's comments round three

> On April 24, 2014, 12:44 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/log/Log.scala, lines 275-276 > > > > > > We probably should use validMessages here. > > Guozhang Wang wrote: > I actually thought about

[jira] [Commented] (KAFKA-1417) Very slow initial high-level consumer startup in low traffic/blocking fetch scenario

[ https://issues.apache.org/jira/browse/KAFKA-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980590#comment-13980590 ] Guozhang Wang commented on KAFKA-1417: -- In 0.8.1, the leader finder thread would not

[jira] [Updated] (KAFKA-1392) all TestUtiles.waitUntilTrue() should throw an exception if the return value is false

[ https://issues.apache.org/jira/browse/KAFKA-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1392: --- Attachment: KAFKA-1392_2014-04-24_17:59:25.patch > all TestUtiles.waitUntilTrue() should throw an exception i

[jira] [Commented] (KAFKA-1392) all TestUtiles.waitUntilTrue() should throw an exception if the return value is false

[ https://issues.apache.org/jira/browse/KAFKA-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980573#comment-13980573 ] Jun Rao commented on KAFKA-1392: Updated reviewboard https://reviews.apache.org/r/20695/

Re: Review Request 20695: Patch for KAFKA-1392

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20695/ --- (Updated April 25, 2014, 12:59 a.m.) Review request for kafka. Bugs: KAFKA-13

Re: [VOTE] Apache Kafka 0.8.1.1 Release Candidate 1

+1 (Non-binding). Tim On Thu, Apr 24, 2014 at 5:32 PM, Joel Koshy wrote: > +1 > > One (non-critical) issue is that I think our packaging isn't complete > for kafka-perf (we are only building for 2.8.0). > > On Tue, Apr 22, 2014 at 07:18:38PM -0400, Joe Stein wrote: >> This is the first candidate

Build failed in Jenkins: Kafka-trunk #173

See Changes: [junrao] kafka-1418; transient unit test failure in ProducerFailureHandlingTest; patched by Jun Rao; reviewed by Guozhang Wang and Joel Koshy -- [...truncated 723 lines...] kafka.log.L

Re: [VOTE] Apache Kafka 0.8.1.1 Release Candidate 1

+1 One (non-critical) issue is that I think our packaging isn't complete for kafka-perf (we are only building for 2.8.0). On Tue, Apr 22, 2014 at 07:18:38PM -0400, Joe Stein wrote: > This is the first candidate for release of Apache Kafka 0.8.1.1 > > Release Notes for the 0.8.1.1 release > https

Re: Review Request 20616: Fix KAFKA-1409: Address Jun's comments round three

> On April 25, 2014, 12:24 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/log/Log.scala, line 275 > > > > > > Can we compute messages.sizeInBytes just once instead of twice? messages.sizeInBytes just calls b

[jira] [Commented] (KAFKA-1352) Reduce logging on the server

[ https://issues.apache.org/jira/browse/KAFKA-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980538#comment-13980538 ] Jun Rao commented on KAFKA-1352: In terms of logging, it seems that 1. If we don't know f

Re: Review Request 20616: Fix KAFKA-1409: Address Jun's comments round three

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20616/#review41421 --- core/src/main/scala/kafka/log/Log.scala

Re: Review Request 20695: Patch for KAFKA-1392

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20695/#review41419 --- core/src/test/scala/unit/kafka/admin/AdminTest.scala

Re: Review Request 20694: Patch for KAFKA-1392

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20694/#review41418 --- Ship it! Ship It! - Joel Koshy On April 24, 2014, 11:06 p.m., Ne

[jira] [Commented] (KAFKA-1409) oversized messages can slow down the brokers

[ https://issues.apache.org/jira/browse/KAFKA-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980477#comment-13980477 ] Guozhang Wang commented on KAFKA-1409: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1409) oversized messages can slow down the brokers

[ https://issues.apache.org/jira/browse/KAFKA-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1409: - Attachment: KAFKA-1409_2014-04-24_16:26:06.patch > oversized messages can slow down the brokers >

Re: Review Request 20616: Fix KAFKA-1409: Address Jun's comments round three

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20616/ --- (Updated April 24, 2014, 11:26 p.m.) Review request for kafka. Summary (updat

[jira] [Closed] (KAFKA-1422) Fix transient unit test SocketServerTest

[ https://issues.apache.org/jira/browse/KAFKA-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang closed KAFKA-1422. > Fix transient unit test SocketServerTest > > >

[jira] [Resolved] (KAFKA-1422) Fix transient unit test SocketServerTest

[ https://issues.apache.org/jira/browse/KAFKA-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-1422. -- Resolution: Duplicate > Fix transient unit test SocketServerTest >

Re: Review Request 20541: Patch for KAFKA-1411

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20541/#review41417 --- Ship it! Ship It! - Neha Narkhede On April 21, 2014, 11:34 p.m.,

[jira] [Commented] (KAFKA-1422) Fix transient unit test SocketServerTest

[ https://issues.apache.org/jira/browse/KAFKA-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980473#comment-13980473 ] Guozhang Wang commented on KAFKA-1422: -- Indeed, closing. > Fix transient unit test S

[jira] [Commented] (KAFKA-1395) fix unit tests in AutoOffsetResetTest

[ https://issues.apache.org/jira/browse/KAFKA-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980472#comment-13980472 ] Guozhang Wang commented on KAFKA-1395: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1395) fix unit tests in AutoOffsetResetTest

[ https://issues.apache.org/jira/browse/KAFKA-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1395: - Attachment: KAFKA-1395_2014-04-24_16:22:18.patch > fix unit tests in AutoOffsetResetTest > --

Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20380/ --- (Updated April 24, 2014, 11:22 p.m.) Review request for kafka. Summary (updat

[jira] [Commented] (KAFKA-1422) Fix transient unit test SocketServerTest

[ https://issues.apache.org/jira/browse/KAFKA-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980460#comment-13980460 ] Jun Rao commented on KAFKA-1422: Is this a duplicate of KAFKA-1383? > Fix transient unit

[jira] [Commented] (KAFKA-1392) all TestUtiles.waitUntilTrue() should throw an exception if the return value is false

[ https://issues.apache.org/jira/browse/KAFKA-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980457#comment-13980457 ] Jun Rao commented on KAFKA-1392: Can't seem to update the original RB. Created a new one f

[jira] [Updated] (KAFKA-1392) all TestUtiles.waitUntilTrue() should throw an exception if the return value is false

[ https://issues.apache.org/jira/browse/KAFKA-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1392: --- Attachment: KAFKA-1392.patch > all TestUtiles.waitUntilTrue() should throw an exception if the return value

[jira] [Commented] (KAFKA-1392) all TestUtiles.waitUntilTrue() should throw an exception if the return value is false

[ https://issues.apache.org/jira/browse/KAFKA-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980456#comment-13980456 ] Jun Rao commented on KAFKA-1392: Created reviewboard https://reviews.apache.org/r/20695/

[jira] [Updated] (KAFKA-1392) all TestUtiles.waitUntilTrue() should throw an exception if the return value is false

[ https://issues.apache.org/jira/browse/KAFKA-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1392: - Attachment: KAFKA-1392_2014-04-24_16:07:07.patch > all TestUtiles.waitUntilTrue() should throw an

[jira] [Commented] (KAFKA-1392) all TestUtiles.waitUntilTrue() should throw an exception if the return value is false

[ https://issues.apache.org/jira/browse/KAFKA-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980453#comment-13980453 ] Neha Narkhede commented on KAFKA-1392: -- Updated reviewboard against branch trunk >

[jira] [Commented] (KAFKA-1392) all TestUtiles.waitUntilTrue() should throw an exception if the return value is false

[ https://issues.apache.org/jira/browse/KAFKA-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980450#comment-13980450 ] Neha Narkhede commented on KAFKA-1392: -- Created reviewboard https://reviews.apache.or

Review Request 20695: Patch for KAFKA-1392

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20695/ --- Review request for kafka. Bugs: KAFKA-1392 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1392) all TestUtiles.waitUntilTrue() should throw an exception if the return value is false

[ https://issues.apache.org/jira/browse/KAFKA-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1392: - Attachment: KAFKA-1392.patch > all TestUtiles.waitUntilTrue() should throw an exception if the re

Review Request 20694: Patch for KAFKA-1392

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20694/ --- Review request for kafka. Bugs: KAFKA-1392 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-1422) Fix transient unit test SocketServerTest

Guozhang Wang created KAFKA-1422: Summary: Fix transient unit test SocketServerTest Key: KAFKA-1422 URL: https://issues.apache.org/jira/browse/KAFKA-1422 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1392) all TestUtiles.waitUntilTrue() should throw an exception if the return value is false

[ https://issues.apache.org/jira/browse/KAFKA-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980432#comment-13980432 ] Jun Rao commented on KAFKA-1392: Updated reviewboard against branch origin/trunk > all T

[jira] [Updated] (KAFKA-1392) all TestUtiles.waitUntilTrue() should throw an exception if the return value is false

[ https://issues.apache.org/jira/browse/KAFKA-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1392: --- Attachment: KAFKA-1392_2014-04-24_15:53:56.patch > all TestUtiles.waitUntilTrue() should throw an exception i

Re: Review Request 20677: Patch for KAFKA-1392

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20677/ --- (Updated April 24, 2014, 10:49 p.m.) Review request for kafka. Changes --

Re: Review Request 20677: Patch for KAFKA-1392

> On April 24, 2014, 9:27 p.m., Joel Koshy wrote: > > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala, line 244 > > > > > > Just curious: why are we using the checkpoint interval as the wait time > >

Re: Review Request 20616: Fix KAFKA-1409: Address Jun's comments round two

> On April 24, 2014, 12:44 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/log/Log.scala, lines 275-276 > > > > > > We probably should use validMessages here. I actually thought about this. The thing is that the by

[jira] [Resolved] (KAFKA-1418) transient unit test failure in ProducerFailureHandlingTest

[ https://issues.apache.org/jira/browse/KAFKA-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1418. Resolution: Fixed Fix Version/s: 0.8.2 Thanks for the review. Committed to trunk. > transient unit

Re: Review Request 20677: Patch for KAFKA-1392

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20677/#review41388 --- core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala <

[jira] [Created] (KAFKA-1421) Error: Could not find or load main class kafka.perf.SimpleConsumerPerformance

Daryl Erwin created KAFKA-1421: -- Summary: Error: Could not find or load main class kafka.perf.SimpleConsumerPerformance Key: KAFKA-1421 URL: https://issues.apache.org/jira/browse/KAFKA-1421 Project: Kafk

[jira] Subscription: outstanding kafka patches

Issue Subscription Filter: outstanding kafka patches (88 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1418 transient unit test failure in ProducerFailureHandlingTest https://issues.apache.org/jira/browse/KAFKA-1418 KAFKA-1409

Re: Review Request 20240: Follow-up KAFKA-1352: Standardize stack trace printing in logs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20240/#review41347 --- Here are my initial thoughts on the conventions (and for this kind o

[jira] [Created] (KAFKA-1420) Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in all unit tests

Guozhang Wang created KAFKA-1420: Summary: Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in all unit tests Key: KAFKA-1420 URL: https://issues.apache.org/jira/browse

Re: Review Request 20677: Patch for KAFKA-1392

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20677/#review41363 --- Ship it! Ship It! - Guozhang Wang On April 24, 2014, 6:08 p.m.,

[jira] [Commented] (KAFKA-1392) all TestUtiles.waitUntilTrue() should throw an exception if the return value is false

[ https://issues.apache.org/jira/browse/KAFKA-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980031#comment-13980031 ] Jun Rao commented on KAFKA-1392: Created reviewboard https://reviews.apache.org/r/20677/

[jira] [Updated] (KAFKA-1392) all TestUtiles.waitUntilTrue() should throw an exception if the return value is false

[ https://issues.apache.org/jira/browse/KAFKA-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1392: --- Attachment: KAFKA-1392.patch > all TestUtiles.waitUntilTrue() should throw an exception if the return value

Review Request 20677: Patch for KAFKA-1392

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20677/ --- Review request for kafka. Bugs: KAFKA-1392 https://issues.apache.org/jira/b

Re: Review Request 20669: Patch for KAFKA-1418

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20669/#review41339 --- Ship it! Ship It! - Joel Koshy On April 24, 2014, 4:34 p.m., Jun

[jira] [Created] (KAFKA-1419) cross build for scala 2.11

Scott Clasen created KAFKA-1419: --- Summary: cross build for scala 2.11 Key: KAFKA-1419 URL: https://issues.apache.org/jira/browse/KAFKA-1419 Project: Kafka Issue Type: Improvement Comp

Re: Review Request 20669: Patch for KAFKA-1418

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20669/#review41333 --- Ship it! Good catch! I think moving forward we should 1) make Zook

[jira] [Created] (KAFKA-1418) transient unit test failure in ProducerFailureHandlingTest

Jun Rao created KAFKA-1418: -- Summary: transient unit test failure in ProducerFailureHandlingTest Key: KAFKA-1418 URL: https://issues.apache.org/jira/browse/KAFKA-1418 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1418) transient unit test failure in ProducerFailureHandlingTest

[ https://issues.apache.org/jira/browse/KAFKA-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979927#comment-13979927 ] Jun Rao commented on KAFKA-1418: Created reviewboard https://reviews.apache.org/r/20669/

[jira] [Updated] (KAFKA-1418) transient unit test failure in ProducerFailureHandlingTest

[ https://issues.apache.org/jira/browse/KAFKA-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1418: --- Attachment: KAFKA-1418.patch > transient unit test failure in ProducerFailureHandlingTest > -

Review Request 20669: Patch for KAFKA-1418

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20669/ --- Review request for kafka. Bugs: KAFKA-1418 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1418) transient unit test failure in ProducerFailureHandlingTest

[ https://issues.apache.org/jira/browse/KAFKA-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979923#comment-13979923 ] Jun Rao commented on KAFKA-1418: We actually do close the broker in each of the test. The

[jira] [Commented] (KAFKA-824) java.lang.NullPointerException in commitOffsets

[ https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979858#comment-13979858 ] Jun Rao commented on KAFKA-824: --- ZkClient is only closed when shutdown the consumer connector

[jira] [Commented] (KAFKA-824) java.lang.NullPointerException in commitOffsets

[ https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979832#comment-13979832 ] Artur Denysenko commented on KAFKA-824: --- Could it be by re-using closed ZkClient? ht

[jira] [Commented] (KAFKA-824) java.lang.NullPointerException in commitOffsets

[ https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979793#comment-13979793 ] Jun Rao commented on KAFKA-824: --- Hmm, not sure if this can happen. The following is what happ