-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20695/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1392
    https://issues.apache.org/jira/browse/KAFKA-1392


Repository: kafka


Description
-------

3. Address Joel's comments.


1. Throw exception in waitUntilTrue() if timeout is reached. 2. Fixed unit test 
failure because of 1 in testResumePartitionReassignmentThatWasCompleted (a. 
should wait until reassignment path is deleted; b. under replicated check 
should be wrapped in waitUntilTrue).


Diffs
-----

  core/src/test/scala/unit/kafka/admin/AdminTest.scala 
3a6c5ffa7e27d871a5cfb250c85b0609644b7cf9 
  core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala 
6d489adcb307d4bffc5d36ff65ff1b16f474d4e4 
  core/src/test/scala/unit/kafka/network/SocketServerTest.scala 
c3b1ac445cf496dede87267a9601a466e453fecc 
  core/src/test/scala/unit/kafka/producer/ProducerTest.scala 
dc6a5ea4abcdff370f3b61c774bbde4e4157f412 
  core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala 
b278bb6eaa49d8dbe3b70463fdd4cc854f4796fe 
  core/src/test/scala/unit/kafka/server/LogOffsetTest.scala 
3fb08e69446aba2363255d9853a02c455ac46e11 
  core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 
7a0ef6faeaa419553f912c8a6d44099818e19833 
  core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala 
481a400067ec97ed97a2bbd8506b34960a5ec000 
  core/src/test/scala/unit/kafka/utils/TestUtils.scala 
130b6be8414268b9a992514ecbc7561872ccaca7 

Diff: https://reviews.apache.org/r/20695/diff/


Testing
-------


Thanks,

Jun Rao

Reply via email to