[jira] [Commented] (KAFKA-1328) Add new consumer APIs

[ https://issues.apache.org/jira/browse/KAFKA-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967711#comment-13967711 ] Neha Narkhede commented on KAFKA-1328: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1328) Add new consumer APIs

[ https://issues.apache.org/jira/browse/KAFKA-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1328: - Attachment: KAFKA-1328_2014-04-12_19:12:12.patch > Add new consumer APIs > -

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- (Updated April 13, 2014, 2:12 a.m.) Review request for kafka. Bugs: KAFKA-132

Re: Review for the new consumer APIs

Why cant we pass a callback in subscribe itself? Mainly because it will make the processing kind of awkward since you need to access the other consumer APIs while processing the messages. Your suggestion does point out a problem with the poll() API though. Here is the initial proposal of the poll(

[jira] [Updated] (KAFKA-1328) Add new consumer APIs

[ https://issues.apache.org/jira/browse/KAFKA-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1328: - Attachment: KAFKA-1328_2014-04-12_18:30:22.patch > Add new consumer APIs > -

[jira] [Commented] (KAFKA-1328) Add new consumer APIs

[ https://issues.apache.org/jira/browse/KAFKA-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967703#comment-13967703 ] Neha Narkhede commented on KAFKA-1328: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- (Updated April 13, 2014, 1:30 a.m.) Review request for kafka. Bugs: KAFKA-132

[jira] [Commented] (KAFKA-1355) Reduce/optimize update metadata requests sent during leader election

[ https://issues.apache.org/jira/browse/KAFKA-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967687#comment-13967687 ] Neha Narkhede commented on KAFKA-1355: -- KAFKA-1363 is in 0.8.1 as well as trunk now.

[jira] [Updated] (KAFKA-1382) Update zkVersion on partition state update failures

[ https://issues.apache.org/jira/browse/KAFKA-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1382: - Fix Version/s: 0.8.2 > Update zkVersion on partition state update failures >

[jira] [Commented] (KAFKA-1355) Reduce/optimize update metadata requests sent during leader election

[ https://issues.apache.org/jira/browse/KAFKA-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967666#comment-13967666 ] Joel Koshy commented on KAFKA-1355: --- Tim's patch in 1363 conflicts with this. So we can

Jenkins build is back to normal : Kafka-trunk #163

See

[jira] [Resolved] (KAFKA-1381) transient unit test failure in AddPartitionsTest

[ https://issues.apache.org/jira/browse/KAFKA-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1381. Resolution: Fixed Fix Version/s: 0.8.2 Assignee: Jun Rao Thanks for the review. Committed t

[jira] [Resolved] (KAFKA-1378) transient unit test failure in LogRecoveryTest

[ https://issues.apache.org/jira/browse/KAFKA-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1378. Resolution: Fixed Fix Version/s: 0.8.2 Assignee: Jun Rao Thanks for the review. Committed t

[jira] [Resolved] (KAFKA-1377) transient unit test failure in LogOffsetTest

[ https://issues.apache.org/jira/browse/KAFKA-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1377. Resolution: Fixed Fix Version/s: 0.8.2 Assignee: Jun Rao Thanks for the review. Committed t

Re: Review Request 20272: Patch for KAFKA-1356

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20272/#review40214 --- core/src/main/scala/kafka/server/KafkaApis.scala

[jira] [Resolved] (KAFKA-1363) testTopicConfigChangesDuringDeleteTopic hangs

[ https://issues.apache.org/jira/browse/KAFKA-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1363. -- Resolution: Fixed > testTopicConfigChangesDuringDeleteTopic hangs > ---

[jira] [Commented] (KAFKA-1363) testTopicConfigChangesDuringDeleteTopic hangs

[ https://issues.apache.org/jira/browse/KAFKA-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967627#comment-13967627 ] Neha Narkhede commented on KAFKA-1363: -- Checked into 0.8.1 as well > testTopicConfig

[jira] [Commented] (KAFKA-1355) Reduce/optimize update metadata requests sent during leader election

[ https://issues.apache.org/jira/browse/KAFKA-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967628#comment-13967628 ] Neha Narkhede commented on KAFKA-1355: -- [~jjkoshy] Should we also check in this patch

[jira] [Closed] (KAFKA-1363) testTopicConfigChangesDuringDeleteTopic hangs

[ https://issues.apache.org/jira/browse/KAFKA-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1363. > testTopicConfigChangesDuringDeleteTopic hangs > - > >

Re: Review Request 20186: Patch for KAFKA-1377

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20186/#review40213 --- Ship it! Ship It! - Neha Narkhede On April 12, 2014, 1:14 a.m.,

Re: Review Request 20189: Patch for KAFKA-1378

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20189/#review40212 --- Ship it! Ship It! - Neha Narkhede On April 12, 2014, 1:21 a.m.,

Re: Review Request 20185: Patch for KAFKA-1381

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20185/#review40211 --- Ship it! Ship It! - Neha Narkhede On April 12, 2014, 1:39 a.m.,

Re: Review Request 20185: Patch for KAFKA-1381

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20185/#review40209 --- Ship it! Ship It! - Guozhang Wang On April 12, 2014, 1:39 a.m.,