----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20272/#review40214 -----------------------------------------------------------
core/src/main/scala/kafka/server/KafkaApis.scala <https://reviews.apache.org/r/20272/#comment73148> It seems like the code will be cleaner if we pull MetadataCache into it's own file. core/src/main/scala/kafka/server/KafkaApis.scala <https://reviews.apache.org/r/20272/#comment73150> This is a little awkwardly named and is only used by addPartitionInfo. How about just leaving it in there? core/src/main/scala/kafka/server/KafkaApis.scala <https://reviews.apache.org/r/20272/#comment73149> should we remove this comment? - Neha Narkhede On April 11, 2014, 9:03 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20272/ > ----------------------------------------------------------- > > (Updated April 11, 2014, 9:03 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1356 > https://issues.apache.org/jira/browse/KAFKA-1356 > > > Repository: kafka > > > Description > ------- > > Fix the way we update controller epoch during UpdateMetadataRequest since the > check and set is not atomic. > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaApis.scala > d96229e2d4aa7006b0dbd81055ce5a2459d8758c > core/src/main/scala/kafka/server/ReplicaManager.scala > 0f5aaa9888d6c0ca0b073f4742bee14ad72d0484 > > Diff: https://reviews.apache.org/r/20272/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
