[jira] [Commented] (KAFKA-1253) Implement compression in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935994#comment-13935994 ] Jay Kreps commented on KAFKA-1253: -- As a reference the unix gzip command on random data s

Re: Review Request 17537: Patch for KAFKA-1028

> On March 14, 2014, 8:13 p.m., Jay Kreps wrote: > > This is great! > > > > I don't think we should add a special purpose method that hard codes one > > property in AdminUtils, I think the helper code is actually there in > > LogConfig. > > > > I see Neha's point about adding a higher-level c

Re: Review Request 18299: Fix KAFKA-1253

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/#review37304 --- core/src/test/scala/integration/kafka/api/ProducerSendTest.scala

[jira] [Commented] (KAFKA-1253) Implement compression in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935889#comment-13935889 ] Guozhang Wang commented on KAFKA-1253: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1253) Implement compression in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1253: - Attachment: KAFKA-1253_2014-03-14_17:39:53.patch > Implement compression in new producer > --

Re: Review Request 18299: Fix KAFKA-1253

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated March 15, 2014, 12:40 a.m.) Review request for kafka. Bugs: KAFKA-12

Re: Review Request 18299: Fix KAFKA-1253

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated March 15, 2014, 12:40 a.m.) Review request for kafka. Bugs: KAFKA-12

Re: Review Request 18299: Fix KAFKA-1253

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/#review37302 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/B

Re: Review Request 17537: Patch for KAFKA-1028

> On March 14, 2014, 8:13 p.m., Jay Kreps wrote: > > This is great! > > > > I don't think we should add a special purpose method that hard codes one > > property in AdminUtils, I think the helper code is actually there in > > LogConfig. > > > > I see Neha's point about adding a higher-level c

[jira] [Commented] (KAFKA-1012) Implement an Offset Manager and hook offset requests to it

[ https://issues.apache.org/jira/browse/KAFKA-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935736#comment-13935736 ] Joel Koshy commented on KAFKA-1012: --- Thanks for the reviews. This has been checked in.

[jira] [Commented] (KAFKA-1253) Implement compression in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935730#comment-13935730 ] Guozhang Wang commented on KAFKA-1253: -- message/sec from trunk: 68390.0971 > Impleme

[jira] [Commented] (KAFKA-1305) Controller can hang on controlled shutdown with auto leader balance enabled

[ https://issues.apache.org/jira/browse/KAFKA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935651#comment-13935651 ] Guozhang Wang commented on KAFKA-1305: -- This is a similar issue as for KAFKA-1235. On

Re: Review Request 18299: Fix KAFKA-1253

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated March 14, 2014, 8:54 p.m.) Review request for kafka. Bugs: KAFKA-125

[jira] [Commented] (KAFKA-1253) Implement compression in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935622#comment-13935622 ] Jay Kreps commented on KAFKA-1253: -- What is the performance difference with and without t

Re: Review Request 18299: Fix KAFKA-1253

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated March 14, 2014, 8:51 p.m.) Review request for kafka. Bugs: KAFKA-125

Re: Review Request 18299: Fix KAFKA-1253

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated March 14, 2014, 8:50 p.m.) Review request for kafka. Bugs: KAFKA-125

[jira] [Commented] (KAFKA-1253) Implement compression in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935617#comment-13935617 ] Guozhang Wang commented on KAFKA-1253: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1253) Implement compression in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1253: - Attachment: KAFKA-1253_2014-03-14_13:46:40.patch > Implement compression in new producer > --

Re: Review Request 18299: Fix KAFKA-1253

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18299/ --- (Updated March 14, 2014, 8:46 p.m.) Review request for kafka. Bugs: KAFKA-125

Re: reviewer for KAFKA-1028

Done, left a quick question for you. On Fri, Mar 14, 2014 at 1:11 PM, Neha Narkhede wrote: > Jay, > > It will be good if you take a quick look at > https://issues.apache.org/jira/browse/KAFKA-1028 as well. It leaks a > replication per topic config into the log. Other than that, the patch is > re

[jira] [Comment Edited] (KAFKA-1028) per topic configuration of preference for consistency over availability

[ https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935570#comment-13935570 ] Jay Kreps edited comment on KAFKA-1028 at 3/14/14 8:15 PM: --- [~no

[jira] [Commented] (KAFKA-1028) per topic configuration of preference for consistency over availability

[ https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935570#comment-13935570 ] Jay Kreps commented on KAFKA-1028: -- [~noslowerdna] I made a few very minor comments. [~n

Re: Review Request 17537: Patch for KAFKA-1028

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17537/#review37265 --- Ship it! This is great! I don't think we should add a special purp

Re: reviewer for KAFKA-1028

Jay, It will be good if you take a quick look at https://issues.apache.org/jira/browse/KAFKA-1028 as well. It leaks a replication per topic config into the log. Other than that, the patch is ready for checkin Thanks, Neha On Thu, Mar 13, 2014 at 1:34 PM, Neha Narkhede wrote: > I've been review

[jira] [Commented] (KAFKA-1253) Implement compression in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935548#comment-13935548 ] Guozhang Wang commented on KAFKA-1253: -- Yes. And I dig a little bit deeper for the re

[jira] [Commented] (KAFKA-1028) per topic configuration of preference for consistency over availability

[ https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935408#comment-13935408 ] Neha Narkhede commented on KAFKA-1028: -- [~noslowerdna] The change you made in your la

[jira] [Commented] (KAFKA-1253) Implement compression in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935287#comment-13935287 ] Neha Narkhede commented on KAFKA-1253: -- [~guozhang] What metric does the above test m

[jira] [Commented] (KAFKA-1253) Implement compression in new producer

[ https://issues.apache.org/jira/browse/KAFKA-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935241#comment-13935241 ] Guozhang Wang commented on KAFKA-1253: -- With the new code, new performance numbers (1