[ 
https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935408#comment-13935408
 ] 

Neha Narkhede commented on KAFKA-1028:
--------------------------------------

[~noslowerdna] The change you made in your latest patch make a lot of sense. 
Overall, the patch looks good. Just one concern -

The patch leaks a per topic config relevant only to replication to the 
LogConfig module. This is a side effect of the way we've designed per topic 
configs since we only allow log configs to be overriden per topic. Since 
[~jkreps] is the owner of the log module, I'd wait for his review as well. 

Meanwhile, I think, besides the above concern and the need to rebase, the patch 
is ready for checkin. Thanks for your contribution!

> per topic configuration of preference for consistency over availability
> -----------------------------------------------------------------------
>
>                 Key: KAFKA-1028
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1028
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Scott Clasen
>            Assignee: Neha Narkhede
>         Attachments: KAFKA-1028.patch, KAFKA-1028_2014-01-30_13:45:30.patch, 
> KAFKA-1028_2014-03-03_18:48:43.patch
>
>
> As discussed with Neha on the ML.
> It should be possible to configure a topic to disallow unclean leader 
> election, thus preventing the situation where committed messages can be 
> discarded once a failed leader comes back online in a situation where it was 
> the only ISR.
> This would open kafka to additional usecases where the possibility of 
> committted messages being discarded is unacceptable.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to