[jira] [Commented] (KAFKA-1275) fixes for quickstart documentation

[ https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13922022#comment-13922022 ] Jun Rao commented on KAFKA-1275: The log compaction section makes sense to me. Maybe other

[jira] [Commented] (KAFKA-1275) fixes for quickstart documentation

[ https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921976#comment-13921976 ] Jay Kreps commented on KAFKA-1275: -- 20. Yes, I plan to fix this when we have the release

--deleteConfig option in 0.8.1

Hey guys, The delete config option we added to kafka-topics.sh is --deleteConfig. We have like 300 command line options and all of them are lower case and hyphenated (i.e. --delete-config). It's obviously pretty irritating if we can't even keep consistent in a single tool. Let's stick to that conv

Re: Review Request 18022: KAFKA-1012: In-built offset management in Kafka

> On March 6, 2014, 1:47 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/client/ClientUtils.scala, line 120 > > > > > > Now that you refactored the loop to use while(), is it necessary to use > > find? It s

Re: Review Request 18022: KAFKA-1012: In-built offset management in Kafka

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18022/#review36305 --- Ship it! I think this patch is in reasonable shape and is pretty la

[jira] [Commented] (KAFKA-1275) fixes for quickstart documentation

[ https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921853#comment-13921853 ] Jun Rao commented on KAFKA-1275: Some more comments on the doc: 20. Quickstart still refe

Re: Review Request 18022: KAFKA-1012: In-built offset management in Kafka

> On Feb. 28, 2014, 7:30 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/OffsetManager.scala, line 149 > > > > > > I wonder if it is safe to assume that the local broker's > > offsetsTopicNumPartitions

[jira] [Updated] (KAFKA-1281) add the new producer to existing tools

[ https://issues.apache.org/jira/browse/KAFKA-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1281: - Attachment: KAFKA-1281_2014-03-05_16:32:20.patch > add the new producer to existing tools > -

Re: Review Request 18712: Patch for KAFKA-1281

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/ --- (Updated March 6, 2014, 12:32 a.m.) Review request for kafka. Bugs: KAFKA-128

[jira] [Commented] (KAFKA-1281) add the new producer to existing tools

[ https://issues.apache.org/jira/browse/KAFKA-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921715#comment-13921715 ] Neha Narkhede commented on KAFKA-1281: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1012) Implement an Offset Manager and hook offset requests to it

[ https://issues.apache.org/jira/browse/KAFKA-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921669#comment-13921669 ] Joel Koshy commented on KAFKA-1012: --- Just updated the RB with a new patch. > Implement

[jira] [Updated] (KAFKA-1281) add the new producer to existing tools

[ https://issues.apache.org/jira/browse/KAFKA-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1281: - Attachment: KAFKA-1281_2014-03-05_15:59:17.patch > add the new producer to existing tools > -

[jira] [Commented] (KAFKA-1281) add the new producer to existing tools

[ https://issues.apache.org/jira/browse/KAFKA-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921666#comment-13921666 ] Neha Narkhede commented on KAFKA-1281: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 18712: Patch for KAFKA-1281

> On March 4, 2014, 7:29 p.m., Jun Rao wrote: > > core/src/test/scala/other/kafka/TestEndToEndLatency.scala, lines 59-60 > > > > > > We need to call get() on the returned future object. - Neha --

Re: Review Request 18712: Patch for KAFKA-1281

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/ --- (Updated March 5, 2014, 11:59 p.m.) Review request for kafka. Bugs: KAFKA-128

[jira] [Commented] (KAFKA-1290) TestLogCleaning tool hangs on the new producer

[ https://issues.apache.org/jira/browse/KAFKA-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921664#comment-13921664 ] Neha Narkhede commented on KAFKA-1290: -- As discussed offline, we are converting all t

Re: Review Request 18022: KAFKA-1012: In-built offset management in Kafka

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18022/ --- (Updated March 5, 2014, 11:53 p.m.) Review request for kafka. Changes ---

Re: Review Request 18022: KAFKA-1012: In-built offset management in Kafka

> On Feb. 28, 2014, 7:30 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 234 > > > > > > unused It is used further down. > On Feb. 28, 2014, 7:30 p.m., Neha Narkhede wrote: > >

[jira] [Commented] (KAFKA-1290) TestLogCleaning tool hangs on the new producer

[ https://issues.apache.org/jira/browse/KAFKA-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921563#comment-13921563 ] Jay Kreps commented on KAFKA-1290: -- Hey Jun, why are we converting this? > TestLogCleani

[jira] [Commented] (KAFKA-1286) Retry Can Block

[ https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921560#comment-13921560 ] Neha Narkhede commented on KAFKA-1286: -- [~jkreps] Ya, you're right. I was reading it

[jira] [Commented] (KAFKA-1275) fixes for quickstart documentation

[ https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921550#comment-13921550 ] Jay Kreps commented on KAFKA-1275: -- Ah, thanks for the careful attention to detail. Yeah

[jira] [Resolved] (KAFKA-1286) Retry Can Block

[ https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-1286. -- Resolution: Fixed > Retry Can Block > > > Key: KAFKA-1286 >

[jira] [Commented] (KAFKA-1286) Retry Can Block

[ https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921546#comment-13921546 ] Jay Kreps commented on KAFKA-1286: -- Jun, cool changed it to always use the double operato

[jira] [Commented] (KAFKA-1286) Retry Can Block

[ https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921519#comment-13921519 ] Jun Rao commented on KAFKA-1286: For 1, yes, they are equivalent. My concern is that the u

[jira] [Commented] (KAFKA-1275) fixes for quickstart documentation

[ https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921484#comment-13921484 ] Evan Zacks commented on KAFKA-1275: --- Thanks, Jay. There were a few inconsistencies in t

Re: Review Request 18712: Patch for KAFKA-1281

> On March 4, 2014, 7:29 p.m., Jun Rao wrote: > > Got the following warning when running console-producer with --new-producer. > > > > [2014-03-04 11:25:24,007] WARN The configuration > > topic.metadata.refresh.interval.ms = 500 was supplied but isn't a known > > config. (org.apache.kafka.clie

[jira] [Commented] (KAFKA-1286) Retry Can Block

[ https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921443#comment-13921443 ] Jay Kreps commented on KAFKA-1286: -- Jun: 1. They are equivalent for booleans but I wouldn

[jira] [Commented] (KAFKA-1275) fixes for quickstart documentation

[ https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921434#comment-13921434 ] Jay Kreps commented on KAFKA-1275: -- Hey Evan, I took you patch and added a bunch of addi

[jira] [Updated] (KAFKA-1275) fixes for quickstart documentation

[ https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1275: - Resolution: Fixed Status: Resolved (was: Patch Available) > fixes for quickstart documentation >

Documentation for the upcoming 0.8.1 release

Hey guys, I took a stab at updating the docs for the 0.8.1 release. In particular, I added a section on log compaction: http://kafka.apache.org/081/documentation.html#compaction I also updated the configs. This is all under 081, I will flip this over to be the main documentation when 0.8.1 is rel

Re: Time-based flush brokenish in 0.8.1?

Since most users will rely upon the async flush of old segments, perhaps we can leave the default as it is and just make it clear in the documentation? Thanks, Jun On Wed, Mar 5, 2014 at 10:12 AM, Jay Kreps wrote: > It looks like we disable the flush check by default > /* the frequency in ms

[jira] [Commented] (KAFKA-1286) Retry Can Block

[ https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921175#comment-13921175 ] Neha Narkhede commented on KAFKA-1286: -- Shouldn't backingOff be (batch.attempts > 0 &

Re: Review Request 18774: Patch for KAFKA-1240

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18774/#review36245 --- core/src/main/scala/kafka/tools/newproducer/MirrorMaker.scala

[jira] [Commented] (KAFKA-1286) Retry Can Block

[ https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921164#comment-13921164 ] Jun Rao commented on KAFKA-1286: A couple of minor comments: 1. In RecordAccumulator, sho

Re: Review Request 18740: Fix KAFKA-1286

> On March 5, 2014, 12:24 a.m., Jun Rao wrote: > > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala, > > lines 323-324 > > > > > > Actually, why don't we need to close producer during shutdo

Time-based flush brokenish in 0.8.1?

It looks like we disable the flush check by default /* the frequency in ms that the log flusher checks whether any log needs to be flushed to disk */ val logFlushSchedulerIntervalMs = props.getLong(" log.flush.scheduler.interval.ms", Long.MaxValue) This means that if you set a flush time for a lo

Re: wiki for Kafka system tests

Thanks. Fixed. Jun On Wed, Mar 5, 2014 at 9:13 AM, Neha Narkhede wrote: > This is very useful, Jun. I was going through it and saw that the build > instructions might be outdated - > > 1. Check out kafka codebase: > >a. ~ $ git clone https://git-wip-us.apache.org/repos/asf/kafka.git >b.

[jira] [Assigned] (KAFKA-1240) Add ability to existing system tests to use the new producer client

[ https://issues.apache.org/jira/browse/KAFKA-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao reassigned KAFKA-1240: -- Assignee: Jun Rao > Add ability to existing system tests to use the new producer client > -

[jira] [Commented] (KAFKA-1240) Add ability to existing system tests to use the new producer client

[ https://issues.apache.org/jira/browse/KAFKA-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1392#comment-1392 ] Jun Rao commented on KAFKA-1240: Created reviewboard https://reviews.apache.org/r/18774/

[jira] [Updated] (KAFKA-1240) Add ability to existing system tests to use the new producer client

[ https://issues.apache.org/jira/browse/KAFKA-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1240: --- Attachment: KAFKA-1240.patch > Add ability to existing system tests to use the new producer client >

Review Request 18774: Patch for KAFKA-1240

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18774/ --- Review request for kafka. Bugs: KAFKA-1240 https://issues.apache.org/jira/b

Re: wiki for Kafka system tests

This is very useful, Jun. I was going through it and saw that the build instructions might be outdated - 1. Check out kafka codebase: a. ~ $ git clone https://git-wip-us.apache.org/repos/asf/kafka.git b. ~ $ cd c. $ git checkout 0.8 2. Under , build kafka a. $ ./sbt package assem

Re: wiki for Kafka system tests

Thanks. Fixed. Do you see any other issues? Jun On Tue, Mar 4, 2014 at 11:01 PM, Guozhang Wang wrote: > Hi Jun, > > Some links seem not correct in "Troubleshooting a failing case" and "Test > Case Description" sections. > > Guozhang > > > On Tue, Mar 4, 2014 at 6:51 PM, Jun Rao wrote: > > > H