Re: wiki for Kafka system tests

Hi Jun, Some links seem not correct in "Troubleshooting a failing case" and "Test Case Description" sections. Guozhang On Tue, Mar 4, 2014 at 6:51 PM, Jun Rao wrote: > Hi, > > I added a few wiki pages that describe the current system tests in Kafka. > The following is the entry point, which i

[VOTE] Apache Kafka Release 0.8.1 - Candidate 2

This is the second candidate for release of Apache Kafka 0.8.1. This release candidate fixes the following two JIRA KAFKA-1288and KAFKA-1289 and updated release steps with the gradle changes https:

Re: Error when using console consumer

Not sure why the message count output was added. However, it goes to stderr, not stdout. Thanks, Jun On Tue, Mar 4, 2014 at 8:49 PM, Jay Kreps wrote: > The console consumer broken windows on the 0.8.1 branch. Going through the > quickstart I notice two issues: > > 1. Control-C now produces a

Logging irrelevant things

We have been debating the granularity of logging. Here is an example where I just wasted a little time. I was testing a three node cluster. I killed one of the brokers and then I saw this in the other brokers logs: java.nio.channels.ClosedChannelException at kafka.network.BlockingChannel.send(Bloc

Error when using console consumer

The console consumer broken windows on the 0.8.1 branch. Going through the quickstart I notice two issues: 1. Control-C now produces a spurious error message: [2014-03-04 20:44:38,026] WARN Reconnect due to socket error: null (kafka.consumer.SimpleConsumer) 2. Somebody has added this useless mess

[jira] [Commented] (KAFKA-1286) Retry Can Block

[ https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920465#comment-13920465 ] Jay Kreps commented on KAFKA-1286: -- This looks good to me. I got one compilation error du

Re: command line tools

Personally I don't mind the current approach as it is discoverable and works with tab completion. I wouldn't be opposed to replacing kafka-run-class.sh with a generic kafka script that handles the java and logging options and maintaining a human friendly mapping for some of the class names so that

Re: command line tools

How about a kafka-system-tool.sh and a little bash/scala underneath to delegate which tool is asked for and passes the params from cli to object? kafka-system-tool.sh -h would respond with the list of tools and kafka-system-tool.sh toolName -h would respond with the actual tool's args from the to

wiki for Kafka system tests

Hi, I added a few wiki pages that describe the current system tests in Kafka. The following is the entry point, which is linked off the main wiki page. https://cwiki.apache.org/confluence/display/KAFKA/Kafka+System+Tests Thanks, Jun

[VOTE CANCELED] Apache Kafka Release 0.8.1 - Candidate 1

preparing rc2 On Tue, Mar 4, 2014 at 5:24 PM, Joe Stein wrote: > Thanks for taking care of the open issues. I am removing 18 JIRAs from > the release notes by filtering out resolved and closed status without a > done/resolved resolution > https://issues.apache.org/jira/issues/?filter=12326760

[jira] [Updated] (KAFKA-1286) Retry Can Block

[ https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1286: - Attachment: KAFKA-1286_2014-03-04_17:56:47.patch > Retry Can Block > > >

Re: Review Request 18740: Fix KAFKA-1286

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/ --- (Updated March 5, 2014, 1:58 a.m.) Review request for kafka. Bugs: KAFKA-1286

[jira] [Commented] (KAFKA-1286) Retry Can Block

[ https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920390#comment-13920390 ] Guozhang Wang commented on KAFKA-1286: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 18740: Fix KAFKA-1286

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/ --- (Updated March 5, 2014, 1:57 a.m.) Review request for kafka. Bugs: KAFKA-1286

[jira] [Updated] (KAFKA-1291) Make wrapper shell scripts for important tools

[ https://issues.apache.org/jira/browse/KAFKA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1291: - Labels: newbie usability (was: newbie) > Make wrapper shell scripts for important tools > --

Usability

Hey guys, It would be good to tag any JIRA for something which is an confusing or annoying with the "usability" tag. I am trying to get a list of all these together so we can take a wack at some of them in a co-ordinated way. -Jay

Re: Review Request 18740: Fix KAFKA-1286

> On March 5, 2014, 12:02 a.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java, line 42 > > > > > > I think this may be incorrect if the apikey enums are ever out of order > >

command line tools

I noticed that we have been a little haphazard in which commands get a top-level script. I think these are nice as they make the available commands discoverable. Currently, for example, mirror maker doesn't have one and that is a pretty critical tool. Here is what we have: kafka-console-consumer.s

Re: Review Request 18740: Fix KAFKA-1286

> On March 5, 2014, 12:24 a.m., Jun Rao wrote: > > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala, > > lines 307-308 > > > > > > Could we compare the content of unique message set? This w

[jira] [Created] (KAFKA-1292) Command-line tools should print what they do as part of their usage command

Jay Kreps created KAFKA-1292: Summary: Command-line tools should print what they do as part of their usage command Key: KAFKA-1292 URL: https://issues.apache.org/jira/browse/KAFKA-1292 Project: Kafka

[jira] [Assigned] (KAFKA-1275) fixes for quickstart documentation

[ https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps reassigned KAFKA-1275: Assignee: Jay Kreps > fixes for quickstart documentation > -- > >

[jira] [Created] (KAFKA-1291) Make wrapper shell scripts for important tools

Jay Kreps created KAFKA-1291: Summary: Make wrapper shell scripts for important tools Key: KAFKA-1291 URL: https://issues.apache.org/jira/browse/KAFKA-1291 Project: Kafka Issue Type: Improvement

Re: Review Request 18740: Fix KAFKA-1286

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/#review36194 --- There are compilation errors when running unit tests. clients/src/

Re: Review Request 18740: Fix KAFKA-1286

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/#review36195 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/R

Re: Review Request 18299: Proposed In-place Compression on MemoryRecords

> On March 2, 2014, 2:15 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java, > > lines 155-157 > > > > > > My earlier comment about whether we should clos

[jira] [Commented] (KAFKA-1286) Retry Can Block

[ https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920186#comment-13920186 ] Guozhang Wang commented on KAFKA-1286: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 18740: Fix KAFKA-1286

> On March 4, 2014, 9:23 p.m., Jay Kreps wrote: > > core/src/main/scala/kafka/log/LogManager.scala, line 182 > > > > > > Let's not add to log spam... I saw for sub-modules we have some inconsistency: for some of them

Re: Review Request 18740: Fix KAFKA-1286

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/ --- (Updated March 4, 2014, 11:15 p.m.) Review request for kafka. Bugs: KAFKA-128

[jira] [Updated] (KAFKA-1286) Retry Can Block

[ https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1286: - Attachment: KAFKA-1286_2014-03-04_15:14:49.patch > Retry Can Block > > >

Re: Review Request 18740: Fix KAFKA-1286

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/ --- (Updated March 4, 2014, 11:15 p.m.) Review request for kafka. Bugs: KAFKA-128

Re: [VOTE} Apache Kafka Release 0.8.1 - Candidate 1

Thanks for taking care of the open issues. I am removing 18 JIRAs from the release notes by filtering out resolved and closed status without a done/resolved resolution https://issues.apache.org/jira/issues/?filter=12326760 for the release notes for RC2 and preparing and going through everything ag

Re: Review Request 18740: Fix KAFKA-1286

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/#review36152 --- This is very good. I flagged a number of minor things, but basically

[jira] [Commented] (KAFKA-1289) Misc. nitpicks in log cleaner

[ https://issues.apache.org/jira/browse/KAFKA-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919889#comment-13919889 ] Joe Stein commented on KAFKA-1289: -- committed to 0.8.1 and trunk, thanks!!! > Misc. nitp

[jira] [Resolved] (KAFKA-1288) add enclosing dir in release tar gz

[ https://issues.apache.org/jira/browse/KAFKA-1288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein resolved KAFKA-1288. -- Resolution: Fixed Fix Version/s: 0.8.1 applying to 0.8.1 > add enclosing dir in release tar gz

[jira] [Resolved] (KAFKA-1289) Misc. nitpicks in log cleaner

[ https://issues.apache.org/jira/browse/KAFKA-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein resolved KAFKA-1289. -- Resolution: Fixed Fix Version/s: 0.8.1 applying to 0.8.1 branch > Misc. nitpicks in log cleaner

Re: Review Request 18712: Patch for KAFKA-1281

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/#review36141 --- Got the following warning when running console-producer with --new-p

[jira] [Updated] (KAFKA-1286) Retry Can Block

[ https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1286: - Attachment: KAFKA-1286_2014-03-04_11:04:32.patch > Retry Can Block > > >

[jira] [Commented] (KAFKA-1286) Retry Can Block

[ https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919775#comment-13919775 ] Guozhang Wang commented on KAFKA-1286: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 18740: Fix KAFKA-1286

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/ --- (Updated March 4, 2014, 7:05 p.m.) Review request for kafka. Bugs: KAFKA-1286

Re: Review Request 18740: Fix KAFKA-1286

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/ --- (Updated March 4, 2014, 7:04 p.m.) Review request for kafka. Bugs: KAFKA-1286

[jira] [Updated] (KAFKA-1290) TestLogCleaning tool hangs on the new producer

[ https://issues.apache.org/jira/browse/KAFKA-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1290: - Assignee: (was: Jun Rao) > TestLogCleaning tool hangs on the new producer > -

[jira] [Created] (KAFKA-1290) TestLogCleaning tool hangs on the new producer

Neha Narkhede created KAFKA-1290: Summary: TestLogCleaning tool hangs on the new producer Key: KAFKA-1290 URL: https://issues.apache.org/jira/browse/KAFKA-1290 Project: Kafka Issue Type: Sub-

Re: Review Request 18740: Fix KAFKA-1286

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/ --- (Updated March 4, 2014, 6:56 p.m.) Review request for kafka. Bugs: KAFKA-1286

[jira] [Updated] (KAFKA-1286) Retry Can Block

[ https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1286: - Attachment: KAFKA-1286.patch > Retry Can Block > > > Key: KAFKA

[jira] [Commented] (KAFKA-1286) Retry Can Block

[ https://issues.apache.org/jira/browse/KAFKA-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919756#comment-13919756 ] Guozhang Wang commented on KAFKA-1286: -- Created reviewboard https://reviews.apache.or

Review Request 18740: Fix KAFKA-1286

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18740/ --- Review request for kafka. Bugs: KAFKA-1286 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1281) add the new producer to existing tools

[ https://issues.apache.org/jira/browse/KAFKA-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919752#comment-13919752 ] Neha Narkhede commented on KAFKA-1281: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1281) add the new producer to existing tools

[ https://issues.apache.org/jira/browse/KAFKA-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1281: - Attachment: KAFKA-1281_2014-03-04_10:47:36.patch > add the new producer to existing tools > -

Re: Review Request 18712: Patch for KAFKA-1281

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/ --- (Updated March 4, 2014, 6:48 p.m.) Review request for kafka. Bugs: KAFKA-1281

Re: Review Request 18712: Patch for KAFKA-1281

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/ --- (Updated March 4, 2014, 6:47 p.m.) Review request for kafka. Bugs: KAFKA-1281