Re: Kafka http endpoint

2014-02-12 Thread Jun Rao
Sasha, Thanks. I added your link to our wiki ( https://cwiki.apache.org/confluence/display/KAFKA/Clients) Jun On Wed, Feb 12, 2014 at 1:36 PM, Sasha Klizhentas < sasha.klizhen...@mailgunhq.com> wrote: > JFYI: > > Kafka-http endpoint + docs as a separate project: > > https://github.com/mailgun/

Re: quotes in MBean names

2014-02-12 Thread Jun Rao
The quotes are added by the metrics-core jar that Kafka uses. Thanks, Jun On Wed, Feb 12, 2014 at 10:59 AM, Arthur Naseef < arthur.nas...@ticketmaster.com> wrote: > Browsing MBeans from Kafka, I see quotes in the names. Searching on the > problem against the archives, I saw a comment indicati

[jira] [Created] (KAFKA-1262) Producer halts on broker bounces

2014-02-12 Thread Neha Narkhede (JIRA)
Neha Narkhede created KAFKA-1262: Summary: Producer halts on broker bounces Key: KAFKA-1262 URL: https://issues.apache.org/jira/browse/KAFKA-1262 Project: Kafka Issue Type: Sub-task

Re: Review Request 18040: Make metadata refresh period configurable

2014-02-12 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18040/#review34341 --- Ship it! Ship It! - Neha Narkhede On Feb. 12, 2014, 11:33 p.m.,

Error Handling on New Producer

2014-02-12 Thread Guozhang Wang
Folks, While working on the new producer, I noticed another issue about error handling that I would like to ask for some discussions (I know Jay said the protocol definition is the last one, but I guess that can never be true :) Currently we have two classes of exceptions that we can throw when s

Kafka Contributor

2014-02-12 Thread Ramanathan, Venkatesh
Hi We've some code for Kafka monitoring and benchmarking. Would like to know the process for making contributions. I see the page https://kafka.apache.org/contributing.html This page talks about patches only. Is it the same process? Thanks Venkatesh

Re: Metrics in new producer

2014-02-12 Thread Joel Koshy
I have not had a chance to review the new metrics code and its features carefully (apart from your write-up), but here are my general thoughts: Implementing a metrics package correctly is difficult; more so for people like me, because I'm not a statistician. However, if this new package: {(i) fun

[jira] [Updated] (KAFKA-1261) Make metadata refresh configurable

2014-02-12 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1261: - Attachment: KAFKA-1261.patch > Make metadata refresh configurable > -- >

[jira] [Commented] (KAFKA-1261) Make metadata refresh configurable

2014-02-12 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899756#comment-13899756 ] Jay Kreps commented on KAFKA-1261: -- Created reviewboard https://reviews.apache.org/r/1804

Review Request 18040: Make metadata refresh period configurable

2014-02-12 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18040/ --- Review request for kafka. Bugs: KAFKA-1261 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-1261) Make metadata refresh configurable

2014-02-12 Thread Jay Kreps (JIRA)
Jay Kreps created KAFKA-1261: Summary: Make metadata refresh configurable Key: KAFKA-1261 URL: https://issues.apache.org/jira/browse/KAFKA-1261 Project: Kafka Issue Type: Sub-task Affects Ver

Re: Metrics in new producer

2014-02-12 Thread Jay Kreps
Sriram, Makes sense. I am cool moving this stuff into its own repo if people think that is better. I'm not sure it would get much contribution but when I started messing with this I did have a lot of grand ideas of making adding metrics to a sensor dynamic so you could add more stuff in real-time(

Re: Metrics in new producer

2014-02-12 Thread Sriram Subramanian
I am actually neutral to this change. I found the replies were more towards the implementation and features so far. I would like the community to think about the questions below before making a decision. My opinion on this is that it has potential to be its own project and it would attract develope

Kafka http endpoint

2014-02-12 Thread Sasha Klizhentas
JFYI: Kafka-http endpoint + docs as a separate project: https://github.com/mailgun/kafka-http Thanks, Sasha

Re: Review Request 17479: Patch for KAFKA-1232

2014-02-12 Thread Jun Rao
> On Feb. 3, 2014, 7:57 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/admin/TopicCommand.scala, line 275 > > > > > > shouldn't the first check be that exactly one of alter, create, delete, > > describe or

Re: Metrics in new producer

2014-02-12 Thread Jay Kreps
Hey Sriram, Not sure if these are actually meant as questions or more veiled comments. In an case I tried to give my 2 cents inline. On Tue, Feb 11, 2014 at 11:12 PM, Sriram Subramanian < srsubraman...@linkedin.com> wrote: > I think answering the questions below would help to make a better > dec

[jira] [Commented] (KAFKA-1233) Integration test for the new producer

2014-02-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899584#comment-13899584 ] Guozhang Wang commented on KAFKA-1233: -- It should be get() instead of wait() in line

Re: Metrics in new producer

2014-02-12 Thread Jay Kreps
Hey Jun, 1. With respect to percentile, my assumption is that you would not use a global default. Since metrics are attached per-sensor you would give a range that makes sense for that value. So in your example message size would presumably have the range (0,max_message_size) and latency would hav

[jira] [Commented] (KAFKA-1233) Integration test for the new producer

2014-02-12 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899572#comment-13899572 ] Neha Narkhede commented on KAFKA-1233: -- testSendPartition test actually fails with th

Re: Review Request 18026: Followup patch incorporting Jay's suggestions

2014-02-12 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18026/#review34316 --- Ship it! Ship It! - Jay Kreps On Feb. 12, 2014, 7:14 p.m., Guozh

[jira] [Commented] (KAFKA-1012) Implement an Offset Manager and hook offset requests to it

2014-02-12 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899502#comment-13899502 ] Joel Koshy commented on KAFKA-1012: --- I uploaded a patch (manually) to this RB: https://

Re: Review Request 18022: KAFKA-1012: In-built offset management in Kafka

2014-02-12 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18022/ --- (Updated Feb. 12, 2014, 7:50 p.m.) Review request for kafka. Bugs: KAFKA-1012

Review Request 18026: Followup patch incorporting Jay's suggestions

2014-02-12 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18026/ --- Review request for kafka. Bugs: KAFKA-1233 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1233) Integration test for the new producer

2014-02-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899447#comment-13899447 ] Guozhang Wang commented on KAFKA-1233: -- Created reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1233) Integration test for the new producer

2014-02-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1233: - Attachment: KAFKA-1233.patch > Integration test for the new producer > --

quotes in MBean names

2014-02-12 Thread Arthur Naseef
Browsing MBeans from Kafka, I see quotes in the names. Searching on the problem against the archives, I saw a comment indicating that a metrics library is adding the quotes. I would like to try to resolve that issue. If I manage to succeed, I will post a pull request or patch. Looking throug

[jira] [Commented] (KAFKA-1243) Gradle issues for release

2014-02-12 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899282#comment-13899282 ] Joe Stein commented on KAFKA-1243: -- Thanks Jun! Sorry I have been swamped the last few da

[jira] [Resolved] (KAFKA-121) pom should include standard maven niceties

2014-02-12 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein resolved KAFKA-121. - Resolution: Won't Fix These have all been taken care. > pom should include standard maven niceties >

[jira] [Resolved] (KAFKA-1249) release tar name is different than 0.8.0

2014-02-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1249. Resolution: Fixed Assignee: Jun Rao Committed to both 0.8.1 and trunk. > release tar name is differe

[jira] [Commented] (KAFKA-1243) Gradle issues for release

2014-02-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899250#comment-13899250 ] Jun Rao commented on KAFKA-1243: Double committed my patch to 0.8.1 and trunk. Will close

[jira] [Resolved] (KAFKA-1244) The LICENSE and NOTICE are missing from the jar files

2014-02-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1244. Resolution: Fixed Assignee: Jun Rao Committed to both 0.8.1 and trunk. > The LICENSE and NOTICE are

[jira] [Resolved] (KAFKA-1246) The 2.10 version is showing up as 2.10.1

2014-02-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1246. Resolution: Fixed Assignee: Jun Rao Committed to both 0.8.1 and trunk. > The 2.10 version is showing