[jira] [Commented] (KAFKA-330) Add delete topic support

[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13885039#comment-13885039 ] Neha Narkhede commented on KAFKA-330: - Updated reviewboard https://reviews.apache.org/r

[jira] [Updated] (KAFKA-330) Add delete topic support

[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-330: Attachment: KAFKA-330_2014-01-28_22:01:16.patch > Add delete topic support > --

Re: Review Request 17460: Patch for KAFKA-330

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17460/ --- (Updated Jan. 29, 2014, 6:01 a.m.) Review request for kafka. Bugs: KAFKA-330

[jira] [Commented] (KAFKA-1232) make TopicCommand more consistent

[ https://issues.apache.org/jira/browse/KAFKA-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13885017#comment-13885017 ] Jun Rao commented on KAFKA-1232: Updated reviewboard https://reviews.apache.org/r/17479/

Re: Review Request 17479: Patch for KAFKA-1232

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17479/ --- (Updated Jan. 29, 2014, 5:21 a.m.) Review request for kafka. Summary (updated

[jira] [Updated] (KAFKA-1232) make TopicCommand more consistent

[ https://issues.apache.org/jira/browse/KAFKA-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1232: --- Attachment: KAFKA-1232_2014-01-28_21:21:17.patch > make TopicCommand more consistent > --

[jira] [Commented] (KAFKA-1232) make TopicCommand more consistent

[ https://issues.apache.org/jira/browse/KAFKA-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884940#comment-13884940 ] Jun Rao commented on KAFKA-1232: Created reviewboard https://reviews.apache.org/r/17479/

[jira] [Updated] (KAFKA-1232) make TopicCommand more consistent

[ https://issues.apache.org/jira/browse/KAFKA-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1232: --- Attachment: KAFKA-1232.patch > make TopicCommand more consistent > - > >

Review Request 17479: make TopicCommand more consistent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17479/ --- Review request for kafka. Bugs: KAFKA-1232 https://issues.apache.org/jira/b

[jira] [Created] (KAFKA-1232) make TopicCommand more consistent

Jun Rao created KAFKA-1232: -- Summary: make TopicCommand more consistent Key: KAFKA-1232 URL: https://issues.apache.org/jira/browse/KAFKA-1232 Project: Kafka Issue Type: Improvement Compone

Re: Review Request 17460: Patch for KAFKA-330

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17460/ --- (Updated Jan. 29, 2014, 1:38 a.m.) Review request for kafka. Bugs: KAFKA-330

Re: Review Request 17460: Patch for KAFKA-330

> On Jan. 28, 2014, 11:16 p.m., Guozhang Wang wrote: > > In all, I would vote for marking the deletion as failed when some brokers > > are in-available, but with this I still feel the delete-topic logic is > > pretty complicated interleaving with other operations. Since in most > > operational

[jira] [Updated] (KAFKA-330) Add delete topic support

[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-330: Attachment: KAFKA-330_2014-01-28_15:19:20.patch > Add delete topic support > --

[jira] [Commented] (KAFKA-330) Add delete topic support

[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884896#comment-13884896 ] Neha Narkhede commented on KAFKA-330: - Updated reviewboard https://reviews.apache.org/r

Re: Review Request 17460: Patch for KAFKA-330

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17460/ --- (Updated Jan. 28, 2014, 11:19 p.m.) Review request for kafka. Bugs: KAFKA-330

Re: Review Request 17460: Patch for KAFKA-330

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17460/#review33056 --- In all, I would vote for marking the deletion as failed when some br

Re: Review Request 17460: Patch for KAFKA-330

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17460/#review33050 --- core/src/main/scala/kafka/controller/KafkaController.scala

Re: Review Request 17460: Patch for KAFKA-330

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17460/ --- (Updated Jan. 28, 2014, 9:25 p.m.) Review request for kafka. Bugs: KAFKA-330

Re: Review Request 17460: Patch for KAFKA-330

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17460/#review33046 --- core/src/main/scala/kafka/controller/ControllerChannelManager.scala

Re: Review Request 17263: New producer for Kafka.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17263/#review33033 --- Overall, this looks great. Here are a few comments - I have some mor

[jira] [Updated] (KAFKA-1028) per topic configuration of preference for consistency over availability

[ https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Olson updated KAFKA-1028: Attachment: KAFKA-1028.patch Attaching patch for consideration. Here's a summary of the new broker

[jira] [Commented] (KAFKA-330) Add delete topic support

[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884468#comment-13884468 ] Neha Narkhede commented on KAFKA-330: - Delete topic is a pretty tricky feature and ther

Re: Review Request 17460: Patch for KAFKA-330

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17460/ --- (Updated Jan. 28, 2014, 7:15 p.m.) Review request for kafka. Bugs: KAFKA-330

Re: Review Request 17460: Patch for KAFKA-330

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17460/ --- (Updated Jan. 28, 2014, 7:13 p.m.) Review request for kafka. Bugs: KAFKA-330

Review Request 17460: Patch for KAFKA-330

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17460/ --- Review request for kafka. Bugs: KAFKA-330 https://issues.apache.org/jira/br

Re: Review Request 17460: Patch for KAFKA-330

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17460/ --- (Updated Jan. 28, 2014, 7:06 p.m.) Review request for kafka. Bugs: KAFKA-330

[jira] [Commented] (KAFKA-330) Add delete topic support

[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884441#comment-13884441 ] Neha Narkhede commented on KAFKA-330: - Created reviewboard https://reviews.apache.org/r

[jira] [Updated] (KAFKA-330) Add delete topic support

[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-330: Attachment: KAFKA-330.patch > Add delete topic support > - > >

Re: Review Request 17006: Check if there are hanging producer threads in stopping all entities

> On Jan. 27, 2014, 7:01 p.m., Neha Narkhede wrote: > > system_test/utils/kafka_system_test_utils.py, line 1490 > > > > > > wouldn't this only kill the producer that is on localhost. But seems > > like stop_remote_en

Re: Review Request 17006: Check if there are hanging producer threads in stopping all entities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17006/ --- (Updated Jan. 28, 2014, 5:26 p.m.) Review request for kafka. Summary (updated

[jira] [Commented] (KAFKA-1212) System test exception handling does not stop background producer threads

[ https://issues.apache.org/jira/browse/KAFKA-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884346#comment-13884346 ] Guozhang Wang commented on KAFKA-1212: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1212) System test exception handling does not stop background producer threads

[ https://issues.apache.org/jira/browse/KAFKA-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1212: - Attachment: KAFKA-1212_2014-01-28_09:25:56.patch > System test exception handling does not stop b