> On Jan. 27, 2014, 7:01 p.m., Neha Narkhede wrote: > > system_test/utils/kafka_system_test_utils.py, line 1490 > > <https://reviews.apache.org/r/17006/diff/6/?file=451631#file451631line1490> > > > > wouldn't this only kill the producer that is on localhost. But seems > > like stop_remote_entity()'s goal is to kill the producer on any remote host? > > Guozhang Wang wrote: > Remotely a producer performance process will be started, which will > terminate itself when the number of messages specified has been sent. So we > only need to stop the local script which periodically kicks off new producer > performance remotely.
I see. Makes sense. Though I was hoping to see a more generic "stop_local_processes()" and "stop_remote_processes()" APIs. - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17006/#review32857 ----------------------------------------------------------- On Jan. 28, 2014, 5:26 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17006/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 5:26 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1212 > https://issues.apache.org/jira/browse/KAFKA-1212 > > > Repository: kafka > > > Description > ------- > > KAFKA-1212.v3.4 > > > KAFKA-1212.v3.3 > > > KAFKA-1212.v3.2 > > > KAFKA-1212.v3.1 > > > KAFKA-1212.v3 > > > KAFKA-1212.v2 > > > Diffs > ----- > > system_test/utils/kafka_system_test_utils.py > fb4a9c05bf6f39a7abf41126325ed5ca26bcc246 > > Diff: https://reviews.apache.org/r/17006/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
