Re: Review Request 17055: Patch for KAFKA-1055

2014-01-21 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17055/#review32474 --- Ship it! Ship It! - Neha Narkhede On Jan. 21, 2014, 9:29 p.m., G

[jira] [Created] (KAFKA-1213) Adding fetcher needs to be avoided upon make-follower when replica manager is shutting down

2014-01-21 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1213: Summary: Adding fetcher needs to be avoided upon make-follower when replica manager is shutting down Key: KAFKA-1213 URL: https://issues.apache.org/jira/browse/KAFKA-1213

[jira] [Updated] (KAFKA-1188) Stale LeaderAndIsr request could be handled by the broker on Controller failover

2014-01-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1188: - Attachment: KAFKA-1188_2014-01-21_14:01:22.patch > Stale LeaderAndIsr request could be handled by

[jira] [Commented] (KAFKA-1188) Stale LeaderAndIsr request could be handled by the broker on Controller failover

2014-01-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877906#comment-13877906 ] Guozhang Wang commented on KAFKA-1188: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 16360: Patch for KAFKA-1188

2014-01-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/ --- (Updated Jan. 21, 2014, 10:01 p.m.) Review request for kafka. Summary (update

Re: Review Request 16360: Address comments from Neha, and record error messages if leader brokers are not available since this should not happen then

2014-01-21 Thread Guozhang Wang
> On Jan. 18, 2014, 2:17 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 425 > > > > > > "aborted the become-follower state change"... > > > > Also, I'm not sure this sh

[jira] [Commented] (KAFKA-1055) BrokerTopicStats is updated before checking for MessageSizeTooLarge

2014-01-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877878#comment-13877878 ] Guozhang Wang commented on KAFKA-1055: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1055) BrokerTopicStats is updated before checking for MessageSizeTooLarge

2014-01-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1055: - Attachment: KAFKA-1055_2014-01-21_13:29:04.patch > BrokerTopicStats is updated before checking fo

Re: Review Request 17055: Patch for KAFKA-1055

2014-01-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17055/ --- (Updated Jan. 21, 2014, 9:29 p.m.) Review request for kafka. Bugs: KAFKA-1055

[jira] [Commented] (KAFKA-1212) System test exception handling does not stop background producer threads

2014-01-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877868#comment-13877868 ] Guozhang Wang commented on KAFKA-1212: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1212) System test exception handling does not stop background producer threads

2014-01-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1212: - Attachment: KAFKA-1212_2014-01-21_13:20:59.patch > System test exception handling does not stop b

Re: Review Request 17006: Patch for KAFKA-1212

2014-01-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17006/ --- (Updated Jan. 21, 2014, 9:21 p.m.) Review request for kafka. Bugs: KAFKA-1212

gradle patch timeline

2014-01-21 Thread Jay Kreps
Hey David, I have a pretty largish patch with a reimplementation of the producer. At the moment this is a stand alone code base. I wanted to get a patch up that integrates this with the kafka code base as a new sub-project module for the new producer and (eventually) the consumer as well. I wante

kafka pull request: Added changes so that bin/*.sh files can work with CYGW...

2014-01-21 Thread aloklal99
GitHub user aloklal99 opened a pull request: https://github.com/apache/kafka/pull/13 Added changes so that bin/*.sh files can work with CYGWIN under windows,... ### Background The script files to run Kafka under Windows don't work as is. One needs to hand tweak them since their

Re: Kafka server start from resource negotiator(s)

2014-01-21 Thread Jun Rao
Hi, Joe, Thanks for the update. This looks great. A couple of questions and comments. 1. How general is the framework? For example, if I want to add the support for Apache Yarn, is anything there can be reused? 2. My current feeling is that it's probably better to maintain those container suppor

Re: Review Request 17006: Patch for KAFKA-1212

2014-01-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17006/#review32382 --- system_test/utils/kafka_system_test_utils.py

Re: Review Request 17055: Patch for KAFKA-1055

2014-01-21 Thread Guozhang Wang
> On Jan. 20, 2014, 5:35 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 244 > > > > > > It is useful to know the incoming byte rate to a Kafka broker, in > > addition to knowing