> On Jan. 18, 2014, 2:17 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 425 > > <https://reviews.apache.org/r/16360/diff/6/?file=425126#file425126line425> > > > > "aborted the become-follower state change"... > > > > Also, I'm not sure this shutting down check is doing what we really > > want. > > i.e., the replica fetcher manager may be shutdown right after this, and > > we > > could still add fetchers. But that's a separate issue, and I may have > > misread the code. > > > >
I agree with you, this check does not actually avoid adding fetchers while at the same time shutting down fetcher manager. Will file another jira for this. > On Jan. 18, 2014, 2:17 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 376 > > <https://reviews.apache.org/r/16360/diff/6/?file=425126#file425126line376> > > > > I'm wondering if it would make the code cleaner/clearer if you move all > > the > > code below that deals with partitionsToMakeFollower to this block of > > the if > > statement. > > We use the current pattern because we want to do adding-fetcher and truncating log in batch, moving them into the if statement will revert to the one-by-one pattern. - Guozhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/#review32242 ----------------------------------------------------------- On Jan. 16, 2014, 11:02 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16360/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 11:02 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1188 > https://issues.apache.org/jira/browse/KAFKA-1188 > > > Repository: kafka > > > Description > ------- > > KAFKA-1188.v6 > > > KAFKA-1188.v5.1 > > > KAFKA-1188.v5 > > > Dummy > > > KAFKA-1188.v4 > > > KAFKA-1188.v3 > > > KAFKA-1118.v2 > > > KAFKA-1188.v1 > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > 1087a2e91c86e36a2494a95913a3ec2daf238287 > core/src/main/scala/kafka/controller/ReplicaStateMachine.scala > 483559aa64726c51320d18b64a1b48f8fb2905a0 > core/src/main/scala/kafka/server/ReplicaManager.scala > f9d10d385cee49a1e3be8c82e3ffa22ef87a8fd6 > > Diff: https://reviews.apache.org/r/16360/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
