[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846071#comment-13846071 ] David Arthur commented on KAFKA-1171: - I dusted off the Ant build I put together a whi

[jira] [Closed] (KAFKA-1134) onControllerFailover function should be synchronized with other functions

[ https://issues.apache.org/jira/browse/KAFKA-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1134. > onControllerFailover function should be synchronized with other functions > -

[jira] [Resolved] (KAFKA-1134) onControllerFailover function should be synchronized with other functions

[ https://issues.apache.org/jira/browse/KAFKA-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1134. -- Resolution: Fixed Thanks for the patch. Committed to trunk > onControllerFailover function sho

[jira] [Updated] (KAFKA-1134) onControllerFailover function should be synchronized with other functions

[ https://issues.apache.org/jira/browse/KAFKA-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1134: - Assignee: Guozhang Wang > onControllerFailover function should be synchronized with other functio

[jira] [Resolved] (KAFKA-1142) Patch review tool should take diff with origin from last divergent point

[ https://issues.apache.org/jira/browse/KAFKA-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1142. -- Resolution: Fixed Committed the patch to trunk. Thanks! > Patch review tool should take diff w

[jira] [Closed] (KAFKA-1142) Patch review tool should take diff with origin from last divergent point

[ https://issues.apache.org/jira/browse/KAFKA-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1142. > Patch review tool should take diff with origin from last divergent point > --

Re: Review Request 16143: Patch for KAFKA-1142

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16143/#review30237 --- Ship it! Ship It! - Neha Narkhede On Dec. 10, 2013, 12:11 a.m.,

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review30236 --- core/src/main/scala/kafka/controller/KafkaController.scala

[jira] [Resolved] (KAFKA-1178) Replica fetcher thread dies while becoming follower

[ https://issues.apache.org/jira/browse/KAFKA-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1178. -- Resolution: Fixed Thanks for the reviews, committed the patch to trunk > Replica fetcher threa

[jira] [Closed] (KAFKA-1178) Replica fetcher thread dies while becoming follower

[ https://issues.apache.org/jira/browse/KAFKA-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1178. > Replica fetcher thread dies while becoming follower > ---

[jira] [Commented] (KAFKA-1178) Replica fetcher thread dies while becoming follower

[ https://issues.apache.org/jira/browse/KAFKA-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845642#comment-13845642 ] Neha Narkhede commented on KAFKA-1178: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1178) Replica fetcher thread dies while becoming follower

[ https://issues.apache.org/jira/browse/KAFKA-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1178: - Attachment: KAFKA-1178_2013-12-11_11:09:09.patch > Replica fetcher thread dies while becoming fol

Re: Review Request 16175: Patch for KAFKA-1178

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16175/ --- (Updated Dec. 11, 2013, 7:09 p.m.) Review request for kafka. Bugs: KAFKA-1178

Re: Review Request 16175: Patch for KAFKA-1178

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16175/#review30214 --- Ship it! Looks good. I would be good to expand the comments before

[jira] [Created] (KAFKA-1179) createMessageStreams() in javaapi.ZookeeperConsumerConnector does not throw

Vincent Rischmann created KAFKA-1179: Summary: createMessageStreams() in javaapi.ZookeeperConsumerConnector does not throw Key: KAFKA-1179 URL: https://issues.apache.org/jira/browse/KAFKA-1179 Pro

[jira] [Updated] (KAFKA-1178) Replica fetcher thread dies while becoming follower

[ https://issues.apache.org/jira/browse/KAFKA-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1178: - Attachment: KAFKA-1178_2013-12-11_10:30:19.patch > Replica fetcher thread dies while becoming fol

[jira] [Commented] (KAFKA-1178) Replica fetcher thread dies while becoming follower

[ https://issues.apache.org/jira/browse/KAFKA-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845605#comment-13845605 ] Neha Narkhede commented on KAFKA-1178: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 16175: Patch for KAFKA-1178

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16175/ --- (Updated Dec. 11, 2013, 6:30 p.m.) Review request for kafka. Bugs: KAFKA-1178

Re: Review Request 16175: Patch for KAFKA-1178

> On Dec. 11, 2013, 5:48 p.m., Jun Rao wrote: > > Thanks for the patch. > > > > 1. In Controller.updateLeaderEpochAndSendRequest(), the following comment > > seems not accurate. Could we fix it? > > // send the shrunk assigned replica list to all the replicas, > > including the leader,

Re: Review Request 16175: Patch for KAFKA-1178

> On Dec. 11, 2013, 5:08 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 237 > > > > > > Under which condition the broker will not be in the assigned replica > > list? Since

Re: Review Request 16175: Patch for KAFKA-1178

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16175/#review30204 --- Thanks for the patch. 1. In Controller.updateLeaderEpochAndSendRequ

Re: Review Request 16175: Patch for KAFKA-1178

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16175/#review30202 --- core/src/main/scala/kafka/server/ReplicaManager.scala

[jira] [Updated] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-1171: Attachment: 0001-Adding-basic-Gradle-build.patch Updating patch to include multi-scala plugin and g

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845481#comment-13845481 ] David Arthur commented on KAFKA-1171: - Made some progress with the multi-scala plugin

[jira] [Comment Edited] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845481#comment-13845481 ] David Arthur edited comment on KAFKA-1171 at 12/11/13 3:40 PM: -

[jira] [Issue Comment Deleted] (KAFKA-1177) DeleteTopics gives Successful message even if the specified Topic is not present

[ https://issues.apache.org/jira/browse/KAFKA-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddhesh Sundar Toraskar updated KAFKA-1177: Comment: was deleted (was: The kafka-330 issues resembles to this new kafka

[jira] [Updated] (KAFKA-1079) Liars in PrimitiveApiTest that promise to test api in compression mode, but don't do this actually

[ https://issues.apache.org/jira/browse/KAFKA-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostya Golikov updated KAFKA-1079: -- Attachment: testing-with-compression-v2.patch += New version of path with comments addressed (p

[jira] [Issue Comment Deleted] (KAFKA-1177) DeleteTopics gives Successful message even if the specified Topic is not present

[ https://issues.apache.org/jira/browse/KAFKA-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddhesh Sundar Toraskar updated KAFKA-1177: Comment: was deleted (was: Kafka-1177 related much to the Kafka-330. As the

[jira] [Commented] (KAFKA-1177) DeleteTopics gives Successful message even if the specified Topic is not present

[ https://issues.apache.org/jira/browse/KAFKA-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845213#comment-13845213 ] Siddhesh Sundar Toraskar commented on KAFKA-1177: - Kafka-1177 related much

[jira] [Commented] (KAFKA-1177) DeleteTopics gives Successful message even if the specified Topic is not present

[ https://issues.apache.org/jira/browse/KAFKA-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845210#comment-13845210 ] Siddhesh Sundar Toraskar commented on KAFKA-1177: - The kafka-330 issues re

[jira] [Commented] (KAFKA-1177) DeleteTopics gives Successful message even if the specified Topic is not present

[ https://issues.apache.org/jira/browse/KAFKA-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845176#comment-13845176 ] Siddhesh Sundar Toraskar commented on KAFKA-1177: - Forgot to mention anoth

[jira] [Commented] (KAFKA-1177) DeleteTopics gives Successful message even if the specified Topic is not present

[ https://issues.apache.org/jira/browse/KAFKA-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845174#comment-13845174 ] Siddhesh Sundar Toraskar commented on KAFKA-1177: - Hi Jun, I think i d