Re: Changed ordering guarantee with multiple in-flight messages

2013-11-21 Thread Joel Koshy
I can elaborate further on the wiki tomorrow. The term in-flight in my edit is a bit incomplete. It refers to what's "in-flight" on the broker-side for actual handling - that is what provides the ordering guarantee. The client can continue to write requests to the socket even while the broker is ha

Changed ordering guarantee with multiple in-flight messages

2013-11-21 Thread Magnus Edenhill
Hi, I noticed Joel Koshy's update to the protocol guide wiki at https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol This sentence was added: "The broker allows only a single in-flight request per connection in order to guarantee this ordering" Adding such a constraint

[jira] [Resolved] (KAFKA-933) Hadoop example running DataGenerator causes kafka.message.Message cannot be cast to [B exception

2013-11-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-933. --- Resolution: Fixed Thanks for the patch. Committed to trunk. > Hadoop example running DataGenerator causes kaf

[jira] [Commented] (KAFKA-1103) Consumer uses two zkclients

2013-11-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829671#comment-13829671 ] Guozhang Wang commented on KAFKA-1103: -- Wired. I already did a rebase and git diff di

[jira] [Commented] (KAFKA-1103) Consumer uses two zkclients

2013-11-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829659#comment-13829659 ] Jun Rao commented on KAFKA-1103: Do you really intend to delete the following in the patch

[jira] [Assigned] (KAFKA-1141) make changes to downloads for the archive old releases to new old_releases folder

2013-11-21 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein reassigned KAFKA-1141: Assignee: Joe Stein > make changes to downloads for the archive old releases to new old_releases >

[jira] [Created] (KAFKA-1141) make changes to downloads for the archive old releases to new old_releases folder

2013-11-21 Thread Joe Stein (JIRA)
Joe Stein created KAFKA-1141: Summary: make changes to downloads for the archive old releases to new old_releases folder Key: KAFKA-1141 URL: https://issues.apache.org/jira/browse/KAFKA-1141 Project: Kafk

[jira] [Comment Edited] (KAFKA-933) Hadoop example running DataGenerator causes kafka.message.Message cannot be cast to [B exception

2013-11-21 Thread drunkedcat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829627#comment-13829627 ] drunkedcat edited comment on KAFKA-933 at 11/22/13 3:54 AM: as

[jira] [Comment Edited] (KAFKA-933) Hadoop example running DataGenerator causes kafka.message.Message cannot be cast to [B exception

2013-11-21 Thread drunkedcat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829627#comment-13829627 ] drunkedcat edited comment on KAFKA-933 at 11/22/13 3:44 AM: as

[jira] [Commented] (KAFKA-933) Hadoop example running DataGenerator causes kafka.message.Message cannot be cast to [B exception

2013-11-21 Thread drunkedcat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829627#comment-13829627 ] drunkedcat commented on KAFKA-933: -- as 0.8.0-bete1, the following change will work:

[jira] [Commented] (KAFKA-1136) Add subAppend in Log4jAppender for generic usage

2013-11-21 Thread Jie Huang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829610#comment-13829610 ] Jie Huang commented on KAFKA-1136: -- Thanks. > Add subAppend in Log4jAppender for generi

[jira] [Updated] (KAFKA-1140) Move the decoding logic from ConsumerIterator.makeNext to next

2013-11-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1140: -- Fix Version/s: 0.8.1 > Move the decoding logic from ConsumerIterator.makeNext to next > ---

[jira] [Updated] (KAFKA-1136) Add subAppend in Log4jAppender for generic usage

2013-11-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1136: -- Fix Version/s: 0.8.1 > Add subAppend in Log4jAppender for generic usage > -

[jira] [Commented] (KAFKA-1136) Add subAppend in Log4jAppender for generic usage

2013-11-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829596#comment-13829596 ] Joel Koshy commented on KAFKA-1136: --- Seems reasonable to me - we can do this on trunk.

[jira] [Created] (KAFKA-1140) Move the decoding logic from ConsumerIterator.makeNext to next

2013-11-21 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1140: Summary: Move the decoding logic from ConsumerIterator.makeNext to next Key: KAFKA-1140 URL: https://issues.apache.org/jira/browse/KAFKA-1140 Project: Kafka

[jira] [Resolved] (KAFKA-1137) Problem of FetchRequest API

2013-11-21 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-1137. --- Resolution: Invalid Closing - this behavior is documented here: https://cwiki.apache.org/confluence/

[jira] [Commented] (KAFKA-1103) Consumer uses two zkclients

2013-11-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829078#comment-13829078 ] Jun Rao commented on KAFKA-1103: The latest patch reverted some of the old commits. Could

[jira] [Commented] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2013-11-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829263#comment-13829263 ] Guozhang Wang commented on KAFKA-404: - Thanks for the patch, a few comments: 1. val pa

[jira] [Commented] (KAFKA-1103) Consumer uses two zkclients

2013-11-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829244#comment-13829244 ] Guozhang Wang commented on KAFKA-1103: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-404) When using chroot path, create chroot on startup if it doesn't exist

2013-11-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-404: Affects Version/s: (was: 0.7.1) 0.8.1 > When using chroot path, create ch

[jira] [Updated] (KAFKA-1103) Consumer uses two zkclients

2013-11-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1103: - Attachment: KAFKA-1103_2013-11-21_11:22:04.patch > Consumer uses two zkclients >

Re: Review Request 15659: Incorporate Joel/Jun's comments, MM system test passed, rebased

2013-11-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15659/ --- (Updated Nov. 21, 2013, 7:22 p.m.) Review request for kafka. Summary (updated

[jira] Subscription: outstanding kafka patches

2013-11-21 Thread jira
Issue Subscription Filter: outstanding kafka patches (75 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1136 Add subAppend in Log4jAppender for generic usage https://issues.apache.org/jira/browse/KAFKA-1136 KAFKA-1133 LICENSE an

[jira] [Commented] (KAFKA-1138) Remote producer uses the hostname defined in broker

2013-11-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829077#comment-13829077 ] Jun Rao commented on KAFKA-1138: Do you think https://issues.apache.org/jira/browse/KAFKA-

Re: Review Request 15711: Patch for KAFKA-930

2013-11-21 Thread Jun Rao
> On Nov. 20, 2013, 6:30 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, lines 236-239 > > > > > > I am wondering if this config is really necessary. Wouldn't it be > > simpler to always d

[jira] [Created] (KAFKA-1139) Topic data change handling callback should not call syncedRebalance directly

2013-11-21 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1139: Summary: Topic data change handling callback should not call syncedRebalance directly Key: KAFKA-1139 URL: https://issues.apache.org/jira/browse/KAFKA-1139 Project: K

Re: Review Request 15711: Patch for KAFKA-930

2013-11-21 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review29242 --- core/src/main/scala/kafka/controller/KafkaController.scala

[jira] [Commented] (KAFKA-930) Integrate preferred replica election logic into kafka

2013-11-21 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829130#comment-13829130 ] Sriram Subramanian commented on KAFKA-930: -- Updated reviewboard https://reviews.ap

Re: Review Request 15711: Patch for KAFKA-930

2013-11-21 Thread Sriram Subramanian
> On Nov. 21, 2013, 3:41 a.m., Swapnil Ghike wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, lines 745-746 > > > > > > Should we always delete the admin path? Because if auto rebalance > > achie

Re: Review Request 15711: Patch for KAFKA-930

2013-11-21 Thread Sriram Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/ --- (Updated Nov. 21, 2013, 5:42 p.m.) Review request for kafka. Bugs: KAFKA-930

[jira] [Updated] (KAFKA-930) Integrate preferred replica election logic into kafka

2013-11-21 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriram Subramanian updated KAFKA-930: - Attachment: KAFKA-930_2013-11-21_09:42:11.patch > Integrate preferred replica election log

Re: Review Request 15711: Patch for KAFKA-930

2013-11-21 Thread Sriram Subramanian
> On Nov. 21, 2013, 2:43 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, line 944 > > > > > > Any reason to not call onPreferredReplicaElection on the entire set of > > partitio

Re: Review Request 15711: Patch for KAFKA-930

2013-11-21 Thread Sriram Subramanian
> On Nov. 20, 2013, 6:30 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, lines 745-746 > > > > > > Could we rename updateZk to sth like isTriggeredByCommandLine? > > Sriram Subrama

Re: Review Request 15711: Patch for KAFKA-930

2013-11-21 Thread Sriram Subramanian
> On Nov. 21, 2013, 3:41 a.m., Swapnil Ghike wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, line 926 > > > > > > rename to topicPartitionsNotLedByPreferredReplica? PreferredReplica cannot lead

Re: Review Request 15711: Patch for KAFKA-930

2013-11-21 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review29240 --- core/src/main/scala/kafka/controller/KafkaController.scala