[jira] [Updated] (KAFKA-1053) Kafka patch review tool

[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1053: - Attachment: KAFKA-1053_2013-09-15_20:28:01.patch > Kafka patch review tool >

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768036#comment-13768036 ] Neha Narkhede commented on KAFKA-1053: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 14091: Patch for KAFKA-1053

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/ --- (Updated Sept. 16, 2013, 3:28 a.m.) Review request for kafka. Bugs: KAFKA-105

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767978#comment-13767978 ] Swapnil Ghike commented on KAFKA-1053: -- 1. RHEL machine is on python 2.7.2. Maybe the

[jira] [Commented] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767976#comment-13767976 ] Swapnil Ghike commented on KAFKA-1003: -- Created reviewboard > Consu

[jira] [Updated] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1003: - Attachment: KAFKA-1003.patch > ConsumerFetcherManager should pass clientId as metricsPrefix t

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767974#comment-13767974 ] Neha Narkhede commented on KAFKA-1053: -- Thanks for giving it a spin, though I'm not s

[jira] [Comment Edited] (KAFKA-1053) Kafka patch review tool

[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767967#comment-13767967 ] Swapnil Ghike edited comment on KAFKA-1053 at 9/16/13 12:38 AM:

[jira] [Commented] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767966#comment-13767966 ] Swapnil Ghike commented on KAFKA-1003: -- Created reviewboard > Consu

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767967#comment-13767967 ] Swapnil Ghike commented on KAFKA-1053: -- Hmm, tried setting up the tool according to t

[jira] [Updated] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1003: - Attachment: KAFKA-1003.patch > ConsumerFetcherManager should pass clientId as metricsPrefix t

[jira] [Commented] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767963#comment-13767963 ] Swapnil Ghike commented on KAFKA-1003: -- Created reviewboard > Consu

[jira] [Updated] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1003: - Attachment: KAFKA-1003.patch > ConsumerFetcherManager should pass clientId as metricsPrefix t

[jira] [Updated] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1003: - Attachment: KAFKA-1003.patch > ConsumerFetcherManager should pass clientId as metricsPrefix t

[jira] [Commented] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767962#comment-13767962 ] Swapnil Ghike commented on KAFKA-1003: -- Created reviewboard > Consu

[jira] [Commented] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767961#comment-13767961 ] Swapnil Ghike commented on KAFKA-1003: -- Created reviewboard > Consu

[jira] [Updated] (KAFKA-1003) ConsumerFetcherManager should pass clientId as metricsPrefix to AbstractFetcherManager

[ https://issues.apache.org/jira/browse/KAFKA-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-1003: - Attachment: KAFKA-1003.patch > ConsumerFetcherManager should pass clientId as metricsPrefix t

[jira] [Commented] (KAFKA-1011) Decompression and re-compression on MirrorMaker could result in messages being dropped in the pipeline

[ https://issues.apache.org/jira/browse/KAFKA-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767850#comment-13767850 ] Neha Narkhede commented on KAFKA-1011: -- I think using the SyncProducer in the MirrorM

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767843#comment-13767843 ] Neha Narkhede commented on KAFKA-1053: -- I think this tool will be easier to use if it

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767841#comment-13767841 ] Neha Narkhede commented on KAFKA-1053: -- Thanks for the review comments, [~swapnilghik

[jira] [Commented] (KAFKA-1053) Kafka patch review tool

[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767840#comment-13767840 ] Neha Narkhede commented on KAFKA-1053: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1053) Kafka patch review tool

[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1053: - Attachment: KAFKA-1053-2013-09-15_09:40:04.patch > Kafka patch review tool >

Re: Review Request 14091: Patch for KAFKA-1053

> On Sept. 14, 2013, 7:07 p.m., Swapnil Ghike wrote: > > kafka-patch-review.py, lines 50-51 > > > > > > Do you intend to save the patch file in current directory? I wonder if > > we should delete it, because it is mor

Re: Review Request 14091: Patch for KAFKA-1053

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/ --- (Updated Sept. 15, 2013, 4:40 p.m.) Review request for kafka. Bugs: KAFKA-105

Re: Random Partitioning Issue

Let me ask another question which I think is more objective. Let's say 100 random, smart infrastructure specialists try Kafka, of these 100 how many do you believe will 1. Say that this behavior is what they expected to happen? 2. Be happy with this behavior? I am not being facetious I am genuinely

Re: Random Partitioning Issue

I just took a look at this change. I agree with Joe, not to put to fine a point on it, but this is a confusing hack. Jun, I don't think wanting to minimizing the number of TCP connections is going to be a very common need for people with less than 10k producers. I also don't think people are going