[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767974#comment-13767974 ]
Neha Narkhede commented on KAFKA-1053: -------------------------------------- Thanks for giving it a spin, though I'm not sure you are using the latest version of the tool. 1. For the argparse error, I'm not too sure if it is because argparse requires Python 2.7.x ? Could you try upgrading Python to 2.7.x and see if it works? 2. To upload a patch using the tool, the code must be committed to the local branch else the diff is empty. But I think that points to a potential improvement to the tool. If the diff is empty, it can skip uploading the patch and creating the rb. > Kafka patch review tool > ----------------------- > > Key: KAFKA-1053 > URL: https://issues.apache.org/jira/browse/KAFKA-1053 > Project: Kafka > Issue Type: New Feature > Components: tools > Reporter: Neha Narkhede > Assignee: Neha Narkhede > Attachments: KAFKA-1053-2013-09-15_09:40:04.patch, > KAFKA-1053-followup2.patch, KAFKA-1053-followup.patch, KAFKA-1053-v1.patch, > KAFKA-1053-v1.patch, KAFKA-1053-v1.patch, KAFKA-1053-v2.patch, > KAFKA-1053-v3.patch > > > Created a new patch review tool that will integrate JIRA and reviewboard - > https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira