[jira] [Commented] (KAFKA-681) Unclean shutdown testing - truncateAndStartWithNewOffset is not invoked when it is expected to

2013-01-03 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543666#comment-13543666 ] Neha Narkhede commented on KAFKA-681: - +1 > Unclean shutdown testing

[jira] [Commented] (KAFKA-681) Unclean shutdown testing - truncateAndStartWithNewOffset is not invoked when it is expected to

2013-01-03 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543601#comment-13543601 ] Joel Koshy commented on KAFKA-681: -- +1 > Unclean shutdown testing - trunc

[jira] [Commented] (KAFKA-648) Use uniform convention for naming properties keys

2013-01-03 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543554#comment-13543554 ] Jun Rao commented on KAFKA-648: --- Thanks for the patch. Some comments: 1. ConsumerConfig: We

[jira] [Updated] (KAFKA-681) Unclean shutdown testing - truncateAndStartWithNewOffset is not invoked when it is expected to

2013-01-03 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-681: -- Labels: bugs (was: ) Priority: Blocker (was: Major) Affects Version/s: 0.8 > U

[jira] [Updated] (KAFKA-681) Unclean shutdown testing - truncateAndStartWithNewOffset is not invoked when it is expected to

2013-01-03 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-681: -- Attachment: kafka-681_v1.patch This is actually caused by a real bug. When reading high watermarks from the fil

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2013-01-03 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543459#comment-13543459 ] Jay Kreps commented on KAFKA-657: - Works for me. > Add an API to commit of

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2013-01-03 Thread David Arthur (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543448#comment-13543448 ] David Arthur commented on KAFKA-657: I have "offset.metadata.max.size" for the time bei

[jira] [Updated] (KAFKA-648) Use uniform convention for naming properties keys

2013-01-03 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriram Subramanian updated KAFKA-648: - Fix Version/s: 0.8 Status: Patch Available (was: In Progress) 1. Ensured that

[jira] [Updated] (KAFKA-648) Use uniform convention for naming properties keys

2013-01-03 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriram Subramanian updated KAFKA-648: - Attachment: configchanges-1.patch > Use uniform convention for naming properties keys

[jira] [Work started] (KAFKA-648) Use uniform convention for naming properties keys

2013-01-03 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-648 started by Sriram Subramanian. > Use uniform convention for naming properties keys > -- > >

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2013-01-03 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543277#comment-13543277 ] Jay Kreps commented on KAFKA-657: - Yeah that is the right place for a new config. It is wor

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2013-01-03 Thread David Arthur (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543227#comment-13543227 ] David Arthur commented on KAFKA-657: We had talked about limiting the size of the metad

[jira] [Commented] (KAFKA-681) Unclean shutdown testing - truncateAndStartWithNewOffset is not invoked when it is expected to

2013-01-03 Thread John Fung (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543228#comment-13543228 ] John Fung commented on KAFKA-681: - To reproduce the issue: 1. Download the latest 0.8 branc

[jira] [Updated] (KAFKA-681) Unclean shutdown testing - truncateAndStartWithNewOffset is not invoked when it is expected to

2013-01-03 Thread John Fung (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Fung updated KAFKA-681: Attachment: kafka-681-reproduce-issue.patch Uploaded kafka-681-reproduce-issue.patch > Uncl

[jira] [Commented] (KAFKA-681) Unclean shutdown testing - truncateAndStartWithNewOffset is not invoked when it is expected to

2013-01-03 Thread John Fung (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543222#comment-13543222 ] John Fung commented on KAFKA-681: - Test description (compression off): 1. Start 2 brokers B

[jira] [Created] (KAFKA-681) Unclean shutdown testing - truncateAndStartWithNewOffset is not invoked when it is expected to

2013-01-03 Thread John Fung (JIRA)
John Fung created KAFKA-681: --- Summary: Unclean shutdown testing - truncateAndStartWithNewOffset is not invoked when it is expected to Key: KAFKA-681 URL: https://issues.apache.org/jira/browse/KAFKA-681 Proj

[jira] Subscription: outstanding kafka patches

2013-01-03 Thread jira
Issue Subscription Filter: outstanding kafka patches (54 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-677 Retention process gives exception if an empty segment is chosen for collection https://issues.apache.org/jira/b

[jira] [Work started] (KAFKA-680) ApiUtils#writeShortString uses String length instead of byte length

2013-01-03 Thread David Arthur (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-680 started by David Arthur. > ApiUtils#writeShortString uses String length instead of byte length >

[jira] [Updated] (KAFKA-680) ApiUtils#writeShortString uses String length instead of byte length

2013-01-03 Thread David Arthur (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-680: --- Attachment: KAFKA-680.patch > ApiUtils#writeShortString uses String length instead of byte length

[jira] [Created] (KAFKA-680) ApiUtils#writeShortString uses String length instead of byte length

2013-01-03 Thread David Arthur (JIRA)
David Arthur created KAFKA-680: -- Summary: ApiUtils#writeShortString uses String length instead of byte length Key: KAFKA-680 URL: https://issues.apache.org/jira/browse/KAFKA-680 Project: Kafka

Re: git workflow

2013-01-03 Thread Jun Rao
Thanks for documenting this. Could you also add how to resolve conflicts during rebase? Jun On Wed, Jan 2, 2013 at 1:45 PM, Jay Kreps wrote: > I don't know about other people but I find git kind of confusing. I thought > it would be useful to try to document the normal workflow for different us