Re: [jira] [Created] (JSPWIKI-1197) Deleting an attachment via filesystem causes jsp wiki to complete crash

2024-08-17 Thread Murray Altheim
Hi Alex, I think you're missing the main point here: a file was deleted or was deleted accidentally by an out of band application (git). Applications cannot be responsible for people with admin rights manually deleting files within their directory trees. I know of no application that is, ever, an

Re: [jira] [Created] (JSPWIKI-1197) Deleting an attachment via filesystem causes jsp wiki to complete crash

2024-08-17 Thread Alex O'Ree
Consider a user uploading a malicious file that gets past all of jspwiki's checks but is caught by the antivirus software and deleted. Same problem, now jspwiki won't boot. It's a denial of service attack. This is probably an easy 5 minute fix, way longer than you and I have argued about this. On

[jira] [Updated] (JSPWIKI-1189) Switching from wysiwyg editing to plain text leaves behind an overlay

2024-08-17 Thread Alex O'Ree (Jira)
[ https://issues.apache.org/jira/browse/JSPWIKI-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex O'Ree updated JSPWIKI-1189: Attachment: image-2024-08-17-10-21-42-014.png > Switching from wysiwyg editing to plain text leav

[jira] [Commented] (JSPWIKI-1189) Switching from wysiwyg editing to plain text leaves behind an overlay

2024-08-17 Thread Alex O'Ree (Jira)
[ https://issues.apache.org/jira/browse/JSPWIKI-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874513#comment-17874513 ] Alex O'Ree commented on JSPWIKI-1189: - had some time to look into this. It looks li

Re: [jira] [Created] (JSPWIKI-1197) Deleting an attachment via filesystem causes jsp wiki to complete crash

2024-08-17 Thread Murray Altheim
I agree, we've spent too much time discussing this. I don't consider this an argument, it's not personal and it's not win-lose. This is solely about the issue at hand and whether or not the out-of-band actions of external agents (whether human or software) upon JSPWiki's installation are a problem

[PR] Bug/jspwiki 1197 startup crash due to missing attachment [jspwiki]

2024-08-17 Thread via GitHub
spyhunter99 opened a new pull request, #360: URL: https://github.com/apache/jspwiki/pull/360 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Bug/jspwiki 1197 startup crash due to missing attachment [jspwiki]

2024-08-17 Thread via GitHub
spyhunter99 commented on PR #360: URL: https://github.com/apache/jspwiki/pull/360#issuecomment-2294888260 tested by the following - start the server - add an attachment to the main page, confirm it's attached and stored - delete just the uploaded file from the file system - confir

[jira] [Commented] (JSPWIKI-1197) Deleting an attachment via filesystem causes jsp wiki to completey crash

2024-08-17 Thread Alex O'Ree (Jira)
[ https://issues.apache.org/jira/browse/JSPWIKI-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874524#comment-17874524 ] Alex O'Ree commented on JSPWIKI-1197: - PR opened at github. took longer to test tha

[jira] [Updated] (JSPWIKI-1189) Switching from wysiwyg editing to plain text leaves behind an overlay

2024-08-17 Thread Alex O'Ree (Jira)
[ https://issues.apache.org/jira/browse/JSPWIKI-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex O'Ree updated JSPWIKI-1189: Attachment: image-2024-08-17-13-08-49-732.png > Switching from wysiwyg editing to plain text leav

[jira] [Commented] (JSPWIKI-1189) Switching from wysiwyg editing to plain text leaves behind an overlay

2024-08-17 Thread Alex O'Ree (Jira)
[ https://issues.apache.org/jira/browse/JSPWIKI-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874536#comment-17874536 ] Alex O'Ree commented on JSPWIKI-1189: - temporary work around is to comment out the