Re: Model of permissions for Ignite 3

2021-04-08 Thread Andrey Kuznetsov
operation inside a security plugin. > >But a developer has the opportunity to add custom logic. > > - Wildcards for permission's name from a box, for example, 'new > > CachePermission("x.y.z.*", "get,put")'. > > - There is no need to implement 'SecurityPermissionSet' and a set of > > methods from 'SecurityContex' ('xxxAllowed(String, SecurityPermission))'. > > - We can define a security policy in a file as java does. It could > > simplify work for administrators. > > > > WDYT? > > > -- Best regards, Andrey Kuznetsov.

Re: Add user attributes to thin clients

2020-01-22 Thread Andrey Kuznetsov
Hi, Pavel! Sometimes single authentication factor is not enough. Attributes proposed allow to add extra factors flexibly. ср, 22 янв. 2020 г., 17:39 Pavel Tupitsyn : > Token can be sent instead of a password (like git works with GitHub > tokens). > > For now I don't see a reason to include attri

Re: Add user attributes to thin clients

2020-01-28 Thread Andrey Kuznetsov
t; > > > > > > > > > > > > > > > > > > > > > > This approach doesn't looks like cross-platform. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > чт, 23 янв. 2020 г., 12:13 Alex Plehanov < > > > > > > > &

Re: [ANNOUNCE] New committer: Vyacheslav Koptilin

2020-02-18 Thread Andrey Kuznetsov
n process. This should enable better > productivity. > > Vyacheslav, thanks for supporting the community and keep the pace! > > Best Regards, > Dmitriy Pavlov > on behalf of Apache Ignite PMC > -- Best regards, Andrey Kuznetsov.

Re: Security Subject of thin client on remote nodes

2020-02-21 Thread Andrey Kuznetsov
gt; > > > > > > I have prepared PoC PR [3] that: > > > > > > - places the existing logic of spreading security context to > > > GridSecurityProcessor; > > > > > > - uses GridSecurityProcessor to get SecurityContext. > > > > > > > > > > > >1. > > > > > > > > > http://apache-ignite-developers.2346864.n4.nabble.com/JDBC-thin-client-incorrect-security-context-td45929.html > > >2. https://issues.apache.org/jira/browse/IGNITE-12589 > > >3. https://github.com/apache/ignite/pull/7375 > > > > > > -- Best regards, Andrey Kuznetsov.

Per-cache CACHE_CREATE/CACHE_DESTROY permissions handling

2020-03-25 Thread Andrey Kuznetsov
. Who could make final review, please? [1] https://issues.apache.org/jira/browse/IGNITE-12220 -- Best regards, Andrey Kuznetsov.

Re: Inconsistent API IgniteClient and REST

2020-03-31 Thread Andrey Kuznetsov
I suggest ADMIN_CACHE mark @Deprecated > > and replace it in the GridRestProcessor with CACHE_CREATE / > CACHE_DESTROY > > while maintaining backward compatibility for ADMIN_CACHE. > > > > This will allow us to remove ADMIN_CACHE in the future. > > > > > > > > Sergei Ryzhov > > s.vi.ryz...@gmail.com > > > > > > > > > > > > > > > > > > -- Best regards, Andrey Kuznetsov.

Re: Add user defined attributes to all GridClient messages.

2020-04-13 Thread Andrey Kuznetsov
91 > > I suggest solving this problem by adding user defined attributes to other > GridClient messages such as GridClientAutheticationRequest and so on. > > What do you think? > > Best regards > Oleg > > [1] > https://issues.apache.org/jira/browse/IGNITE-12049 > -- Best regards, Andrey Kuznetsov.

Re: Unreliable checks in tests for string presence in GridStringLogger contents

2019-02-01 Thread Andrey Kuznetsov
Hi, Sergey! Your note sounds convincing. +1 for adding throwing version of {{check}}. Best regards, Andrey Kuznetsov. вт, 29 янв. 2019, 19:14 Sergey macrerg...@gmail.com: > Hi! > I appreciate your efforts in replcacing GridStringLogger, just a remark. > I think it was a mistake to cha

Re: how to get zipkin tracing of REST calls from one microservice to all microservices calls from any task defined in apache ignite

2019-03-14 Thread Andrey Kuznetsov
u need any more info. > > > > Thanks, > > Aditya > > This email and any files transmitted with it are confidential, > proprietary and intended solely for the individual or entity to whom they > are addressed. If you have received this email in error please delete it > immediately. > > > > -- > Best regards, > Ivan Pavlukhin > -- Best regards, Andrey Kuznetsov.

Re: Ignite 2.7.5 Release scope

2019-03-25 Thread Andrey Kuznetsov
gt; >> > > > >> > > > >> > чт, 21 мар. 2019 г. в 16:55, Petr Ivanov : > > >> > > > >> > > Huge +1 > > >> > > > > >> > > Will try to add new JDK in nearest time to our Teamcity. > > >> > > > > >> > > > > >> > > > On 21 Mar 2019, at 16:27, Dmitriy Pavlov > > >> wrote: > > >> > > > > > >> > > > Hi Igniters, > > >> > > > > > >> > > > Meanwhile, Java 12 GA is available. I suggest at least test our > > new > > >> tests > > >> > > > scripts with a couple of Java builds. WDYT? > > >> > > > > > >> > > > Sincerely, > > >> > > > Dmitriy Pavlov > > >> > > > > > >> > > > ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov >: > > >> > > > > > >> > > >> Hi Ignite Developers, > > >> > > >> > > >> > > >> In a separate discussion, I've shared a log with all commits. > > >> > > >> > > >> > > >> As far as I can see, nobody removed commits from this sheet, so > > the > > >> > > scope > > >> > > >> of release will be discussed in another way: only explicitly > > >> declared > > >> > > >> commits will be cherry-picked. > > >> > > >> > > >> > > >> Sincerely, > > >> > > >> Dmitriy Pavlov > > >> > > >> > > >> > > > > >> > > > > >> > > > > > -- Best regards, Andrey Kuznetsov.

Re: GridDhtInvalidPartitionException takes the cluster down

2019-03-26 Thread Andrey Kuznetsov
gt; > > > > пн, 25 мар. 2019 г. в 08:38, Roman Shtykh : > > > > > > > Igniters, > > > > > > > > Restarting a node when injecting data and having it expired, results > at > > > > GridDhtInvalidPartitionException which terminates nodes with > > > > SYSTEM_WORKER_TERMINATION one by one taking the whole cluster down. > This > > > is > > > > really bad and I didn't find the way to save the cluster from > > > disappearing. > > > > I created a JIRA issue > > > https://issues.apache.org/jira/browse/IGNITE-11620 > > > > with a test case. Any clues how to fix this inconsistency when > > > rebalancing? > > > > > > > > -- Roman > > > > > > > > > -- Best regards, Andrey Kuznetsov.

Re: GridDhtInvalidPartitionException takes the cluster down

2019-03-26 Thread Andrey Kuznetsov
row this product away. > Do we want it for Ignite? > > From SO discussion I see following error message: ": >>> Possible > starvation in striped pool." > Are you sure this message are clear for Ignite user(not Ignite hacker)? > What user should do to prevent this er

Re: GridDhtInvalidPartitionException takes the cluster down

2019-03-26 Thread Andrey Kuznetsov
, mere spamming to log will not have an effect. Anyway, when experienced committers suggest to disable failure handling and hide existing issues, I feel as if they are pulling my leg. Best regards, Andrey Kuznetsov. вт, 26 марта 2019, 13:30 Nikolay Izhikov nizhi...@apache.org: > And

Re: GridDhtInvalidPartitionException takes the cluster down

2019-03-27 Thread Andrey Kuznetsov
I see no other dependencies for IGNITE-10003. Best regards, Andrey Kuznetsov. ср, 27 марта 2019, 18:25 Andrey Gura ag...@apache.org: > What do you think about including patches [1] and [2] to Ignite 2.7.5? > It's all about default failure handler behavior in cases of > SYSTEM_WORK

Re: Coding guidelines. Useless JavaDoc comments.

2019-08-07 Thread Andrey Kuznetsov
+1 for making javadoc comments optional. - Empty and tautological comments are kind of garbage that reduce readability. - It's better to leave the entity undocumented, than write unexpressive/misleading comment. - Even classes may not require javadocs, e.g. simple DTOs. ср, 7 авг. 2019 г., 13:39

Re: New Сommitter: Maxim Muzafarov

2019-08-28 Thread Andrey Kuznetsov
Great news! Congratulations! ср, 28 авг. 2019 г., 18:28 Alex Plehanov : > Maxim, congratulations! > > ср, 28 авг. 2019 г. в 18:13, Nikita Amelchev : > > > My congratulations, Maxim! > > > > ср, 28 авг. 2019 г. в 18:11, Dmitriy Pavlov : > > > > > > Dear community, > > > > > > The Project Managemen

Re: Critical worker threads liveness checking drawbacks

2018-09-24 Thread Andrey Kuznetsov
ext step is feature that will allow signal about > > blocked threads to the monitoring tools via MXBean. > > > > I hope you will continue development of this feature and provide your > > vision in new JIRA issue. > > > > > > On Tue, Sep 11, 2018 at 6:54 PM Andr

[GitHub] ignite pull request #4835: IGNITE-9695 WAL disabling prohibition in WalState...

2018-09-26 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/4835 IGNITE-9695 WAL disabling prohibition in WalStateManager. You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey-kuznetsov/ignite

Re: Critical worker threads liveness checking drawbacks

2018-09-27 Thread Andrey Kuznetsov
xchangeFuture#init has not been wrapped in blocked > > > > section. This means it easy to halt the node in case of longrunning > > > > actions during PME, for example when we create a cache with > > > > StoreFactrory which connect to 3rd party DB. > > > &

Re: Apache Ignite 2.7 release

2018-09-27 Thread Andrey Kuznetsov
>> >> > > On Thu, Sep 27, 2018 at 6:32 PM Dmitriy Pavlov < > >> dpavlov@gmail.com > >> >> > > >> >> > > wrote: > >> >> > > > >> >> > > > I agree, and I prefer four weeks for stabilization* (1 Oct - 29 > >> Oct) > >> >> > > > > >> >> > > > Do I understand it correctly: Service Grid is still in scope, > >> isn't > >> >> > it? I > >> >> > > > find it very important. > >> >> > > > > >> >> > > > чт, 27 сент. 2018 г. в 18:28, Nikolay Izhikov < > >> nizhi...@apache.org > >> >> >: > >> >> > > > > >> >> > > > > Hello, Vova. > >> >> > > > > > >> >> > > > > Thank you for clear release status. > >> >> > > > > I'm +1 for your proposal. > >> >> > > > > > >> >> > > > > чт, 27 сент. 2018 г., 18:25 Alexey Kuznetsov < > >> >> akuznet...@apache.org > >> >> > >: > >> >> > > > > > >> >> > > > > > Vova, > >> >> > > > > > > >> >> > > > > > Huge +1 to do a stabilization. > >> >> > > > > > > >> >> > > > > > > >> >> > > > > > -- > >> >> > > > > > Alexey Kuznetsov > >> >> > > > > > > >> >> > > > > > >> >> > > > > >> >> > > > >> >> > > >> >> > >> > > >> > > > -- Best regards, Andrey Kuznetsov.

[GitHub] ignite pull request #4876: Ignite 9744

2018-09-30 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/4876 Ignite 9744 You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey-kuznetsov/ignite ignite-9744 Alternatively you can review and

Re: Apache Ignite 2.7 release

2018-10-01 Thread Andrey Kuznetsov
> > > > > > > > > > > > > > > > > > > > > > dpavlov@gmail.com > > > > > > > > > > > > > > : > > > > > > > > &

Re: Apache Ignite 2.7 release

2018-10-02 Thread Andrey Kuznetsov
ge to 2.7 branch only previously announces features. > > >> > > > > 3. I expect we should exclude or *MERGE ALL TASKS FOR 2.7 DUE > > TO > > >> > > OCTOBER > > >> > > > > 10*. > > >> > > > > So th

Re: Apache Ignite 2.7 release

2018-10-03 Thread Andrey Kuznetsov
2018 г. в 23:54, Vladimir Ozerov : > > > > > Andrey, Anton, > > > > > > How do you conclude that these tickets are blockers? What is the > impact to > > > users and in what circumstances users can met them? > > > > > > Note that we hav

[GitHub] ignite pull request #4914: Ignite 9737

2018-10-04 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/4914 Ignite 9737 You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey-kuznetsov/ignite ignite-9737 Alternatively you can review and

Re: Apache Ignite 2.7 release

2018-10-09 Thread Andrey Kuznetsov
; Thanks, for a clarification. > > > В Ср, 03/10/2018 в 13:58 +0300, Alexey Goncharuk пишет: > > Nikolay, both commits fixed a regression compared to ignite-2.6. First > one was mentioned by Anton Kalashnikov before (java-level deadlock during > WAL flush), another - by Andrey Ku

Re: Apache Ignite 2.7 release

2018-10-09 Thread Andrey Kuznetsov
immediately or is it possible to postpone till 2.8? [1] https://issues.apache.org/jira/browse/IGNITE-9776 вт, 9 окт. 2018 г. в 11:17, Andrey Kuznetsov : > Ignite committers, > > I have prepared a PR for 2.7 blocker [1]. Could anybody merge it to 2.7 > and master? > > [1] https://issu

[GitHub] ignite pull request #4015: Ignite 6587

2018-10-11 Thread andrey-kuznetsov
Github user andrey-kuznetsov closed the pull request at: https://github.com/apache/ignite/pull/4015 ---

[GitHub] ignite pull request #4962: IGNITE-9710 Ignite watchdog service handles longr...

2018-10-11 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/4962 IGNITE-9710 Ignite watchdog service handles longrunning cache creation You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey

[GitHub] ignite pull request #4089: Ignite 6587 true

2018-10-11 Thread andrey-kuznetsov
Github user andrey-kuznetsov closed the pull request at: https://github.com/apache/ignite/pull/4089 ---

[GitHub] ignite pull request #4736: Ignite 6587 debug

2018-10-11 Thread andrey-kuznetsov
Github user andrey-kuznetsov closed the pull request at: https://github.com/apache/ignite/pull/4736 ---

[GitHub] ignite pull request #4559: Ignite 9280

2018-10-11 Thread andrey-kuznetsov
Github user andrey-kuznetsov closed the pull request at: https://github.com/apache/ignite/pull/4559 ---

Re: Critical worker threads liveness checking drawbacks

2018-10-11 Thread Andrey Kuznetsov
ay Izhikov < > nizhi...@apache.org > > >: > > > > > > > > > > > > > Hello, Igniters. > > > > > > > > > > > > > > I found that this feature can't be disabled from config. > > > > > &g

Re: Applicability of term 'cache' to Apache Ignite

2018-10-17 Thread Andrey Kuznetsov
rt the critical changes in code base, but I support all > changes > that helps the goal described above in this letter. > > > > -- > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ > -- Best regards, Andrey Kuznetsov.

[GitHub] ignite pull request #4914: IGNITE-9737

2018-10-17 Thread andrey-kuznetsov
Github user andrey-kuznetsov closed the pull request at: https://github.com/apache/ignite/pull/4914 ---

[GitHub] ignite pull request #4962: IGNITE-9710 Ignite watchdog service handles longr...

2018-10-17 Thread andrey-kuznetsov
Github user andrey-kuznetsov closed the pull request at: https://github.com/apache/ignite/pull/4962 ---

Re: Apache Ignite 2.7. Last Mile

2018-10-18 Thread Andrey Kuznetsov
t; > > > > > > On Wed, Oct 17, 2018 at 11:45 AM Павлухин Иван < > > vololo...@gmail.com> > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > Hi NIkolay, > > > > >

[GitHub] ignite pull request #5026: IGNITE-9932 Ignoring exchanger critical section b...

2018-10-18 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/5026 IGNITE-9932 Ignoring exchanger critical section begin/end if called from illegal thread. You can merge this pull request into a Git repository by running: $ git pull https

Re: Switching to real FailureHandler in tests

2018-10-22 Thread Andrey Kuznetsov
laky tests (1 or 2 fails) appeared because of new handler. > > I think we should keep no-op handler as default, but add new handler > for a few classes, where critical situations aren't expected. > > пт, 21 сент. 2018 г. в 17:03, Andrey Kuznetsov : > > > > Thanks

[GitHub] ignite pull request #5084: IGNITE-10003 Changed checkpointReadLock timeout f...

2018-10-25 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/5084 IGNITE-10003 Changed checkpointReadLock timeout failure type. You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey-kuznetsov/ignite

Re: Unreliable checks in tests for string presence in GridStringLogger contents

2018-10-25 Thread Andrey Kuznetsov
understandable when we write explicit assert in tests: > assertTrue("Fail reason.", lsnr.check()); > ср, 23 мая 2018 г. в 14:36, Andrey Kuznetsov : > > > > Thanks, Vyacheslav. > > > > Created the issue [1] based on your idea. > > > > [1] https://issues.

[GitHub] ignite pull request #5092: TDR-93 Several WAL compressor fixes.

2018-10-26 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/5092 TDR-93 Several WAL compressor fixes. For test purposes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey-kuznetsov/ignite tdr-93

[GitHub] ignite pull request #5219: IGNITE-10079 Fixed inconsistent lastCompactedSegm...

2018-10-31 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/5219 IGNITE-10079 Fixed inconsistent lastCompactedSegment in FileWALMgr. You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey-kuznetsov

Re: Abbreviation code-style requirement.

2018-11-01 Thread Andrey Kuznetsov
their useful > feedback. > > > My idea was to leave only "common sense" abbreviations and those that > are > > > Ignite domain specific. > > > > > > I would also suggest that we treat names mentioned in the table on the > > page > > > as names that are required to be abbreviated. Please take this into > > account > > > when conducting code reviews. > > > > > > Thanks! > > > > > > --Yakov > > > > > > > > -- > Best regards, > Ivan Pavlukhin > -- Best regards, Andrey Kuznetsov.

Re: Abbreviation code-style requirement.

2018-11-02 Thread Andrey Kuznetsov
. > > > > Let's keep using abbreviations and treat them as mandatory requirement. > > This is important for keeping our codebase consistent and tidy. > > > > --Yakov > > > > > -- > Best regards, > Ivan Pavlukhin > -- Best regards, Andrey Kuznetsov.

Re: IGNITE-2.7. New Features

2018-11-02 Thread Andrey Kuznetsov
Let's collect new features and improvements of Ignite 2.7 and includes it > to release notes and other documents. > > Can you answer and describe your contributions? > -- Best regards, Andrey Kuznetsov.

[GitHub] ignite pull request #5541: IGNITE-10386 Add mode when WAL won't be disabled ...

2018-11-30 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/5541 IGNITE-10386 Add mode when WAL won't be disabled during rebalancing caused by BLT change Just for tests now You can merge this pull request into a Git repository by running:

Re: Default failure handler was changed for tests

2018-12-05 Thread Andrey Kuznetsov
; > > > > > from > > > > > > > > > > > > > > > saying > > > > > > > > > > > > > > > > thank you to Dmitry. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Please review remaining tests and remove noop > > > where > > > > > > > possible. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > вт, 4 дек. 2018 г., 23:48 Andrey Mashenkov < > > > > > > > > > > > > > andrey.mashen...@gmail.com > > > > > > > > > > > > > > >: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Really, why noop? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > If you expect failure handler should be > > > > triggered, > > > > > you > > > > > > > can > > > > > > > > > > > > override > > > > > > > > > > > > > > > > default > > > > > > > > > > > > > > > > > one and rise some flag, which can be > checked > > in > > > > > test. > > > > > > > > > > > > > > > > > This will make test clearer. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > With noop, you'll get previous unwanted > > > > behavior, > > > > > > > that you > > > > > > > > > > are > > > > > > > > > > > > > > trying > > > > > > > > > > > > > > > to > > > > > > > > > > > > > > > > > improve, isnt'it? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 4 дек. 2018 г. 23:25 пользователь "Anton > > > > > Vinogradov" < > > > > > > > > > > > > > a...@apache.org> > > > > > > > > > > > > > > > > > написал: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > And you have to check the reason of failure > > > > inside > > > > > the > > > > > > > > > > > try-catch > > > > > > > > > > > > > > block, > > > > > > > > > > > > > > > > of > > > > > > > > > > > > > > > > > course. > > > > > > > > > > > > > > > > > In case found not equals to expected then > > test > > > > > should > > > > > > > > > rethrow > > > > > > > > > > > the > > > > > > > > > > > > > > > > > exception. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > вт, 4 дек. 2018 г. в 23:21, Anton > Vinogradov > > < > > > > > > > > > a...@apache.org > > > > > > > > > > >: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Dmitrii, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The solution is not clear to me. > > > > > > > > > > > > > > > > > > In case you expect the failure then a > > correct > > > > > case > > > > > > > is to > > > > > > > > > > wrap > > > > > > > > > > > > it > > > > > > > > > > > > > > with > > > > > > > > > > > > > > > > > > try-catch block instead of no-op failure > > > > handler > > > > > > > usage. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > вт, 4 дек. 2018 г. в 21:41, Dmitrii > Ryabov > > < > > > > > > > > > > > > > somefire...@gmail.com > > > > > > > > > > > > > > >: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >> Anton, > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > >> Tests in these classes check fail cases > > when > > > > we > > > > > > > expect > > > > > > > > > > > > critical > > > > > > > > > > > > > > > > > >> failure like node stop or exception > > thrown. > > > > Such > > > > > > > tests > > > > > > > > > > > trigger > > > > > > > > > > > > > > > failure > > > > > > > > > > > > > > > > > >> handler and it fails test when > everything > > > goes > > > > > as it > > > > > > > > > > should > > > > > > > > > > > > go. > > > > > > > > > > > > > > > That's > > > > > > > > > > > > > > > > > >> why we need no-op handler here. > > > > > > > > > > > > > > > > > >> вт, 4 дек. 2018 г. в 20:06, Dmitriy > > Pavlov < > > > > > > > > > > > > dpav...@apache.org > > > > > > > > > > > > > >: > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > >> > Hi Igniters, > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > >> > BTW, if you find in any of your tests > it > > > > > does't > > > > > > > need > > > > > > > > > an > > > > > > > > > > > old > > > > > > > > > > > > > > value > > > > > > > > > > > > > > > of > > > > > > > > > > > > > > > > > >> > handler (=NoOp), feel free to remove > it. > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > >> > Sincerely, > > > > > > > > > > > > > > > > > >> > Dmitriy Pavlov > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > >> > вт, 4 дек. 2018 г. в 20:02, Anton > > > > Vinogradov < > > > > > > > > > > > a...@apache.org > > > > > > > > > > > > >: > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > >> > > Dmitrii, > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > >> > > Could you please explain the reason > of > > > > > explicit > > > > > > > set > > > > > > > > > of > > > > > > > > > > > > 100+ > > > > > > > > > > > > > > > > > >> > > NoOpFailureHandlers? > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > >> > > вт, 4 дек. 2018 г. в 19:12, Dmitrii > > > > Ryabov < > > > > > > > > > > > > > > > somefire...@gmail.com > > > > > > > > > > > > > > > > >: > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > >> > > > Hello, Igniters! > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > >> > > > Today the test framework's default > > > no-op > > > > > > > failure > > > > > > > > > > > handler > > > > > > > > > > > > > was > > > > > > > > > > > > > > > > > >> changed to > > > > > > > > > > > > > > > > > >> > > the > > > > > > > > > > > > > > > > > >> > > > handler, which stops the node and > > > fails > > > > > the > > > > > > > test. > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > >> > > > Over 100 tests kept no-op failure > > > > handler > > > > > by > > > > > > > > > > overrided > > > > > > > > > > > > > > > > > >> > > > `getFailureHandler()` method. > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > >> > > > If you'll found a problem or > > something > > > > > > > unexpected > > > > > > > > > - > > > > > > > > > > > > write > > > > > > > > > > > > > > here > > > > > > > > > > > > > > > > or > > > > > > > > > > > > > > > > > >> in the > > > > > > > > > > > > > > > > > >> > > > ticket [1]. > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > >> > > > [1] > > > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-8227 > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > Best regards, > > > > > > > > > > > > > Andrey V. Mashenkov > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Best regards, > > > > > > > Ivan Pavlukhin > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Best regards, > > > > > Ivan Pavlukhin > > > > > > > > > > > > > > > -- Best regards, Andrey Kuznetsov.

Re: Default failure handler was changed for tests

2018-12-05 Thread Andrey Kuznetsov
> > "strict > > > > > > > > > > > > > > > > > try-catch with a check"? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, Dec 5, 2018 at 11:37 AM Dmitrii > > Ryabov > > > < > > > > > > > > > > > > > > somefire...@gmail.com> > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Anton, I think wrapping every > disconnecting > > > > node > > > > > > with > > > > > > > > > > try-catch > > > > > > > > > > > > > > will > > > > > > > > > > > > > > > be > > > > > > > > > > > > > > > > > > less readable than no-op handler. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ср, 5 дек. 2018 г., 9:26 Dmitriy Pavlov > > > > > > > > dpav...@apache.org > > > > > > > > > > : > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Folks let me remind you that Dmitry > > changed > > > > > > default > > > > > > > > of > > > > > > > > > > ALL > > > > > > > > > > > > > tests > > > > > > > > > > > > > > > from > > > > > > > > > > > > > > > > > > noop > > > > > > > > > > > > > > > > > > > to a meaningful handler. So we should > > start > > > > > every > > > > > > > > message > > > > > > > > > > > > here > > > > > > > > > > > > > > from > > > > > > > > > > > > > > > > > > saying > > > > > > > > > > > > > > > > > > > thank you to Dmitry. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Please review remaining tests and > remove > > > noop > > > > > > where > > > > > > > > > > possible. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > вт, 4 дек. 2018 г., 23:48 Andrey > > Mashenkov > > > < > > > > > > > > > > > > > > > > andrey.mashen...@gmail.com > > > > > > > > > > > > > > > > > >: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Really, why noop? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > If you expect failure handler should > be > > > > > > > triggered, > > > > > > > > you > > > > > > > > > > can > > > > > > > > > > > > > > > override > > > > > > > > > > > > > > > > > > > default > > > > > > > > > > > > > > > > > > > > one and rise some flag, which can be > > > > checked > > > > > in > > > > > > > > test. > > > > > > > > > > > > > > > > > > > > This will make test clearer. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > With noop, you'll get previous > unwanted > > > > > > > behavior, > > > > > > > > > > that you > > > > > > > > > > > > > are > > > > > > > > > > > > > > > > > trying > > > > > > > > > > > > > > > > > > to > > > > > > > > > > > > > > > > > > > > improve, isnt'it? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > 4 дек. 2018 г. 23:25 пользователь > > "Anton > > > > > > > > Vinogradov" < > > > > > > > > > > > > > > > > a...@apache.org> > > > > > > > > > > > > > > > > > > > > написал: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > And you have to check the reason of > > > failure > > > > > > > inside > > > > > > > > the > > > > > > > > > > > > > > try-catch > > > > > > > > > > > > > > > > > block, > > > > > > > > > > > > > > > > > > > of > > > > > > > > > > > > > > > > > > > > course. > > > > > > > > > > > > > > > > > > > > In case found not equals to expected > > then > > > > > test > > > > > > > > should > > > > > > > > > > > > rethrow > > > > > > > > > > > > > > the > > > > > > > > > > > > > > > > > > > > exception. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > вт, 4 дек. 2018 г. в 23:21, Anton > > > > Vinogradov > > > > > < > > > > > > > > > > > > a...@apache.org > > > > > > > > > > > > > >: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Dmitrii, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The solution is not clear to me. > > > > > > > > > > > > > > > > > > > > > In case you expect the failure > then a > > > > > correct > > > > > > > > case > > > > > > > > > > is to > > > > > > > > > > > > > wrap > > > > > > > > > > > > > > > it > > > > > > > > > > > > > > > > > with > > > > > > > > > > > > > > > > > > > > > try-catch block instead of no-op > > > failure > > > > > > > handler > > > > > > > > > > usage. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > вт, 4 дек. 2018 г. в 21:41, Dmitrii > > > > Ryabov > > > > > < > > > > > > > > > > > > > > > > somefire...@gmail.com > > > > > > > > > > > > > > > > > >: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >> Anton, > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > >> Tests in these classes check fail > > > cases > > > > > when > > > > > > > we > > > > > > > > > > expect > > > > > > > > > > > > > > > critical > > > > > > > > > > > > > > > > > > > > >> failure like node stop or > exception > > > > > thrown. > > > > > > > Such > > > > > > > > > > tests > > > > > > > > > > > > > > trigger > > > > > > > > > > > > > > > > > > failure > > > > > > > > > > > > > > > > > > > > >> handler and it fails test when > > > > everything > > > > > > goes > > > > > > > > as it > > > > > > > > > > > > > should > > > > > > > > > > > > > > > go. > > > > > > > > > > > > > > > > > > That's > > > > > > > > > > > > > > > > > > > > >> why we need no-op handler here. > > > > > > > > > > > > > > > > > > > > >> вт, 4 дек. 2018 г. в 20:06, > Dmitriy > > > > > Pavlov < > > > > > > > > > > > > > > > dpav...@apache.org > > > > > > > > > > > > > > > > >: > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > >> > Hi Igniters, > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > >> > BTW, if you find in any of your > > > tests > > > > it > > > > > > > > does't > > > > > > > > > > need > > > > > > > > > > > > an > > > > > > > > > > > > > > old > > > > > > > > > > > > > > > > > value > > > > > > > > > > > > > > > > > > of > > > > > > > > > > > > > > > > > > > > >> > handler (=NoOp), feel free to > > remove > > > > it. > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > >> > Sincerely, > > > > > > > > > > > > > > > > > > > > >> > Dmitriy Pavlov > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > >> > вт, 4 дек. 2018 г. в 20:02, > Anton > > > > > > > Vinogradov < > > > > > > > > > > > > > > a...@apache.org > > > > > > > > > > > > > > > >: > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > >> > > Dmitrii, > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > >> > > Could you please explain the > > > reason > > > > of > > > > > > > > explicit > > > > > > > > > > set > > > > > > > > > > > > of > > > > > > > > > > > > > > > 100+ > > > > > > > > > > > > > > > > > > > > >> > > NoOpFailureHandlers? > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > >> > > вт, 4 дек. 2018 г. в 19:12, > > > Dmitrii > > > > > > > Ryabov < > > > > > > > > > > > > > > > > > > somefire...@gmail.com > > > > > > > > > > > > > > > > > > > >: > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > >> > > > Hello, Igniters! > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > >> > > > Today the test framework's > > > default > > > > > > no-op > > > > > > > > > > failure > > > > > > > > > > > > > > handler > > > > > > > > > > > > > > > > was > > > > > > > > > > > > > > > > > > > > >> changed to > > > > > > > > > > > > > > > > > > > > >> > > the > > > > > > > > > > > > > > > > > > > > >> > > > handler, which stops the > node > > > and > > > > > > fails > > > > > > > > the > > > > > > > > > > test. > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > >> > > > Over 100 tests kept no-op > > > failure > > > > > > > handler > > > > > > > > by > > > > > > > > > > > > > overrided > > > > > > > > > > > > > > > > > > > > >> > > > `getFailureHandler()` > method. > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > >> > > > If you'll found a problem or > > > > > something > > > > > > > > > > unexpected > > > > > > > > > > > > - > > > > > > > > > > > > > > > write > > > > > > > > > > > > > > > > > here > > > > > > > > > > > > > > > > > > > or > > > > > > > > > > > > > > > > > > > > >> in the > > > > > > > > > > > > > > > > > > > > >> > > > ticket [1]. > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > >> > > > [1] > > > > > > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-8227 > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > Best regards, > > > > > > > > > > > > > > > > Andrey V. Mashenkov > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > Best regards, > > > > > > > > > > Ivan Pavlukhin > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > Best regards, > > > > > > > > Ivan Pavlukhin > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Best regards, > > > Andrey V. Mashenkov > > > > > > -- Best regards, Andrey Kuznetsov.

[GitHub] ignite pull request #5541: IGNITE-10386 Add mode when WAL won't be disabled ...

2018-12-10 Thread andrey-kuznetsov
Github user andrey-kuznetsov closed the pull request at: https://github.com/apache/ignite/pull/5541 ---

[GitHub] ignite pull request #5219: IGNITE-10079 Fixed inconsistent lastCompactedSegm...

2018-12-10 Thread andrey-kuznetsov
Github user andrey-kuznetsov closed the pull request at: https://github.com/apache/ignite/pull/5219 ---

[GitHub] ignite pull request #5092: TDR-93 Several WAL compressor fixes.

2018-12-10 Thread andrey-kuznetsov
Github user andrey-kuznetsov closed the pull request at: https://github.com/apache/ignite/pull/5092 ---

[GitHub] ignite pull request #4547: Tdr 26

2018-12-10 Thread andrey-kuznetsov
Github user andrey-kuznetsov closed the pull request at: https://github.com/apache/ignite/pull/4547 ---

Write access to Apache Ignite Confluence

2018-12-18 Thread Andrey Kuznetsov
Hi, Igniters. I'd like to add new wiki page with suggestions for future Ignite 3.0 release. We can collect any ideas there and then discuss and refine them on dev-list. Could someone grant me (andrey-kuznetsov) write permission?

Re: Write access to Apache Ignite Confluence

2018-12-18 Thread Andrey Kuznetsov
Thanks, Dmitriy. The page stub [1] is now created. [1] https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+3.0+Wishlist Best regards, Andrey Kuznetsov. вт, 18 дек. 2018, 12:45 Dmitriy Pavlov dpav...@apache.org: > Hi Andrey, > > I've updated permissions

Re: [MTCGA]: new failures in builds [2636079] needs to be handled

2018-12-25 Thread Andrey Kuznetsov
Separate issue has been created to address this: IGNITE-10813. Best regards, Andrey Kuznetsov. пн, 24 дек. 2018, 19:37 dpavlov.ta...@gmail.com: > Hi Igniters, > > I've detected some new issue on TeamCity to be handled. You are more than > welcomed to help. > > If your c

[GitHub] ignite pull request #2339: Ignite 4181 public api

2017-07-24 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/2339 Ignite 4181 public api You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey-kuznetsov/ignite ignite-4181-public-api Alternatively

Non-UTF-8 string encoding support in BinaryMarshaller (IGNITE-5655)

2017-07-25 Thread Andrey Kuznetsov
bal property. It seems to be more convenient for user.I'll appreciate your feedback. - Best regards, Andrey Kuznetsov. -- View this message in context: http://apache-ignite-developers.2346864.n4.nabble.com/Non-UTF-8-string-encoding-support-in-BinaryMarshaller-IGNITE-5655-tp20024.html

Re: Non-UTF-8 string encoding support in BinaryMarshaller (IGNITE-5655)

2017-07-25 Thread Andrey Kuznetsov
figuration property for encoding to use instead of using global property. It seems to be more convenient for user. I'll appreciate your feedback. 2017-07-25 16:13 GMT+03:00 Andrey Kuznetsov : > Hi Igniters,I'd like to discuss future changes related to IGNITE-5655 > <https://

Re: Non-UTF-8 string encoding support in BinaryMarshaller (IGNITE-5655)

2017-07-25 Thread Andrey Kuznetsov
meaning that encoding will be written as string > afterwards, this way we will support any encoding out of the box > [optional] encoding name > 4 bytes - string length > Finally - string bytes > > Vladimir. > > вт, 25 июля 2017 г. в 18:24, Andrey Kuznetsov <[hidden email]

Re: Non-UTF-8 string encoding support in BinaryMarshaller (IGNITE-5655)

2017-07-26 Thread Andrey Kuznetsov
uld add new type "encoded string": > > > 1 byte - type > > > 1 byte - encoding code, map frequently used encodings to some byte > value; > > > also have a special value, meaning that encoding will be written as > > string > > > afterwards,

Assertions as binary data validation checks in deserialization

2017-07-27 Thread Andrey Kuznetsov
. -- Best regards, Andrey Kuznetsov.

Re: Assertions as binary data validation checks in deserialization

2017-07-27 Thread Andrey Kuznetsov
писал: > Andrey, > > How will it corrupt the data? Assertions only reads the array, not updates > it, right? > > -Val > > On Thu, Jul 27, 2017 at 8:54 AM, Andrey Kuznetsov > wrote: > > > Hi Igniters, > > > > While examining BinaryObjectImpl code I fo

Re: Assertions as binary data validation checks in deserialization

2017-07-27 Thread Andrey Kuznetsov
Indeed, "let it crash" approach is better than unclear error in some indeterminate place later. Here we depend on data from "inpredictable" source, so assertions are not suitable. 27 июля 2017 г. 22:35 пользователь "Valentin Kulichenko" < valentin.kuliche...@gmail.com> написал: Do you suggest to

Re: Assertions as binary data validation checks in deserialization

2017-07-27 Thread Andrey Kuznetsov
May I change this line while working on existing ticket, unless someone else objects? 27 июля 2017 г. 23:37 пользователь "Valentin Kulichenko" < valentin.kuliche...@gmail.com> написал: Makes sense to me. Feel free to create a ticket unless someone else has any objection. However, I think that we

Re: Non-UTF-8 string encoding support in BinaryMarshaller (IGNITE-5655)

2017-07-28 Thread Andrey Kuznetsov
; about. > > As far as configuration, we can do it as follows: > > 1) Add global encoding, UTF8 by default. > 2) Add per-cache encoding. > 3) Add encoding to JDBC and ODBC driver properties. > > This should be enough. > > -- Best regards, Andrey Kuznetsov. -- View

Re: Non-UTF-8 string encoding support in BinaryMarshaller (IGNITE-5655)

2017-07-28 Thread Andrey Kuznetsov
Currently, marshaller determines the type of field (BYTE, INT, STRING etc.) only by the Class of data being serialized. It seems rather non-trivial to manage marshaling parameters at cache creation point. Alternatively, there exists simple and flexible way: just to introduce new Java type, say, Str

[GitHub] ignite pull request #2391: Ignite 5655

2017-08-03 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/2391 Ignite 5655 First implementation, uses global level configuration option (in BinaryConfiguration) You can merge this pull request into a Git repository by running: $ git pull https

IgniteSemaphore methods semantics

2017-08-10 Thread Andrey Kuznetsov
entation, while java.util.concurrent.Semaphore is bounded. I think we are to do one of the following: - Document uncommon IgniteSemaphore semantics properly or - Change its semantics to conform java.util.concurrent counterpart. -- Best regards, Andrey Kuznetsov.

[GitHub] ignite pull request #2434: IGNITE-6009: Fixed IgniteSemaphore test.

2017-08-11 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/2434 IGNITE-6009: Fixed IgniteSemaphore test. You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey-kuznetsov/ignite ignite-6009

[GitHub] ignite pull request #2496: IGNITE-6137: CAS logic fix in async commit.

2017-08-21 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/2496 IGNITE-6137: CAS logic fix in async commit. Reproducing test + fix You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey-kuznetsov

Re: Ignite Usability: Deadlocks and Starvation

2017-08-23 Thread Andrey Kuznetsov
lve situations of the kind. > > Here is the page with the info on this - > https://cwiki.apache.org/confluence/display/IGNITE/Deadlock+Detection+And+ > Cluster+Protection > > Please provide comments here on dev list or on wiki. Then we will file > tickets to plan these chang

Re: Ignite Usability: Deadlocks and Starvation

2017-08-23 Thread Andrey Kuznetsov
2017-08-23 22:45 GMT+03:00 Yakov Zhdanov : > Andrey, do you have an example of such method in Ignite public or private > API? > > If it is not Ignite API please provide an example. > > -- > Yakov Zhdanov > -- Best regards, Andrey Kuznetsov.

Re: Ignite Usability: Deadlocks and Starvation

2017-08-25 Thread Andrey Kuznetsov
t thread as parameter. > > --Yakov > -- Best regards, Andrey Kuznetsov.

IGNITE-5655: Mixing binary string encodings in Ignite cluster

2017-09-05 Thread Andrey Kuznetsov
node goes down for a while. Any ideas on addressing these issues? -- Best regards, Andrey Kuznetsov.

Re: IGNITE-5655: Mixing binary string encodings in Ignite cluster

2017-09-06 Thread Andrey Kuznetsov
it > transparently for user. > > Second option is more preferable to me as a long-term solution, but would > require =more efforts. > > Thoughts? > > -- Best regards, Andrey Kuznetsov.

Re: Ignite Enhancement Proposal process

2017-09-19 Thread Andrey Kuznetsov
UZNETSOV : > great suggestion > > -- Best regards, Andrey Kuznetsov.

[GitHub] ignite pull request #2748: IGNITE-6015: Rollback on exception in commitIfLoc...

2017-09-26 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/2748 IGNITE-6015: Rollback on exception in commitIfLocked. You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey-kuznetsov/ignite ignite

[GitHub] ignite pull request #2749: IGNITE-6186: Removed redundant parameter.

2017-09-26 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/2749 IGNITE-6186: Removed redundant parameter. You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey-kuznetsov/ignite ignite-6186

[GitHub] ignite pull request #2781: IGNITE-6520: Using actual AffinityReadyFuture res...

2017-09-29 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/2781 IGNITE-6520: Using actual AffinityReadyFuture result. You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey-kuznetsov/ignite ignite

[GitHub] ignite pull request #2781: IGNITE-6520: Using actual AffinityReadyFuture res...

2017-10-02 Thread andrey-kuznetsov
Github user andrey-kuznetsov closed the pull request at: https://github.com/apache/ignite/pull/2781 ---

[GitHub] ignite pull request #2869: IGNITE-1804: Test is not not flaky anymore

2017-10-17 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/2869 IGNITE-1804: Test is not not flaky anymore You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey-kuznetsov/ignite master

[GitHub] ignite pull request #2877: IGNITE-1804: Test is not flaky anymore

2017-10-18 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/2877 IGNITE-1804: Test is not flaky anymore You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey-kuznetsov/ignite ignite-1804

[GitHub] ignite pull request #2869: IGNITE-1804: Test is not flaky anymore

2017-10-18 Thread andrey-kuznetsov
Github user andrey-kuznetsov closed the pull request at: https://github.com/apache/ignite/pull/2869 ---

IgniteSet implementation: changes required

2017-10-30 Thread Andrey Kuznetsov
Hi, Igniters! Current implementation of IgniteSet is fragile with respect to cluster recovery from a checkpoint. We have an issue (IGNITE-5553) that addresses set's size() behavior, but the problem is slightly broader. The text below is my comment from Jira issue. I encourage you to discuss it. W

Add emergency node closing handler to public Ignite API

2017-11-14 Thread Andrey Kuznetsov
). First, I'd like to get your feedback on this potential change. Then we can refine SomeClosure structure. -- Best regards, Andrey Kuznetsov.

Re: Add emergency node closing handler to public Ignite API

2017-11-14 Thread Andrey Kuznetsov
Lifecycle beans are ok, but they does not accept any info on the Reason in case of emergency node stop. 2017-11-14 21:16 GMT+03:00 Valentin Kulichenko < valentin.kuliche...@gmail.com>: > Anton, > > I agree with Vova - we already have lifecycle bean. Why do we need anything > on top of that? > > -

Re: Add emergency node closing handler to public Ignite API

2017-11-14 Thread Andrey Kuznetsov
Vladimir, Ignite instance won't tell me whether deadlock occurred or some critical thread has died. 14 нояб. 2017 г. 22:28 пользователь "Vladimir Ozerov" написал: You can get this info from injected Ignite instance.

Re: Add emergency node closing handler to public Ignite API

2017-11-15 Thread Andrey Kuznetsov
Vladimir, Could you please refine, what are local metrics? Should I extend Ignite interface by adding something similar to dataRegionMetrics() or there is some universal mechanism to handle metrics? 2017-11-15 8:30 GMT+03:00 Vladimir Ozerov : > > This information should be available through local

[GitHub] ignite pull request #3072: IGNITE-6963: Made PhysicalMemoryPages equal to To...

2017-11-20 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/3072 IGNITE-6963: Made PhysicalMemoryPages equal to TotalAllocatedPages when PDS is off You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] ignite pull request #3072: IGNITE-6963: Made PhysicalMemoryPages equal to To...

2017-11-23 Thread andrey-kuznetsov
Github user andrey-kuznetsov closed the pull request at: https://github.com/apache/ignite/pull/3072 ---

Re: supporting different configuration format json,yaml...

2018-05-15 Thread Andrey Kuznetsov
> > > > > > > >> > > > > > > > > > >> > > вт, 15 мая 2018 г. в 9:31, Pavel Tupitsyn < > > > > ptupit...@apache.org > > > > > >: > > > > > > > >> > > > > > > > > > >> > > > Dmitriy, > > > > > > > >> > > > > > > > > > > >> > > > We don't need to support different config formats on > > > server > > > > in > > > > > > > order > > > > > > > >> to > > > > > > > >> > > add > > > > > > > >> > > > that to thin clients. > > > > > > > >> > > > > > > > > > > >> > > > Thin client protocol provides a way to create a cache > > with > > > > > > custom > > > > > > > >> > config > > > > > > > >> > > > [1]. > > > > > > > >> > > > It is up to thin client library authors to use any > > config > > > > > format > > > > > > > they > > > > > > > >> > > like > > > > > > > >> > > > and then convert it into protocol-defined format. > > > > > > > >> > > > > > > > > > > >> > > > C# thin client uses custom format, for example, not > > > Spring. > > > > > > > >> > > > > > > > > > > >> > > > [1] > > > > > > > >> > > > > > > > > > > >> > > > https://apacheignite.readme.io/docs/binary-client- > > > > > > > >> > > protocol-cache-configuration- > operations#section-op_cache_ > > > > > > > >> > > create_with_configuration > > > > > > > >> > > > > > > > > > > >> > > > On Mon, May 14, 2018 at 7:54 PM, Ivan Rakov < > > > > > > > ivan.glu...@gmail.com> > > > > > > > >> > > wrote: > > > > > > > >> > > > > > > > > > > >> > > > > Dmitry, > > > > > > > >> > > > > > > > > > > > >> > > > > We rely on Spring Framework when we start Ignite > node > > > from > > > > > XML > > > > > > > >> > > > > configuration. Spring doesn't easily support another > > > > formats > > > > > > of > > > > > > > >> > > > > configuration files. I think, the main reason for > this > > > is > > > > > > > built-in > > > > > > > >> > > > ability > > > > > > > >> > > > > to validate configuration via XML Schema. We can > > surely > > > > hack > > > > > > > this > > > > > > > >> > > around > > > > > > > >> > > > (I > > > > > > > >> > > > > bet there are existing libraries for configuring > > Spring > > > > with > > > > > > > JSON), > > > > > > > >> > > but I > > > > > > > >> > > > > don't think that anyone suffered from inability to > > > > > statically > > > > > > > >> > configure > > > > > > > >> > > > > Ignite with json/yaml. > > > > > > > >> > > > > > > > > > > > >> > > > > Regarding thin clients: makes sense. I suppose > > necessary > > > > > > > mappings > > > > > > > >> > will > > > > > > > >> > > be > > > > > > > >> > > > > implemented as a part of thin client. > > > > > > > >> > > > > > > > > > > > >> > > > > Best Regards, > > > > > > > >> > > > > Ivan Rakov > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > On 14.05.2018 18:58, Dmitriy Govorukhin wrote: > > > > > > > >> > > > > > > > > > > > >> > > > >> Hi, Igniters! > > > > > > > >> > > > >> > > > > > > > >> > > > >> As far as I know, many people work on a thin client > > for > > > > > > > different > > > > > > > >> > > > language > > > > > > > >> > > > >> (go,js,php...). > > > > > > > >> > > > >> Are there any reasons why ignite does not support > > yaml > > > or > > > > > > json > > > > > > > >> > format > > > > > > > >> > > > for > > > > > > > >> > > > >> configuration? or some other popular format? > > > > > > > >> > > > >> In future, it can help to integrate with thin > > clients, > > > > for > > > > > > > >> example, > > > > > > > >> > js > > > > > > > >> > > > >> client may want to dynamic cache start, he passes > > cache > > > > > > > >> > configuration > > > > > > > >> > > > (in > > > > > > > >> > > > >> native format, for js it will json) through TCP, > > Ignite > > > > > node > > > > > > > >> unwrap > > > > > > > >> > > and > > > > > > > >> > > > >> remap to java representation and dynamic start > cache. > > > > > > > >> > > > >> > > > > > > > >> > > > >> > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- Best regards, Andrey Kuznetsov.

Re: Avoid JIRA comments deletion

2018-05-16 Thread Andrey Kuznetsov
rse. 2018-05-16 12:51 GMT+03:00 Dmitriy Govorukhin : > +1 Dmitriy, > > I do not see any reason for deletion comments. > Maybe only edit operation must be allowed. > > -- Best regards, Andrey Kuznetsov.

[GitHub] ignite pull request #4015: Ignite 6587

2018-05-17 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/4015 Ignite 6587 For test purposes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey-kuznetsov/ignite ignite-6587 Alternatively you

Unreliable checks in tests for string presence in GridStringLogger contents

2018-05-23 Thread Andrey Kuznetsov
that add more logging can damage a test. I propose to add some stuff to {{GridStringLogger}} in order to catch preset marker strings during logging, then we will not depend on buffer size. Thoughts? -- Best regards, Andrey Kuznetsov.

Re: Unreliable checks in tests for string presence in GridStringLogger contents

2018-05-23 Thread Andrey Kuznetsov
gger/ListenedGridTestLog4jLogger.java > [2] https://github.com/apache/ignite/blob/master/modules/ > compatibility/src/test/java/org/apache/ignite/compatibility/testframework/ > junits/IgniteCompatibilityAbstractTest.java#L304 > > > -- Best regards, Andrey Kuznetsov.

[GitHub] ignite pull request #4089: Ignite 6587 true

2018-05-29 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/4089 Ignite 6587 true For TC tests now You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey-kuznetsov/ignite ignite-6587-true

[GitHub] ignite pull request #4091: IGNITE-8642: Added thread dumping to FailureProce...

2018-05-29 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/4091 IGNITE-8642: Added thread dumping to FailureProcessor. You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey-kuznetsov/ignite ignite

[GitHub] ignite pull request #4115: IGNITE-8290: Trying to reproduce on TC.

2018-06-04 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/4115 IGNITE-8290: Trying to reproduce on TC. Debug through CI. You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrey-kuznetsov/ignite

  1   2   3   >