Re: [DISCUSSION] IEP-87: Open API support for REST

2022-05-19 Thread Roman Puchkovskiy
Hi Aleksandr. Thank you for your effort, it looks interesting. I have a few comments/questions on some little details. 1. About the paragraph named 'Versioning'. Could you please elaborate what is the difference between 'API version' and 'specification version'? Both might have 'breaking changes'

Re: [DISCUSSION] IEP-87: Open API support for REST

2022-05-19 Thread Roman Puchkovskiy
Oops, sent it too early :) I'll proceed. ... As a side note, as far as I know, there were some discussions about using automatic dependency injection in Ignite 3 (as the whole system), but no decision was made. 3. In the table in the API section, there is this phrase: 'Update node configuration w

Re: [DISCUSSION] IEP-88: CLI Tool

2022-05-19 Thread Aleksandr Pakhomov
I got it. What do you think about this proposal: - “ignite” prints help - “ignite shell” enters REPL Or - “ignite” prints help - “ignite-shell” enters REPL and it is a separate application I prefer the first varian but I would like to hear opinions of other community members. > On 19

Re: [DISCUSSION] IEP-88: CLI Tool

2022-05-19 Thread Ilya Korol
From my perspective we should move towards existing UX approaches. For example: python - enters shell python --help  - prints help python -c - executes command What about other CLI tools that works with remote services? I can't remember properly but do AWS, openshift or maybe GCP CLIs also supp

Final reminder: ApacheCon North America call for presentations closing soon

2022-05-19 Thread Rich Bowen
[Note: You're receiving this because you are subscribed to one or more Apache Software Foundation project mailing lists.] This is your final reminder that the Call for Presetations for ApacheCon North America 2022 will close at 00:01 GMT on Monday, May 23rd, 2022. Please don't wait! Get your talk

Re: [DISCUSSION] Add additional 3rd party libraries to Ignite 3 Code style and practices

2022-05-19 Thread Aleksandr Pakhomov
Hi, Eduard Thank you for pointing out the 140 symbol column limit. Il’l follow this. As for transitive dependencies, good point. I would mention that not only class loader magic can be implemented but Micronaut libraries could be shadowed in order not to cause the jar-hell issues for clients.

Re: [DISCUSSION] Add additional 3rd party libraries to Ignite 3 Code style and practices

2022-05-19 Thread Alexander Polovtcev
Hello, Aleksandr! I agree with the usage of Swagger for generating REST API specifications as it, for example, removes the burden of manually keeping the documentation up to date. However, why do we need the Micronaut framework? No other modules use it, and it brings a lot of dependencies that you

Re: [DISCUSSION] Add additional 3rd party libraries to Ignite 3 Code style and practices

2022-05-19 Thread Aleksandr Pakhomov
Hi, Alexander Micronaut is chosen as a lightweight framework that is is compatible with swagger generators. One who develops an endpoint just writes a regular micronaut annotations and gets specification generated from it. I get your concerns about additional library, but micronaut itself i

Re: [DISCUSSION] IEP-87: Open API support for REST

2022-05-19 Thread Aleksandr Pakhomov
Hi Roman, Thanks for the note. I’ve updated ‘Versioning’ paragraph with the example. > On 19 May 2022, at 10:12, Roman Puchkovskiy > wrote: > > Hi Aleksandr. > > Thank you for your effort, it looks interesting. I have a few > comments/questions on some little details. > > 1. About the parag

Re: [DISCUSSION] IEP-87: Open API support for REST

2022-05-19 Thread Aleksandr Pakhomov
Yes, micronaut injection is going to be used but only for controllers. The border is MicronautFactory (see RestComponent constructor in the example). This factory declares beans that are needed for controllers. Each module declares its own factory. List of factories are put to RestComponent manua

Re: [DISCUSSION] IEP-87: Open API support for REST

2022-05-19 Thread Aleksandr Pakhomov
Agreed. Thank you for comments, Roman. > On 19 May 2022, at 10:17, Roman Puchkovskiy > wrote: > > 3. In the table in the API section, there is this phrase: 'Update node > configuration with a given body.'. I suggest replacing 'Update' with > 'Patch' because 'update' could mean a full replacemen

Re: IEP-90 Ignite 3 Client Lifecycle

2022-05-19 Thread Pavel Tupitsyn
Andrey, > different connections on different client instances theoretically > could generate an already existing connection ID Do you mean an UUID collision? On Thu, May 19, 2022 at 1:09 AM Andrey Gura wrote: > Igor, > > Thanks for the proposal. > > I understand that such a situation is almost

Re: IEP-90 Ignite 3 Client Lifecycle

2022-05-19 Thread Pavel Tupitsyn
Igor, I've started working on the initial sessions implementation [1], and I'd like to clarify the procedure of logical connection restore. > client in its turn tries to establish a new *node connection* > and restore *logical connection *using ConnectionRestoreReq This implies either an additio

Re: IEP-90 Ignite 3 Client Lifecycle

2022-05-19 Thread Igor Sapego
Andrey, 1. If a server generates a UUID that already exists it can check and just re-generate it straight away as a check is just a simple map lookup. 2. Well, yes. This proposal does not consider monitoring, but with current approach it will be definitely easier to implement it properly. Pavel,

Re: [DISCUSSION] Move the ignite-yarn, ignite-geospatial, ignite-schedule to the Ignite Extensions

2022-05-19 Thread Ilya Kasnacheev
Hello! Can you arrange that? Regards, -- Ilya Kasnacheev чт, 19 мая 2022 г. в 09:20, Maxim Muzafarov : > Ilya, > > Should we start a formal vote about the ignite-schedule deletion? > > On Mon, 16 May 2022 at 14:28, Ilya Kasnacheev > wrote: > > > > Hello! > > > > In my opinion, the ignite-sch