Hello, Aleksandr! I agree with the usage of Swagger for generating REST API specifications as it, for example, removes the burden of manually keeping the documentation up to date. However, why do we need the Micronaut framework? No other modules use it, and it brings a lot of dependencies that you will have to shadow somehow. AFAIK current implementation uses a pure Netty approach and is quite small in size. My other concern is using Micronaut serde for serialization. We already have other serialization libraries as dependencies and do we really need another one?
On Thu, May 19, 2022 at 1:06 PM Aleksandr Pakhomov <apk...@gmail.com> wrote: > Hi, Eduard > > Thank you for pointing out the 140 symbol column limit. > Il’l follow this. > > As for transitive dependencies, good point. I would mention > that not only class loader magic can be implemented but > Micronaut libraries could be shadowed in order not to > cause the jar-hell issues for clients. > > > On 19 May 2022, at 01:40, Eduard Rakhmankulov <erixon...@gmail.com> > wrote: > > > > Hi, Igniters! > > > > I am really glad about the 140 symbol column limit. > > > > But aside from possible vulnerabilities mentioned above I have other > > concerns, which may affect some future users. > > > > Micronaut is a rather popular framework. Are we planning some OSGI > support > > (or custom classloader magic) so users which have been already using > > micronaut don't need to be bound to the version transitively inherited by > > ignite dependencies? > > > > On Thu, 19 May 2022 at 00:32, Andrey Gura <ag...@apache.org> wrote: > > > >> I personally don't support any additional 3rd party dependencies as > >> well as I don't fully understand the value of autogenerated specs for > >> REST endpoints. In my opinion we have another option: writing spec > >> manually. This option doesn't require any of proposed dependencies and > >> allow to avoid possible vulnerabilities. Of course at the cost of > >> manual actions. > >> > >> I understand that my statement is arguable. So I'll just wait for > >> opinions of other community members. > >> > >> On Mon, May 16, 2022 at 7:45 PM Aleksandr Pakhomov <apk...@gmail.com> > >> wrote: > >>> > >>> > >>> Hello, Igniters. > >>> > >>> I would like to start a discussion about Java Code Style Guide [1] > >> changes that are going to be a part of IEP-87 [2] implementation. The > set > >> of libraries and frameworks that are going to be allowed to be used in > >> production: > >>> - Micronaut for REST Server [3] > >>> - Swagger for Open API annotations [4] > >>> - Micronaut serde for REST serialization [5] > >>> > >>> Any objections? Also, comments on IEP-87 are welcomed. > >>> [1] > >> > https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide#JavaCodeStyleGuide-2Using3rdpartylibraries > >> < > >> > https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide#JavaCodeStyleGuide-2Using3rdpartylibraries > >>> > >>> [2] > >> > https://cwiki.apache.org/confluence/display/IGNITE/IEP-87%3A+Open+API+support+for+REST#IEP87:OpenAPIsupportforREST-Additionaldependencies > >> < > >> > https://cwiki.apache.org/confluence/display/IGNITE/IEP-87%3A+Open+API+support+for+REST#IEP87:OpenAPIsupportforREST-Additionaldependencies > >>> > >>> [3] https://micronaut.io/docs <https://micronaut.io/docs>/ > >>> [4] https://swagger.io <https://swagger.io/> > >>> [5] > >> > https://micronaut-projects.github.io/micronaut-serialization/snapshot/guide > >> < > >> > https://micronaut-projects.github.io/micronaut-serialization/snapshot/guide > >>> / > >> > > -- With regards, Aleksandr Polovtcev
