Andrey,
Some rules are good, some rules are bad :)
If you create such a script so that it relies on having a colon in every
message, it will never work, simply because people make mistakes. The only
consequence of such a rule would be that we will have to fight it forever
trying to enforce it. I'
Ivan, Val,
> But is it really important whether someone puts a colon, a dash, or just a
> space after the ticket number?
Absolutely not important. But every time when you want to write script
for processing commit messages in some way you should check what
exactly format committers use.
I do not
I agree with Ivan. All contribution rules should be reasonable and should
*add value*.
For example, a requirement to include the ticket number is a great idea as
it creates a clear link between a commit and a JIRA ticket. This helps to
track the history, simplifies searches, etc.
But is it really
Andrey,
I am working with about 4 projects. And I do not want to bother myself
whether colon in a commit message is required or prohibited. And I
believe that we should encourage to contribute not only those whose
full-time job is contribution to Ignite. So, a contribution process
should be as sim
Ivan,
What could be simpler than exactly one format without any optional things? :)
I don't understand why examples of other project should be considered
at all. Most of commit messages in Apache Ignite have described format
without additional symbols. It is absolutely okay to require to follow
s
Andrey,
Personally I would consider a proper format (where colon is optional):
IGNITE-[:] my message
Is there any any harm from a "colon" in a commit message? While we are
working in open source simplification is very important. And I suggest
to not bother contributors and committers with un
Ok, lets keep in mind and remind during PRs to each other
чт, 19 мар. 2020 г., 17:32 Andrey Gura :
> Igniters,
>
> please, notice that right commit message format the following:
>
> IGNITE- my message
>
> There is no colon (:) after . There is no hyphen (-) between
> and message. The
