Andrey,

Personally I would consider a proper format (where colon is optional):

IGNITE-XXXX[:] my message

Is there any any harm from a "colon" in a commit message? While we are
working in open source simplification is very important. And I suggest
to not bother contributors and committers with unnecessary rules. Not
all of us contribute only in Ignite and both formats (with colon and
not) are common [1, 2, 3].

[1] https://github.com/apache/kafka/commits/trunk
[2] https://github.com/apache/hive/commits/trunk
[3] https://github.com/openjdk/jdk/commits/master

Best regards,
Ivan Pavlukhin

чт, 19 мар. 2020 г. в 23:15, Alexey Zinoviev <zaleslaw....@gmail.com>:
>
> Ok, lets keep in mind and remind during PRs to each other
>
> чт, 19 мар. 2020 г., 17:32 Andrey Gura <ag...@apache.org>:
>
> > Igniters,
> >
> > please, notice that right commit message format the following:
> >
> > IGNITE-XXXX my message
> >
> > There is no colon (:) after XXXX. There is no hyphen (-) between XXXX
> > and message. There is only one space.
> >
> > How to contribute doc [1] doesn't state this as requirement and just
> > contains some examples of commit message/PR title. But there are no
> > docs that requires colon and/or hyphen. So the best approach here is
> > *uniformity*.
> >
> > [1] https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
> >

Reply via email to