Re: Change IGNITE_PDS_WAL_REBALANCE_THRESHOLD from System property to Configuraton

2021-05-17 Thread Eduard Rakhmankulov
Hello Stan! Thank you for the discussion about this topic. I've created a new Jira ticket and I am going to work on it. Jira: https://issues.apache.org/jira/browse/IGNITE-14728. On Fri, 14 May 2021 at 13:26, Stanislav Lukyanov wrote: > Hi Eduard, > > I think IGNITE_PDS_WAL_REBALANCE_THRESHOLD n

Re: Change IGNITE_PDS_WAL_REBALANCE_THRESHOLD from System property to Configuraton

2021-05-14 Thread Stanislav Lukyanov
Hi Eduard, I think IGNITE_PDS_WAL_REBALANCE_THRESHOLD needs to be kept for backwards compatibility. I suggest that it is used as a source of the default value for the new DMS property: 1. On node start (or perhaps on cluster activation?) the wal.rebalance.threshold DMS property is checked 2. I

Re: Change IGNITE_PDS_WAL_REBALANCE_THRESHOLD from System property to Configuraton

2021-05-13 Thread Eduard Rakhmankulov
Hello! Further investigation has showed, that there is a boolean system property which blocks mbean creation, therefore property management through JMX is not a great idea. I found control.sh utility feature that enables distributed property management (--property (set | get | list) ). I propose

Re: Change IGNITE_PDS_WAL_REBALANCE_THRESHOLD from System property to Configuraton

2021-05-12 Thread Eduard Rakhmankulov
Hi! I propose to add a new MBean linked to DMS that contains the property IGNITE_PDS_WAL_REBALANCE_THRESHOLD. That enables configuration through JMX. WDYT? On Tue, 11 May 2021 at 16:52, Eduard Rakhmankulov wrote: > Hi Stanislav, > > I think this is an excellent idea to use distributed metasto

Re: Change IGNITE_PDS_WAL_REBALANCE_THRESHOLD from System property to Configuraton

2021-05-11 Thread Eduard Rakhmankulov
Hi Stanislav, I think this is an excellent idea to use distributed metastore. Should I leave system property for backward compatibility? On Sun, 9 May 2021 at 19:04, Atri Sharma wrote: > +1 > > On Sun, 9 May 2021, 21:33 Stanislav Lukyanov, > wrote: > > > Hi Eduard, > > > > I strongly believe

Re: Change IGNITE_PDS_WAL_REBALANCE_THRESHOLD from System property to Configuraton

2021-05-09 Thread Atri Sharma
+1 On Sun, 9 May 2021, 21:33 Stanislav Lukyanov, wrote: > Hi Eduard, > > I strongly believe that if a configuration option is cluster wide then it > belongs to distributed metastore and not to IgniteConfiguration. > This allows to get cluster-wide consistency guarantees and API for dynamic > cha

Re: Change IGNITE_PDS_WAL_REBALANCE_THRESHOLD from System property to Configuraton

2021-05-09 Thread Stanislav Lukyanov
Hi Eduard, I strongly believe that if a configuration option is cluster wide then it belongs to distributed metastore and not to IgniteConfiguration. This allows to get cluster-wide consistency guarantees and API for dynamic change out of the box (need to teach the internals to re-read the prope

Re: Change IGNITE_PDS_WAL_REBALANCE_THRESHOLD from System property to Configuraton

2021-05-06 Thread Eduard Rakhmankulov
Some addition. I want to add configuration to org.apache.ignite.configuration.DataStorageConfiguration#getDefaultWarmUpConfiguration#getP artitionWalRebalanceThreshold which will have same semantics as system property (number of entries in WAL to trigger rebalance). On Thu, 6 May 2021 at 15:50, E