+1 On Sun, 9 May 2021, 21:33 Stanislav Lukyanov, <stanlukya...@gmail.com> wrote:
> Hi Eduard, > > I strongly believe that if a configuration option is cluster wide then it > belongs to distributed metastore and not to IgniteConfiguration. > This allows to get cluster-wide consistency guarantees and API for dynamic > change out of the box (need to teach the internals to re-read the property > from DMS every time of course). > > WDYT? > > Stan > > > On 6 May 2021, at 16:35, Eduard Rakhmankulov <erixon...@gmail.com> > wrote: > > > > Some addition. > > > > I want to add configuration to > > > org.apache.ignite.configuration.DataStorageConfiguration#getDefaultWarmUpConfiguration#getP > > artitionWalRebalanceThreshold > > which will have same semantics as system property (number of entries in > WAL > > to trigger rebalance). > > > > On Thu, 6 May 2021 at 15:50, Eduard Rakhmankulov <erixon...@gmail.com> > > wrote: > > > >> Hello, Igniters! > >> > >> I suggest changing IGNITE_PDS_WAL_REBALANCE_THRESHOLD from system > >> properties to IgniteConfiguration. > >> This configuration is effectively cluster-wide (because only the > >> coordinator's configuration matters when the heuristic with this > property > >> applies). > >> > >> It is easier to validate that we have the same configuration on all > nodes > >> than system property (in the case when another coordinator was elected). > >> > >> -- > >> Best regards, Eduard. > >> > > > > > > -- > > С уважением, Рахманкулов Э.Р. > >
