Re: Ignite-4795 - ready for review (Inherit TransactionException and update Javadoc)

2017-04-12 Thread Andrey Gura
Dmitry, thanks a lot for your contribution. Changes are merged into master branch. On Mon, Apr 10, 2017 at 7:07 PM, Andrey Gura wrote: > Thanks, Dmitry! I've reviewed your changes again and will merge it > after TC results. > > On Mon, Apr 10, 2017 at 3:08 PM, Дмитрий Рябов wrote: >> Andrey, ac

Re: Ignite-4795 - ready for review (Inherit TransactionException and update Javadoc)

2017-04-10 Thread Andrey Gura
Thanks, Dmitry! I've reviewed your changes again and will merge it after TC results. On Mon, Apr 10, 2017 at 3:08 PM, Дмитрий Рябов wrote: > Andrey, actual PR is 1630. PR 1631 was created by mistake and I closed it > immediately after creating (couse ticket must have only 1 PR, isn't it?). > So t

Re: Ignite-4795 - ready for review (Inherit TransactionException and update Javadoc)

2017-04-10 Thread Дмитрий Рябов
Andrey, actual PR is 1630. PR 1631 was created by mistake and I closed it immediately after creating (couse ticket must have only 1 PR, isn't it?). So ticket has only one attached link to "GitHub Pull Request #1630". 2017-04-10 14:24 GMT+03:00 Andrey Gura : > Dmitry, > > this review is in progres

Re: Ignite-4795 - ready for review (Inherit TransactionException and update Javadoc)

2017-04-10 Thread Andrey Gura
Dmitry, this review is in progress. But I'm confused about PR number because in JIRA ticket we discussed PR 1631. What is actual PR number for latest changes? On Mon, Apr 10, 2017 at 11:38 AM, Дмитрий Рябов wrote: > Hello, igniters. Please, review. > > PR: https://github.com/apache/ignite/pull/1

Ignite-4795 - ready for review (Inherit TransactionException and update Javadoc)

2017-04-10 Thread Дмитрий Рябов
Hello, igniters. Please, review. PR: https://github.com/apache/ignite/pull/1630/files JIRA: https://issues.apache.org/jira/browse/IGNITE-4795

Re: Ignite-4795 - ready for review

2017-04-04 Thread Дмитрий Рябов
Andrey, I made fix, can you look it again? 2017-03-28 20:40 GMT+03:00 Andrey Gura : > Dmitry, see JIRA ticket for review comments. > > On Mon, Mar 27, 2017 at 6:13 PM, Denis Magda wrote: > > Hello Dmitriy, thanks! Someone will have a look at your changes soon. > Sorry for the delay. > > > > — >

Re: Ignite-4795 - ready for review

2017-03-28 Thread Andrey Gura
Dmitry, see JIRA ticket for review comments. On Mon, Mar 27, 2017 at 6:13 PM, Denis Magda wrote: > Hello Dmitriy, thanks! Someone will have a look at your changes soon. Sorry > for the delay. > > — > Denis > >> On Mar 27, 2017, at 3:24 AM, Дмитрий Рябов wrote: >> >> Hello, can anyone review thi

Re: Ignite-4795 - ready for review

2017-03-27 Thread Denis Magda
Hello Dmitriy, thanks! Someone will have a look at your changes soon. Sorry for the delay. — Denis > On Mar 27, 2017, at 3:24 AM, Дмитрий Рябов wrote: > > Hello, can anyone review this issue? > > 2017-03-20 16:33 GMT+03:00 Дмитрий Рябов : > >> Done. >> >> 2017-03-20 16:30 GMT+03:00 Антон Чу

Re: Ignite-4795 - ready for review

2017-03-27 Thread Дмитрий Рябов
Hello, can anyone review this issue? 2017-03-20 16:33 GMT+03:00 Дмитрий Рябов : > Done. > > 2017-03-20 16:30 GMT+03:00 Антон Чураев : > >> Dmitry, thank you! >> >> Could you please also change issue status to "Patch available". >> >> 2017-03-20 16:01 GMT+03:00 Дмитрий Рябов : >> >> > Hello, commu

Re: Ignite-4795 - ready for review

2017-03-20 Thread Дмитрий Рябов
Done. 2017-03-20 16:30 GMT+03:00 Антон Чураев : > Dmitry, thank you! > > Could you please also change issue status to "Patch available". > > 2017-03-20 16:01 GMT+03:00 Дмитрий Рябов : > > > Hello, community. Please, review and/or suggest something about javadocs > of > > transactions. > > > > PR:

Re: Ignite-4795 - ready for review

2017-03-20 Thread Антон Чураев
Dmitry, thank you! Could you please also change issue status to "Patch available". 2017-03-20 16:01 GMT+03:00 Дмитрий Рябов : > Hello, community. Please, review and/or suggest something about javadocs of > transactions. > > PR: https://github.com/apache/ignite/pull/1630/files > > JIRA: https://i

Ignite-4795 - ready for review

2017-03-20 Thread Дмитрий Рябов
Hello, community. Please, review and/or suggest something about javadocs of transactions. PR: https://github.com/apache/ignite/pull/1630/files JIRA: https://issues.apache.org/jira/browse/IGNITE-4795