Re: IGNITE-817: [Test] Disabled tests of GridCacheOffHeapTest

2017-02-14 Thread Александр Меньшиков
Done. PR: https://github.com/apache/ignite/pull/1527 I just ran the tests : http://ci.ignite.apache.org/project.html?projectId=IgniteTests&tab=projectOverview&branch_IgniteTests=pull/1527/head 2017-02-14 12:36 GMT+03:00 Александр Меньшиков : > Yep, i will do it immediately > > 2017-02-13 23:12 G

Re: IGNITE-817: [Test] Disabled tests of GridCacheOffHeapTest

2017-02-14 Thread Александр Меньшиков
Yep, i will do it immediately 2017-02-13 23:12 GMT+03:00 Denis Magda : > Alexander, could you wipe out this test then making the code clean? > > — > Denis > > > On Feb 12, 2017, at 11:24 PM, Semyon Boikov > wrote: > > > > Hi, > > > > GridCacheOffHeapTest is some very old class and I think it can

Re: IGNITE-817: [Test] Disabled tests of GridCacheOffHeapTest

2017-02-13 Thread Denis Magda
Alexander, could you wipe out this test then making the code clean? — Denis > On Feb 12, 2017, at 11:24 PM, Semyon Boikov wrote: > > Hi, > > GridCacheOffHeapTest is some very old class and I think it can be removed. > Currently all actual benchmarks are in 'benchmarks' and 'yardstick' modules.

Re: IGNITE-817: [Test] Disabled tests of GridCacheOffHeapTest

2017-02-12 Thread Semyon Boikov
Hi, GridCacheOffHeapTest is some very old class and I think it can be removed. Currently all actual benchmarks are in 'benchmarks' and 'yardstick' modules. Thanks On Sat, Feb 11, 2017 at 3:18 AM, Denis Magda wrote: > Yakov, Sam? > > Please join and share your thoughts. > > — > Denis > > > On F

Re: IGNITE-817: [Test] Disabled tests of GridCacheOffHeapTest

2017-02-10 Thread Denis Magda
Yakov, Sam? Please join and share your thoughts. — Denis > On Feb 10, 2017, at 7:08 AM, Александр Меньшиков wrote: > > Denis, thank you for information. I see JMH in pom file in benchmarks > module. So this must be removed or it's okay for micro-benchmarks? > > 2017-02-10 0:04 GMT+03:00 Denis

Re: IGNITE-817: [Test] Disabled tests of GridCacheOffHeapTest

2017-02-10 Thread Александр Меньшиков
Denis, thank you for information. I see JMH in pom file in benchmarks module. So this must be removed or it's okay for micro-benchmarks? 2017-02-10 0:04 GMT+03:00 Denis Magda : > Alexander, > > We use Yardstick benchmarks for performance measurements of Ignite: > https://github.com/apacheignite/y

Re: IGNITE-817: [Test] Disabled tests of GridCacheOffHeapTest

2017-02-09 Thread Denis Magda
Alexander, We use Yardstick benchmarks for performance measurements of Ignite: https://github.com/apacheignite/yardstick-ignite In 1.9 it will be much easier to execute the benchmarks directly from Apache Ignite bundle: http://apache-ignite-dev

IGNITE-817: [Test] Disabled tests of GridCacheOffHeapTest

2017-02-09 Thread Александр Меньшиков
Hello, everyone. GridCacheOffHeapTest is about the Off-heap benchmarks. As I understand it right now we haven't clear vision how better make benchmarks in Ignite. If it's not true, please make me know. I think it's a good idea to make benchmarks with JMH framework. It can be load with maven, r