Re: DiscoverySpi#setDataExchange returns concrete implementation

2017-05-30 Thread Yakov Zhdanov
yes --Yakov 2017-05-29 17:30 GMT+03:00 Николай Ижиков : > Thanks Yakov. > > I moved IGNITE-5321 to resolved state. > Is that right? > > 2017-05-29 17:24 GMT+03:00 Yakov Zhdanov : > > > Merged. Thanks for contribution, Nick. Please also see my edits. > > > > --Yakov > > > > 2017-05-28 19:29 GMT+0

Re: DiscoverySpi#setDataExchange returns concrete implementation

2017-05-29 Thread Николай Ижиков
Thanks Yakov. I moved IGNITE-5321 to resolved state. Is that right? 2017-05-29 17:24 GMT+03:00 Yakov Zhdanov : > Merged. Thanks for contribution, Nick. Please also see my edits. > > --Yakov > > 2017-05-28 19:29 GMT+03:00 Николай Ижиков : > > > Hello. Here is pull request for this issue: > > > >

Re: DiscoverySpi#setDataExchange returns concrete implementation

2017-05-29 Thread Yakov Zhdanov
Merged. Thanks for contribution, Nick. Please also see my edits. --Yakov 2017-05-28 19:29 GMT+03:00 Николай Ижиков : > Hello. Here is pull request for this issue: > > https://github.com/apache/ignite/pull/2022 > > 2017-05-26 13:16 GMT+03:00 Yakov Zhdanov : > > > Hi Nick! Good catch. Please go ah

Re: DiscoverySpi#setDataExchange returns concrete implementation

2017-05-28 Thread Николай Ижиков
Hello. Here is pull request for this issue: https://github.com/apache/ignite/pull/2022 2017-05-26 13:16 GMT+03:00 Yakov Zhdanov : > Hi Nick! Good catch. Please go ahead and submit a patch. > > --Yakov > > 2017-05-26 13:09 GMT+03:00 Николай Ижиков : > > > Hello, guys. > > > > public interface Dis

[jira] [Created] (IGNITE-5321) DiscoverySpi#setDataExchange returns concrete implementation

2017-05-28 Thread Nikolay Izhikov (JIRA)
Nikolay Izhikov created IGNITE-5321: --- Summary: DiscoverySpi#setDataExchange returns concrete implementation Key: IGNITE-5321 URL: https://issues.apache.org/jira/browse/IGNITE-5321 Project: Ignite

Re: DiscoverySpi#setDataExchange returns concrete implementation

2017-05-26 Thread Yakov Zhdanov
Hi Nick! Good catch. Please go ahead and submit a patch. --Yakov 2017-05-26 13:09 GMT+03:00 Николай Ижиков : > Hello, guys. > > public interface DiscoverySpi extends IgniteSpi { > > TcpDiscoverySpi setDataExchange(DiscoverySpiDataExchange var1); > > TcpDiscoverySpi setMetricsProvide

DiscoverySpi#setDataExchange returns concrete implementation

2017-05-26 Thread Николай Ижиков
Hello, guys. public interface DiscoverySpi extends IgniteSpi { TcpDiscoverySpi setDataExchange(DiscoverySpiDataExchange var1); TcpDiscoverySpi setMetricsProvider(DiscoveryMetricsProvider var1); ... } Two methods of DiscoverySpi returns concrete implementation. I think we should retu