Hello. Here is pull request for this issue: https://github.com/apache/ignite/pull/2022
2017-05-26 13:16 GMT+03:00 Yakov Zhdanov <[email protected]>: > Hi Nick! Good catch. Please go ahead and submit a patch. > > --Yakov > > 2017-05-26 13:09 GMT+03:00 Николай Ижиков <[email protected]>: > > > Hello, guys. > > > > public interface DiscoverySpi extends IgniteSpi { > > .... > > TcpDiscoverySpi setDataExchange(DiscoverySpiDataExchange var1); > > > > TcpDiscoverySpi setMetricsProvider(DiscoveryMetricsProvider var1); > > ... > > } > > > > Two methods of DiscoverySpi returns concrete implementation. > > I think we should return interface, not implementation from this methods > > Or why we need an interface? > > > > I can provide simple patch to fix this issue. > > > > -- > > Nikolay Izhikov > > [email protected] > > > -- Nikolay Izhikov [email protected]
